Mailing List Archive: Quagga: Dev

[PATCH 0/4] Some SPF/unnumbered updates

Index | Next | Previous | View Threaded

Joakim.Tjernlund at transmode

Jul 7, 2012, 8:06 AM

Post #1 of 7 (427 views)
Permalink

[PATCH 0/4] Some SPF/unnumbered updates

I forward ported some of my unnumbered paches to current master.
This is only compile tested but I figured it was better than nothing.

Jocke

Joakim Tjernlund (4):
ospfd: Optimize and improve SPF nexthop calculation
ospf_spf_process_stubs: use LSA pos to find OSFP interface
zebra/ospf: Add support for ZEBRA_NEXTHOP_IPV4_IFINDEX
ospfd: Do not fall back to intervening router.

ospfd/ospf_interface.c | 18 +++++
ospfd/ospf_interface.h | 6 ++
ospfd/ospf_lsa.c | 2 +
ospfd/ospf_route.c | 4 +-
ospfd/ospf_route.h | 2 +-
ospfd/ospf_spf.c | 179 +++++++++++++++++++++--------------------------
ospfd/ospf_zebra.c | 130 ++++++++++++++++++++++-------------
zebra/zserv.c | 9 +++
8 files changed, 200 insertions(+), 150 deletions(-)

--
1.7.3.4

_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev

joakim.tjernlund at transmode

Jul 17, 2012, 1:04 PM

Post #2 of 7 (377 views)
Permalink

Re: [PATCH 0/4] Some SPF/unnumbered updates [In reply to]

Ping? Any interested parties ?

Jocke

Joakim Tjernlund <Joakim.Tjernlund [at] transmode> wrote on 2012/07/07 17:06:10:
>
> I forward ported some of my unnumbered paches to current master.
> This is only compile tested but I figured it was better than nothing.
>
> Jocke
>
> Joakim Tjernlund (4):
> ospfd: Optimize and improve SPF nexthop calculation
> ospf_spf_process_stubs: use LSA pos to find OSFP interface
> zebra/ospf: Add support for ZEBRA_NEXTHOP_IPV4_IFINDEX
> ospfd: Do not fall back to intervening router.
>
> ospfd/ospf_interface.c | 18 +++++
> ospfd/ospf_interface.h | 6 ++
> ospfd/ospf_lsa.c | 2 +
> ospfd/ospf_route.c | 4 +-
> ospfd/ospf_route.h | 2 +-
> ospfd/ospf_spf.c | 179 +++++++++++++++++++++--------------------------
> ospfd/ospf_zebra.c | 130 ++++++++++++++++++++++-------------
> zebra/zserv.c | 9 +++
> 8 files changed, 200 insertions(+), 150 deletions(-)
>
> --
> 1.7.3.4
>

_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev

sfeldma at cumulusnetworks

Jul 17, 2012, 1:15 PM

Post #3 of 7 (374 views)
Permalink

Re: [PATCH 0/4] Some SPF/unnumbered updates [In reply to]

On Jul 17, 2012, at 1:04 PM, Joakim Tjernlund wrote:

> Ping? Any interested parties ?

Yes, interested. Thanks for forward porting these Jocke. I'm currently looking at an SPF nexthop issue that may or may not be fixed by your update, so I'm interested for that but also want to try out unnumbered. Feedback soon.

-scott
_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev

joakim.tjernlund at transmode

Jul 17, 2012, 1:29 PM

Post #4 of 7 (379 views)
Permalink

Re: [PATCH 0/4] Some SPF/unnumbered updates [In reply to]

Scott Feldman <sfeldma [at] cumulusnetworks> wrote on 2012/07/17 22:15:33:
>
> On Jul 17, 2012, at 1:04 PM, Joakim Tjernlund wrote:
>
> > Ping? Any interested parties ?
>
> Yes, interested. Thanks for forward porting these Jocke. I'm currently looking at an SPF nexthop issue that may or may not be fixed by your update, so I'm interested for that but also want to try out unnumbered. Feedback soon.

Cool! There is still hope for unnumbered then :)

_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev

equinox at opensourcerouting

Jul 19, 2012, 6:13 AM

Post #5 of 7 (370 views)
Permalink

Re: [PATCH 0/4] Some SPF/unnumbered updates [In reply to]

On Tue, Jul 17, 2012 at 10:04:12PM +0200, Joakim Tjernlund wrote:
> Ping? Any interested parties ?

I'm picking up the entire batch, with the IFINDEX one split into two
halves (zebra + ospfd).

(I finally sat down and spent 2 weeks getting ospfd's SPF code into my
head. Now you know why I had migraines *g* - boy, is that some sh*tty
code. I think your patches are correct, if even conservative. TBFH I
had to control an urge to "rm ospf_spf.c" several times...)

-David

> Joakim Tjernlund <Joakim.Tjernlund [at] transmode> wrote on 2012/07/07 17:06:10:
> >
> > I forward ported some of my unnumbered paches to current master.
> > This is only compile tested but I figured it was better than nothing.
> >
> > Jocke
> >
> > Joakim Tjernlund (4):
> > ospfd: Optimize and improve SPF nexthop calculation
> > ospf_spf_process_stubs: use LSA pos to find OSFP interface
> > zebra/ospf: Add support for ZEBRA_NEXTHOP_IPV4_IFINDEX
> > ospfd: Do not fall back to intervening router.
> >
> > ospfd/ospf_interface.c | 18 +++++
> > ospfd/ospf_interface.h | 6 ++
> > ospfd/ospf_lsa.c | 2 +
> > ospfd/ospf_route.c | 4 +-
> > ospfd/ospf_route.h | 2 +-
> > ospfd/ospf_spf.c | 179 +++++++++++++++++++++--------------------------
> > ospfd/ospf_zebra.c | 130 ++++++++++++++++++++++-------------
> > zebra/zserv.c | 9 +++
> > 8 files changed, 200 insertions(+), 150 deletions(-)
> >
> > --
> > 1.7.3.4
> >
>
> _______________________________________________
> Quagga-dev mailing list
> Quagga-dev [at] lists
> http://lists.quagga.net/mailman/listinfo/quagga-dev

Attachments:

signature.asc (0.22 KB)

joakim.tjernlund at transmode

Jul 19, 2012, 10:03 AM

Post #6 of 7 (369 views)
Permalink

Re: [PATCH 0/4] Some SPF/unnumbered updates [In reply to]

<equinox [at] diac24> wrote on 2012/07/19 15:13:12:
>
> On Tue, Jul 17, 2012 at 10:04:12PM +0200, Joakim Tjernlund wrote:
> > Ping? Any interested parties ?
>
> I'm picking up the entire batch, with the IFINDEX one split into two
> halves (zebra + ospfd).

Great!

>
>
> (I finally sat down and spent 2 weeks getting ospfd's SPF code into my
> head. Now you know why I had migraines *g* - boy, is that some sh*tty
> code. I think your patches are correct, if even conservative. TBFH I
> had to control an urge to "rm ospf_spf.c" several times...)

Yes, Quagga has a lot of naive/unoptimal code, sure would like to fix some of it.
That would we a different quest though. The VLINK code is ugly, naive and buggy too.

Jocke

>
>
> -David
>
> > Joakim Tjernlund <Joakim.Tjernlund [at] transmode> wrote on 2012/07/07 17:06:10:
> > >
> > > I forward ported some of my unnumbered paches to current master.
> > > This is only compile tested but I figured it was better than nothing.
> > >
> > > Jocke
> > >
> > > Joakim Tjernlund (4):
> > > ospfd: Optimize and improve SPF nexthop calculation
> > > ospf_spf_process_stubs: use LSA pos to find OSFP interface
> > > zebra/ospf: Add support for ZEBRA_NEXTHOP_IPV4_IFINDEX
> > > ospfd: Do not fall back to intervening router.
> > >
> > > ospfd/ospf_interface.c | 18 +++++
> > > ospfd/ospf_interface.h | 6 ++
> > > ospfd/ospf_lsa.c | 2 +
> > > ospfd/ospf_route.c | 4 +-
> > > ospfd/ospf_route.h | 2 +-
> > > ospfd/ospf_spf.c | 179 +++++++++++++++++++++--------------------------
> > > ospfd/ospf_zebra.c | 130 ++++++++++++++++++++++-------------
> > > zebra/zserv.c | 9 +++
> > > 8 files changed, 200 insertions(+), 150 deletions(-)
> > >
> > > --
> > > 1.7.3.4
> > >
> >
> > _______________________________________________
> > Quagga-dev mailing list
> > Quagga-dev [at] lists
> > http://lists.quagga.net/mailman/listinfo/quagga-dev
> [attachment "signature.asc" deleted by Joakim Tjernlund/Transmode]

_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev

paul at jakma

Jul 25, 2012, 10:50 AM

Post #7 of 7 (339 views)
Permalink

Re: [PATCH 0/4] Some SPF/unnumbered updates [In reply to]

On Thu, 19 Jul 2012, David Lamparter wrote:

> (I finally sat down and spent 2 weeks getting ospfd's SPF code into my
> head. Now you know why I had migraines *g* - boy, is that some sh*tty
> code. I think your patches are correct, if even conservative. TBFH I
> had to control an urge to "rm ospf_spf.c" several times...)

The code isn't the prettiest. However, don't attribute all of the
complexity to just the code itself. There's a lot of abstract detail in
terms of verifying links and LSAs, that make this complex than SPF is.

Also, OSPF SPF code has to deal with semi-converged graphs. Trying to
reason about the implications of that can be hard.

regards,
--
Paul Jakma paul [at] jakma @pjakma Key ID: 64A2FF6A
Fortune:
Above all things, reverence yourself.
_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads