equinox at opensourcerouting
May 22, 2012, 11:35 AM
Post #2 of 2
On Mon, May 07, 2012 at 07:53:07PM +0200, Jorge Boncompte [DTI2] wrote:
Re: [PATCH 17/25] bgpd: optimize holdtime timer cancelling
[In reply to]
> From: "Jorge Boncompte [DTI2]" <jorge [at] dti2>
> * bgp_packet.c: (bgp_update_receive) for every update received we queue
> an event just to cancel the holdtime timer, done in bgp_fsm_update().
> Instead cancel the timer directly an avoid a scheduling pass.
> This incidently fixes another problem found on a slow box, where thousands
> of events threads were queued, and run, but never freed, because they are
> moved to the unused list that grows without bounds.
> - /* Generate BGP event. */
> - BGP_EVENT_ADD (peer, Receive_UPDATE_message);
Since with this, Receive_UPDATE_message is not triggered at all anymore,
does anyone have a good reason for not removing it altogether?