Mailing List Archive: Quagga: Dev

[PATCH] patchwork up & running

Index | Next | Previous | View Threaded

equinox at diac24

May 10, 2012, 5:46 AM

Post #1 of 10 (618 views)
Permalink

[PATCH] patchwork up & running

there is now a patchwork up & running at http://patchwork.quagga.net/

and this is a patch to test it :)

(the old patchwork at http://patchwork.diac24.net had to be flushed because the
update broke the mysql data. that address is now an alias to the new one at
patchwork.quagga.net. it's using postgres now.)
---
FNORD | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
create mode 100644 FNORD

diff --git a/FNORD b/FNORD
new file mode 100644
index 0000000..824fddb
--- /dev/null
+++ b/FNORD
@@ -0,0 +1 @@
+fnord!
--
1.7.8.4

_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev

joakim.tjernlund at transmode

May 10, 2012, 8:00 AM

Post #2 of 10 (584 views)
Permalink

Re: [PATCH] patchwork up & running [In reply to]

>
> there is now a patchwork up & running at http://patchwork.quagga.net/

Great! One small request though: It would be great if patchwork could include
the cover letter (PATCH 0/8 etc.) too.

Jocke

_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev

equinox at diac24

May 10, 2012, 8:11 AM

Post #3 of 10 (588 views)
Permalink

Re: [PATCH] patchwork up & running [In reply to]

On Thu, May 10, 2012 at 05:00:05PM +0200, Joakim Tjernlund wrote:
> >
> > there is now a patchwork up & running at http://patchwork.quagga.net/
>
> Great! One small request though: It would be great if patchwork could include
> the cover letter (PATCH 0/8 etc.) too.

You'd need to contact the ozlabs guys about that
(http://ozlabs.org/~jk/projects/patchwork/).
I don't really hack on patchwork... (I touched the CSS *cough*)

Also, there's apparently a tool to automatically mark patches from git
as applied in patchwork - if that works that'd be really awesome I
fathom. I'll be fiddling with it after getting the OSPF unnumbered
stuff off my employer-side TODO.

-David

Attachments:

signature.asc (0.22 KB)

joakim.tjernlund at transmode

May 10, 2012, 8:22 AM

Post #4 of 10 (578 views)
Permalink

Re: [PATCH] patchwork up & running [In reply to]

David Lamparter <equinox [at] diac24> wrote on 2012/05/10 17:11:51:
>
> On Thu, May 10, 2012 at 05:00:05PM +0200, Joakim Tjernlund wrote:
> > >
> > > there is now a patchwork up & running at http://patchwork.quagga.net/
> >
> > Great! One small request though: It would be great if patchwork could include
> > the cover letter (PATCH 0/8 etc.) too.
>
> You'd need to contact the ozlabs guys about that
> (http://ozlabs.org/~jk/projects/patchwork/).
> I don't really hack on patchwork... (I touched the CSS *cough*)

OK, I was hoping it was simple fix ..

>
> Also, there's apparently a tool to automatically mark patches from git
> as applied in patchwork - if that works that'd be really awesome I

That would be awesome.

> fathom. I'll be fiddling with it after getting the OSPF unnumbered
> stuff off my employer-side TODO.

Cool, I hope you are basing this off my old patches?

BTW, the link I sent the other day will be useful eventually for
unnumbered too(http://lists.quagga.net/pipermail/quagga-dev/2009-November/007439.html)

hmm, I just recall that this bug inspired the above patch series:
http://patchwork.quagga.net/patch/537/

Jocke

_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev

equinox at diac24

May 10, 2012, 10:12 AM

Post #5 of 10 (583 views)
Permalink

Re: [PATCH] patchwork up & running [In reply to]

On Thu, May 10, 2012 at 05:22:05PM +0200, Joakim Tjernlund wrote:
> Cool, I hope you are basing this off my old patches?

Yes, I am. Actually it's kind of a 3-way merge; your code, code from a
sponsor, and some changes of my own. I'm discussing it with the sponsor
tomorrow and will post it to -dev for comments after we've merged our
ideas/opinions.

> BTW, the link I sent the other day will be useful eventually for
> unnumbered too(http://lists.quagga.net/pipermail/quagga-dev/2009-November/007439.html)

I think I'm carrying that in -dn42; going through that is on the TODO.
Still figuring out some of the task management & planning here...

Either way, thanks for the pointer. Getting 'bumps' on which old
patches are important still is very useful!

-David

Attachments:

signature.asc (0.22 KB)

joakim.tjernlund at transmode

May 10, 2012, 11:20 AM

Post #6 of 10 (578 views)
Permalink

Re: [PATCH] patchwork up & running [In reply to]

David Lamparter <equinox [at] diac24> wrote on 2012/05/10 19:12:55:
>
> On Thu, May 10, 2012 at 05:22:05PM +0200, Joakim Tjernlund wrote:
> > Cool, I hope you are basing this off my old patches?
>
> Yes, I am. Actually it's kind of a 3-way merge; your code, code from a
> sponsor, and some changes of my own. I'm discussing it with the sponsor
> tomorrow and will post it to -dev for comments after we've merged our
> ideas/opinions.

Cool, I have one request though, please keep my patches as is and add
yours on top. I won't be able to look at the whole thing but I would like
to look at the new stuff.

>
> > BTW, the link I sent the other day will be useful eventually for
> > unnumbered too(http://lists.quagga.net/pipermail/quagga-dev/2009-November/007439.html)
>
> I think I'm carrying that in -dn42; going through that is on the TODO.
> Still figuring out some of the task management & planning here...

Ahh, I see them. You have even fixed some places I forgot to update :)
However, I don't see
http://patchwork.quagga.net/patch/537/
As I recall this one stands on it own.

Jocke

_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev

joakim.tjernlund at transmode

Jun 6, 2012, 6:34 AM

Post #7 of 10 (477 views)
Permalink

Re: [PATCH] patchwork up & running [In reply to]

equinox at opensourcerouting

Jun 7, 2012, 10:03 AM

Post #8 of 10 (470 views)
Permalink

Re: [PATCH] patchwork up & running [In reply to]

On Wed, Jun 06, 2012 at 03:34:56PM +0200, Joakim Tjernlund wrote:
> David Lamparter <equinox [at] diac24> wrote on 2012/05/10 19:12:55:
> >
> > On Thu, May 10, 2012 at 05:22:05PM +0200, Joakim Tjernlund wrote:
> > > Cool, I hope you are basing this off my old patches?
> >
> > Yes, I am. Actually it's kind of a 3-way merge; your code, code from a
> > sponsor, and some changes of my own. I'm discussing it with the sponsor
> > tomorrow and will post it to -dev for comments after we've merged our
> > ideas/opinions.
>
> Anything to show yet?
> I stumbled on the unnumbered branch at opensourcerouting.org, from a quick look
> I must say that I don't agree with them, especially the SPF one. That one looks
> like it is based on some old patch of mine that wasn't the solution in the end.

We're just coming about on a lengthy discussion about how to handle the
actual ddress selection and configuration. We didn't quite know our own
opinion, so this discussion happened non-publicly. I'll give a short
summary and invite comments soon.

On the SPF code, can you give me a pointer to your current code? I'd
like to address your feedback, but I kinda need you to be a little more
constructive here :)

-David

Attachments:

signature.asc (0.22 KB)

joakim.tjernlund at transmode

Jun 8, 2012, 12:01 AM

Post #9 of 10 (471 views)
Permalink

Re: [PATCH] patchwork up & running [In reply to]

<equinox [at] diac24> wrote on 2012/06/07 19:03:32:
>
> On Wed, Jun 06, 2012 at 03:34:56PM +0200, Joakim Tjernlund wrote:
> > David Lamparter <equinox [at] diac24> wrote on 2012/05/10 19:12:55:
> > >
> > > On Thu, May 10, 2012 at 05:22:05PM +0200, Joakim Tjernlund wrote:
> > > > Cool, I hope you are basing this off my old patches?
> > >
> > > Yes, I am. Actually it's kind of a 3-way merge; your code, code from a
> > > sponsor, and some changes of my own. I'm discussing it with the sponsor
> > > tomorrow and will post it to -dev for comments after we've merged our
> > > ideas/opinions.
> >
> > Anything to show yet?
> > I stumbled on the unnumbered branch at opensourcerouting.org, from a quick look
> > I must say that I don't agree with them, especially the SPF one. That one looks
> > like it is based on some old patch of mine that wasn't the solution in the end.
>
> We're just coming about on a lengthy discussion about how to handle the
> actual ddress selection and configuration. We didn't quite know our own
> opinion, so this discussion happened non-publicly. I'll give a short
> summary and invite comments soon.
>
> On the SPF code, can you give me a pointer to your current code? I'd
> like to address your feedback, but I kinda need you to be a little more
> constructive here :)

Here is the SPF one
http://patchwork.quagga.net/patch/263/

Jocke

_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev

joakim.tjernlund at transmode

Jun 8, 2012, 12:15 AM

Post #10 of 10 (467 views)
Permalink

Re: [PATCH] patchwork up & running [In reply to]

Joakim Tjernlund/Transmode wrote on 2012/06/08 09:01:29:
>
> <equinox [at] diac24> wrote on 2012/06/07 19:03:32:
> >
> > On Wed, Jun 06, 2012 at 03:34:56PM +0200, Joakim Tjernlund wrote:
> > > David Lamparter <equinox [at] diac24> wrote on 2012/05/10 19:12:55:
> > > >
> > > > On Thu, May 10, 2012 at 05:22:05PM +0200, Joakim Tjernlund wrote:
> > > > > Cool, I hope you are basing this off my old patches?
> > > >
> > > > Yes, I am. Actually it's kind of a 3-way merge; your code, code from a
> > > > sponsor, and some changes of my own. I'm discussing it with the sponsor
> > > > tomorrow and will post it to -dev for comments after we've merged our
> > > > ideas/opinions.
> > >
> > > Anything to show yet?
> > > I stumbled on the unnumbered branch at opensourcerouting.org, from a quick look
> > > I must say that I don't agree with them, especially the SPF one. That one looks
> > > like it is based on some old patch of mine that wasn't the solution in the end.

Found my old patch(http://patchwork.quagga.net/patch/268/).
This looks very similar to what is in
https://github.com/opensourcerouting/quagga/commit/bd377461beecb2156cf3e8c3443381fe0e8d7d64

My patch description has the disadvantages of doing it this way:
Add support for real unnumbered PtP interfaces in
ospf_nexthop_calculation().
Add ospf_if_lookup_by_ifindex() to support Unnumbered
PtP links. This version does not support:
- Multiple numbered PtP interfaces with the same IP address
between the same two routers.
- Unnumbered PtP on just one end of the link.

> >
> > We're just coming about on a lengthy discussion about how to handle the
> > actual ddress selection and configuration. We didn't quite know our own
> > opinion, so this discussion happened non-publicly. I'll give a short
> > summary and invite comments soon.
> >
> > On the SPF code, can you give me a pointer to your current code? I'd
> > like to address your feedback, but I kinda need you to be a little more
> > constructive here :)
>
> Here is the SPF one
> http://patchwork.quagga.net/patch/263/

_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads