Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Quagga: Dev

[PATCH 2/6] doc: only package man pages for daemons that are built

 

 

Quagga dev RSS feed   Index | Next | Previous | View Threaded


david.ward at ll

Apr 29, 2012, 1:47 PM

Post #1 of 4 (126 views)
Permalink
[PATCH 2/6] doc: only package man pages for daemons that are built

Signed-off-by: David Ward <david.ward [at] ll>
---
configure.ac | 11 +++++++++++
doc/Makefile.am | 34 +++++++++++++++++++++++++++++++++-
2 files changed, 44 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index 4fe70e1..8cb1d4f 100755
--- a/configure.ac
+++ b/configure.ac
@@ -624,6 +624,7 @@ dnl [TODO] on Linux, and in [TODO] on Solaris.
* ) ;;
esac
AC_SUBST(LIBREADLINE)
+AM_CONDITIONAL(VTYSH, test "x$VTYSH" = "xvtysh")

dnl ----------
dnl PAM module
@@ -1228,36 +1229,42 @@ if test "${enable_zebra}" = "no";then
else
ZEBRA="zebra"
fi
+AM_CONDITIONAL(ZEBRA, test "x$ZEBRA" = "xzebra")

if test "${enable_bgpd}" = "no";then
BGPD=""
else
BGPD="bgpd"
fi
+AM_CONDITIONAL(BGPD, test "x$BGPD" = "xbgpd")

if test "${enable_ripd}" = "no";then
RIPD=""
else
RIPD="ripd"
fi
+AM_CONDITIONAL(RIPD, test "x$RIPD" = "xripd")

if test "${enable_ospfd}" = "no";then
OSPFD=""
else
OSPFD="ospfd"
fi
+AM_CONDITIONAL(OSPFD, test "x$OSPFD" = "xospfd")

if test "${enable_babeld}" = "no";then
BABELD=""
else
BABELD="babeld"
fi
+AM_CONDITIONAL(BABELD, test "x$BABELD" = "xbabeld")

if test "${enable_watchquagga}" = "no";then
WATCHQUAGGA=""
else
WATCHQUAGGA="watchquagga"
fi
+AM_CONDITIONAL(WATCHQUAGGA, test "x$WATCHQUAGGA" = "xwatchquagga")

OSPFCLIENT=""
if test "${enable_opaque_lsa}" != "no"; then
@@ -1270,24 +1277,28 @@ if test "${enable_opaque_lsa}" != "no"; then
fi

fi
+AM_CONDITIONAL(OSPFCLIENT, test "x$OSPFCLIENT" = "xospfclient")

case "${enable_ripngd}" in
"yes") RIPNGD="ripngd";;
"no" ) RIPNGD="";;
* ) ;;
esac
+AM_CONDITIONAL(RIPNGD, test "x$RIPNGD" = "xripngd")

case "${enable_ospf6d}" in
"yes") OSPF6D="ospf6d";;
"no" ) OSPF6D="";;
* ) ;;
esac
+AM_CONDITIONAL(OSPF6D, test "x$OSPF6D" = "xospf6d")

case "${enable_isisd}" in
"yes") ISISD="isisd";;
"no" ) ISISD="";;
* ) ;;
esac
+AM_CONDITIONAL(ISISD, test "x$ISISD" = "xisisd")

# XXX Perhaps auto-enable on Solaris, but that's messy for cross builds.
case "${enable_solaris}" in
diff --git a/doc/Makefile.am b/doc/Makefile.am
index dde95ab..ac1627a 100644
--- a/doc/Makefile.am
+++ b/doc/Makefile.am
@@ -61,7 +61,39 @@ quagga_TEXINFOS = appendix.texi babeld.texi basic.texi bgpd.texi filter.texi \
.dia.png:
$(DIATOPNG) "$@" $<

-man_MANS = vtysh.1 bgpd.8 ospf6d.8 ospfd.8 ripd.8 ripngd.8 zebra.8 isisd.8
+man_MANS =
+
+if BGPD
+man_MANS += bgpd.8
+endif
+
+if ISISD
+man_MANS += isisd.8
+endif
+
+if OSPF6D
+man_MANS += ospf6d.8
+endif
+
+if OSPFD
+man_MANS += ospfd.8
+endif
+
+if RIPD
+man_MANS += ripd.8
+endif
+
+if RIPNGD
+man_MANS += ripngd.8
+endif
+
+if VTYSH
+man_MANS += vtysh.1
+endif
+
+if ZEBRA
+man_MANS += zebra.8
+endif

EXTRA_DIST = BGP-TypeCode draft-zebra-00.ms draft-zebra-00.txt $(man_MANS) \
mpls/ChangeLog.opaque.txt mpls/cli_summary.txt \
--
1.7.1

_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev


equinox at diac24

Apr 30, 2012, 8:05 AM

Post #2 of 4 (120 views)
Permalink
Re: [PATCH 2/6] doc: only package man pages for daemons that are built [In reply to]

On Sun, Apr 29, 2012 at 04:47:04PM -0400, David Ward wrote:
> +AM_CONDITIONAL(ISISD, test "x$ISISD" = "xisisd")
[...]
> +if ISISD
> +man_MANS += isisd.8
> +endif

This breaks "make dist" after "configure --disable-isisd" - the
resulting dist tarball won't contain the manpage, leading to failure
when you try to use --enable-isisd later. (applies analogous to other
daemons)

If anyone knows the proper automake incantations it'd be nice to get an
updated patch, I'll wait a bit and hope for replies before I delve into
the abyss called automake :)

-David
Attachments: signature.asc (0.22 KB)


david.ward at ll

Apr 30, 2012, 8:32 AM

Post #3 of 4 (119 views)
Permalink
Re: [PATCH 2/6] doc: only package man pages for daemons that are built [In reply to]

On 30/04/12 11:05, David Lamparter wrote:
> On Sun, Apr 29, 2012 at 04:47:04PM -0400, David Ward wrote:
>> +AM_CONDITIONAL(ISISD, test "x$ISISD" = "xisisd")
> [...]
>> +if ISISD
>> +man_MANS += isisd.8
>> +endif
> This breaks "make dist" after "configure --disable-isisd" - the
> resulting dist tarball won't contain the manpage, leading to failure
> when you try to use --enable-isisd later. (applies analogous to other
> daemons)
>
> If anyone knows the proper automake incantations it'd be nice to get an
> updated patch, I'll wait a bit and hope for replies before I delve into
> the abyss called automake :)
>
> -David

EXTRA_DIST included $(man_MANS), but it now it needs to actually spell
out all of the man pages, so "make dist" will pick them up. Revised
patches follow.

David
_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev


gdt at ir

Apr 30, 2012, 9:26 AM

Post #4 of 4 (119 views)
Permalink
Re: [PATCH 2/6] doc: only package man pages for daemons that are built [In reply to]

David Lamparter <equinox [at] diac24> writes:

> On Sun, Apr 29, 2012 at 04:47:04PM -0400, David Ward wrote:
>> +AM_CONDITIONAL(ISISD, test "x$ISISD" = "xisisd")
> [...]
>> +if ISISD
>> +man_MANS += isisd.8
>> +endif
>
> This breaks "make dist" after "configure --disable-isisd" - the
> resulting dist tarball won't contain the manpage, leading to failure
> when you try to use --enable-isisd later. (applies analogous to other
> daemons)
>
> If anyone knows the proper automake incantations it'd be nice to get an
> updated patch, I'll wait a bit and hope for replies before I delve into
> the abyss called automake :)

Maybe switching from man_MANS to the equivalent of man_MANS_NOINSTALL?

Or perhaps having make dist error out if isisd (or anything else) was
disabled?

Quagga dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.