Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Quagga: Dev

zebra: fix ifindex test condition (BZ#487)

 

 

Quagga dev RSS feed   Index | Next | Previous | View Threaded


joakim.tjernlund at transmode

Apr 7, 2012, 5:58 AM

Post #1 of 2 (130 views)
Permalink
zebra: fix ifindex test condition (BZ#487)

http://git.savannah.gnu.org/cgit/quagga.git/commit/?id=4f1735fd6ac5d0881bafa9bd421e00645b6c60fd

Was browsing Quagga repo to see the latest fixes and found the above commit.
Sadly that commit does not fix much, it only deals with ifindex for connected routes.
Either have a look at my patch I sent long ago(Don't delete too many routes) or
slap a
if (ifindex && ifindex != nexthop->ifindex)
continue; /* ifindex doesn't match */
before testing anything else


Havn't been following Q lately but other that moving the Q repo to savannah I don't
see much maintaince going on, at least not picking off the vast number of
patches in patchwork.

Jocke

_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev


infrastation at yandex

Apr 16, 2012, 3:28 AM

Post #2 of 2 (111 views)
Permalink
Re: zebra: fix ifindex test condition (BZ#487) [In reply to]

07.04.2012, 16:58, "Joakim Tjernlund" <joakim.tjernlund [at] transmode>:
> http://git.savannah.gnu.org/cgit/quagga.git/commit/?id=4f1735fd6ac5d0881bafa9bd421e00645b6c60fd
>
> Was browsing Quagga repo to see the latest fixes and found the above commit.
> Sadly that commit does not fix much, it only deals with ifindex for connected routes.
> Either have a look at my patch I sent long ago(Don't delete too many routes) or
> slap a
> if (ifindex && ifindex != nexthop->ifindex)
> ššššššššššššššššcontinue; /* ifindex doesn't match */
> before testing anything else

Hello, Jocke.

I made this commit back then judging by the feedback from #487, the case probably even reproduced locally. Of course, there is always a place for a mistake, I will review the change with your arguments considered.

--
Denis Ovsienko
_______________________________________________
Quagga-dev mailing list
Quagga-dev [at] lists
http://lists.quagga.net/mailman/listinfo/quagga-dev

Quagga dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.