Mailing List Archive: Python: Dev

Issue13210 : Support Visual Studio 2010

Index | Next | Previous | View Threaded

kristjan at ccpgames

Mar 31, 2012, 4:46 AM

Post #1 of 3 (170 views)
Permalink

Issue13210 : Support Visual Studio 2010

Hi,

Does anyone object if I submit my patches sxs.patch and errnomodule.patch?

These allow python to work correctly when built with vs2010.

There is also the PCBuild10.patch, but that can wait. I'm sure a number of people are regularly building python using vs2010 using their own modified solutions, but having the sources in a constant state of patching is a nuiscance so I think we ought to at least make the source code work with it, regardless of having a proper solution for it.

K

brian at python

Mar 31, 2012, 7:53 AM

Post #2 of 3 (165 views)
Permalink

Re: Issue13210 : Support Visual Studio 2010 [In reply to]

2012/3/31 Kristján Valur Jónsson <kristjan [at] ccpgames>:
> Hi,
>
> Does anyone object if I submit my patches sxs.patch and errnomodule.patch?
>
> These allow python to work correctly when built with vs2010.
>
>
>
> There is also the PCBuild10.patch, but that can wait. I'm sure a number of
> people are regularly building python using vs2010 using their own modified
> solutions, but having the sources in a constant state of patching is a
> nuiscance so I think we ought to at least make the source code work with it,
> regardless of having a proper solution for it.

Go ahead. As listed on the issue, there is a repo where building from
VS2010 "works" but the port is not complete as not all tests are
passing. I will complete it.
_______________________________________________
Python-Dev mailing list
Python-Dev [at] python
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/python-dev/list-python-dev%40lists.gossamer-threads.com

martin at v

Mar 31, 2012, 10:42 AM

Post #3 of 3 (164 views)
Permalink

Re: Issue13210 : Support Visual Studio 2010 [In reply to]

> Does anyone object if I submit my patches sxs.patch and errnomodule.patch?
>
> These allow python to work correctly when built with vs2010.

Please see my review: "allow to work correctly" is not a good explanation
of what it does, and why it does that. As it is highly counter-intuitive,
it needs at least justification. I'm trying to investigate whether it is
actually correct (and that it works for CCP is not sufficient proof that
it is correct).

Also, please clarify what branches you would apply this to. 3.3 is certainly
fine; for any other branches, I'd like to point out that this is not a bug
fix.

> There is also the PCBuild10.patch, but that can wait.

Indeed, it shouldn't be added at all. Instead, the PCbuild tree should
become a VS2010 (or VS2012) tree ultimately.

Regards,
Martin

_______________________________________________
Python-Dev mailing list
Python-Dev [at] python
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/python-dev/list-python-dev%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads