python-checkins at python
Nov 4, 2009, 6:20 PM
Post #1 of 1
(38 views)
Permalink
|
|
r76113 - in python/branches/py3k: Lib/importlib/test/source/util.py Misc/NEWS
|
|
Author: brett.cannon
Date: Thu Nov 5 02:17:22 2009
New Revision: 76113
Log:
importlib.test.source.util referenced variables in the 'finally' part of a
try/finally which may not have been set.
Modified:
python/branches/py3k/Lib/importlib/test/source/util.py
python/branches/py3k/Misc/NEWS
Modified: python/branches/py3k/Lib/importlib/test/source/util.py
==============================================================================
--- python/branches/py3k/Lib/importlib/test/source/util.py (original)
+++ python/branches/py3k/Lib/importlib/test/source/util.py Thu Nov 5 02:17:22 2009
@@ -55,6 +55,8 @@
source = 'attr = {0!r}'
created_paths = []
mapping = {}
+ state_manager = None
+ uncache_manager = None
try:
temp_dir = tempfile.gettempdir()
mapping['.root'] = temp_dir
@@ -85,8 +87,10 @@
state_manager.__enter__()
yield mapping
finally:
- state_manager.__exit__(None, None, None)
- uncache_manager.__exit__(None, None, None)
+ if state_manager is not None:
+ state_manager.__exit__(None, None, None)
+ if uncache_manager is not None:
+ uncache_manager.__exit__(None, None, None)
# Reverse the order for path removal to unroll directory creation.
for path in reversed(created_paths):
if file_path.endswith('.py'):
Modified: python/branches/py3k/Misc/NEWS
==============================================================================
--- python/branches/py3k/Misc/NEWS (original)
+++ python/branches/py3k/Misc/NEWS Thu Nov 5 02:17:22 2009
@@ -354,6 +354,10 @@
Tests
-----
+- Issue #7248: In importlib.test.source.util a try/finally block did not make
+ sure that some referenced objects actually were created in the block before
+ calling methods on the object.
+
- Issue #7222: Make thread "reaping" more reliable so that reference
leak-chasing test runs give sensible results. The previous method of
reaping threads could return successfully while some Thread objects were
_______________________________________________
Python-checkins mailing list
Python-checkins[at]python.org
http://mail.python.org/mailman/listinfo/python-checkins
|
