Mailing List Archive: Python: Bugs

[issue15300] test directory doubly-nested running tests with -j/--multiprocess

Index | Next | Previous | View Threaded

report at bugs

Jul 8, 2012, 6:09 PM

Post #1 of 11 (177 views)
Permalink

[issue15300] test directory doubly-nested running tests with -j/--multiprocess

New submission from Chris Jerdonek <chris.jerdonek [at] gmail>:

Running tests using the -j/--multiprocess option doubly-nests the test working directory:

$ ./python.exe -m test -j3
-->cpython/build/test_python_63955/build/test_python_63956
$ ./python.exe -m test
-->cpython/build/test_python_63957

It seems like the test directories for different processes should be siblings when running in multiprocessing mode as opposed to doubly-nesting under a new build directory.

----------
components: Tests
messages: 165052
nosy: cjerdonek
priority: normal
severity: normal
status: open
title: test directory doubly-nested running tests with -j/--multiprocess
versions: Python 3.3

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15300>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 8, 2012, 8:11 PM

Post #2 of 11 (174 views)
Permalink

[issue15300] test directory doubly-nested running tests with -j/--multiprocess [In reply to]

Chris Jerdonek <chris.jerdonek [at] gmail> added the comment:

Attaching a small refactoring patch to eliminate some cut-and-paste, prior to fixing this issue.

----------
keywords: +patch
Added file: http://bugs.python.org/file26322/issue-15300-1.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15300>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 8, 2012, 10:06 PM

Post #3 of 11 (173 views)
Permalink

[issue15300] test directory doubly-nested running tests with -j/--multiprocess [In reply to]

Chris Jerdonek <chris.jerdonek [at] gmail> added the comment:

And here is the second part. Combining this with the first patch provides a fix.

----------
Added file: http://bugs.python.org/file26323/issue-15300-2.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15300>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 8, 2012, 10:47 PM

Post #4 of 11 (176 views)
Permalink

[issue15300] test directory doubly-nested running tests with -j/--multiprocess [In reply to]

Chris Jerdonek <chris.jerdonek [at] gmail> added the comment:

Here is a single combined patch. I gather this is preferred.

----------
Added file: http://bugs.python.org/file26324/issue-15300-combined.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15300>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 9, 2012, 5:11 AM

Post #5 of 11 (173 views)
Permalink

[issue15300] test directory doubly-nested running tests with -j/--multiprocess [In reply to]

Chris Jerdonek <chris.jerdonek [at] gmail> added the comment:

After this patch, it's clear that TEMPDIR and TESTCWD no longer have to be global variables.

I can make that a separate issue after this one.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15300>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 9, 2012, 11:48 AM

Post #6 of 11 (173 views)
Permalink

[issue15300] test directory doubly-nested running tests with -j/--multiprocess [In reply to]

Changes by Antoine Pitrou <pitrou [at] free>:

----------
nosy: +flox, r.david.murray
stage: -> patch review

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15300>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 10, 2012, 5:11 AM

Post #7 of 11 (172 views)
Permalink

[issue15300] test directory doubly-nested running tests with -j/--multiprocess [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

I don't really like the "pre-parsed option" hack. Can't we think of something simpler? For example, why would the child be involved, rather than simply the parent setting the right cwd?

Also, I don't think there's any point in _OPTION_CWD_PARENT_DIR. Just hard-code the literal, it will be more readable.

----------
nosy: +pitrou

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15300>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 10, 2012, 8:02 PM

Post #8 of 11 (167 views)
Permalink

[issue15300] test directory doubly-nested running tests with -j/--multiprocess [In reply to]

Chris Jerdonek <chris.jerdonek [at] gmail> added the comment:

Thanks for your feedback, Antoine, and for causing me to rethink the patch. This patch is drastically simpler.

Incidentally, I found a reason for this issue in issue 15322.

regrtest calculates the "build" folder relative to sysconfig.get_config_var('srcdir'). Because the latter returns the current working directory instead of the source directory, the build folders were getting nested.

----------
Added file: http://bugs.python.org/file26347/issue-15300-3.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15300>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 11, 2012, 9:07 AM

Post #9 of 11 (169 views)
Permalink

[issue15300] test directory doubly-nested running tests with -j/--multiprocess [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

Thanks, Chris. I haven't tested the patch but it looks fine.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15300>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 11, 2012, 10:23 AM

Post #10 of 11 (167 views)
Permalink

[issue15300] test directory doubly-nested running tests with -j/--multiprocess [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset 724a6e0e35f0 by Antoine Pitrou in branch '3.2':
Issue #15300: Ensure the temporary test working directories are in the same parent folder when running tests in multiprocess mode from a Python build.
http://hg.python.org/cpython/rev/724a6e0e35f0

New changeset 4752fafb579d by Antoine Pitrou in branch 'default':
Issue #15300: Ensure the temporary test working directories are in the same parent folder when running tests in multiprocess mode from a Python build.
http://hg.python.org/cpython/rev/4752fafb579d

----------
nosy: +python-dev

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15300>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 11, 2012, 10:26 AM

Post #11 of 11 (168 views)
Permalink

[issue15300] test directory doubly-nested running tests with -j/--multiprocess [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

Committed now.

----------
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: +Python 3.2

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15300>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads