Mailing List Archive: Python: Bugs

[issue15166] Implement imp.get_tag() using sys.implementation

Index | Next | Previous | View Threaded

report at bugs

Jun 24, 2012, 12:50 PM

Post #1 of 10 (57 views)
Permalink

[issue15166] Implement imp.get_tag() using sys.implementation

New submission from Brett Cannon <brett [at] python>:

Title says it all. This also implies updating importlib to use sys.implementation directly.

----------
components: Library (Lib)
keywords: easy
messages: 163829
nosy: brett.cannon, eric.snow
priority: deferred blocker
severity: normal
stage: needs patch
status: open
title: Implement imp.get_tag() using sys.implementation
versions: Python 3.3

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15166>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 26, 2012, 1:19 PM

Post #2 of 10 (59 views)
Permalink

[issue15166] Implement imp.get_tag() using sys.implementation [In reply to]

Jeff Knupp <jknupp [at] gmail> added the comment:

Adding patch. If I misunderstood the issue, let me know.

----------
keywords: +patch
nosy: +Jeff.Knupp
Added file: http://bugs.python.org/file26170/imp.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15166>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 26, 2012, 1:52 PM

Post #3 of 10 (61 views)
Permalink

[issue15166] Implement imp.get_tag() using sys.implementation [In reply to]

Georg Brandl <georg [at] python> added the comment:

Moving to blocker for beta2.

----------
nosy: +georg.brandl
priority: deferred blocker -> release blocker

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15166>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 2, 2012, 12:13 PM

Post #4 of 10 (47 views)
Permalink

[issue15166] Implement imp.get_tag() using sys.implementation [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset b36bed82c9d0 by Brett Cannon in branch 'default':
Issue #15166: Re-implement imp.get_tag() using sys.implementation.
http://hg.python.org/cpython/rev/b36bed82c9d0

----------
nosy: +python-dev

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15166>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 2, 2012, 12:15 PM

Post #5 of 10 (47 views)
Permalink

[issue15166] Implement imp.get_tag() using sys.implementation [In reply to]

Brett Cannon <brett [at] python> added the comment:

I ended up applying Eric's patch from #14797 and then comparing against Jeff's patch here since Eric's cleaned up the C code. Thanks to both for the work!

----------
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15166>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 2, 2012, 12:16 PM

Post #6 of 10 (47 views)
Permalink

[issue15166] Implement imp.get_tag() using sys.implementation [In reply to]

Brett Cannon <brett [at] python> added the comment:

I meant issue #13959 for Eric's patch; wrong tab. =)

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15166>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 2, 2012, 2:06 PM

Post #7 of 10 (47 views)
Permalink

[issue15166] Implement imp.get_tag() using sys.implementation [In reply to]

Éric Araujo <merwok [at] netwok> added the comment:

One small thing: this comment from import.c was not copied to sysmodule.c and is now deleted:

- TAG must change for each major Python release. The magic number will take
- care of any bytecode changes that occur during development.

----------
nosy: +eric.araujo

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15166>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 2, 2012, 3:07 PM

Post #8 of 10 (47 views)
Permalink

[issue15166] Implement imp.get_tag() using sys.implementation [In reply to]

Eric Snow <ericsnowcurrently [at] gmail> added the comment:

Good catch. However, do we need that comment? The tag is programmatically derived from the version (in Python/sysmodule.c).

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15166>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 2, 2012, 3:39 PM

Post #9 of 10 (46 views)
Permalink

[issue15166] Implement imp.get_tag() using sys.implementation [In reply to]

Éric Araujo <merwok [at] netwok> added the comment:

Ah, good, if it’s automatically derived then we don’t need the comment.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15166>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 2, 2012, 11:54 PM

Post #10 of 10 (47 views)
Permalink

[issue15166] Implement imp.get_tag() using sys.implementation [In reply to]

Eric Snow <ericsnowcurrently [at] gmail> added the comment:

There was some concern with PyImport_GetMagicTag() extracting its value from sys.implementation.cache_tag. I've addressed this in issue15242.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15166>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads