Mailing List Archive: Python: Bugs

[issue15102] Fix 64-bit building for buildbot scripts

Index | Next | Previous | View Threaded

report at bugs

Jun 18, 2012, 7:48 AM

Post #1 of 22 (120 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts

New submission from Jeremy Kloth <jeremy.kloth+python-tracker [at] gmail>:

The buildbot scripts do not work for the 64-bit targets.

Firstly, the "/p:UseEnv=True" parameter to msbuild causes the 32-bit only projects (make_buildinfo and make_versioninfo) to fail due to architecture mismatch. The scripts now unconditionally build those projects using the 32-bit command-line tools.

The make_versioninfo project wasn't completely converted to be 32-bit only (issue9981); it would work correctly only from the IDE. This fixes that and removes the Debug configuration as that was already #ifdef'd in the generated .h file.

----------
components: Build, Cross-Build, Windows
hgrepos: 136
messages: 163102
nosy: jkloth
priority: normal
severity: normal
status: open
title: Fix 64-bit building for buildbot scripts
type: compile error
versions: Python 3.3

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 18, 2012, 12:45 PM

Post #2 of 22 (117 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Changes by Antoine Pitrou <pitrou [at] free>:

----------
keywords: +patch
Added file: http://bugs.python.org/file26047/2a20cee18add.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 18, 2012, 1:42 PM

Post #3 of 22 (117 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Stefan Krah <stefan-usenet [at] bytereef> added the comment:

There's some unrelated stuff in the patch that reverts commits in
mpdecimal.c and multiprocessing. Maybe a Rietveld issue.

----------
nosy: +skrah

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 18, 2012, 2:20 PM

Post #4 of 22 (117 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Jeremy Kloth <jeremy.kloth [at] gmail> added the comment:

The unrelated changes do seem to be an issue with the diff generated by Rietveld

----------
nosy: +jeremy.kloth

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 18, 2012, 2:27 PM

Post #5 of 22 (117 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

If I understand, the proposed changes are the following:
https://bitbucket.org/jkloth/cpython-buildbot-amd64/changeset/2a20cee18add
?

I'm not a Windows specialist, but they do seem a bit weird:
- the pcbuild.sln changes remove "Debug|x64.Build" and replaces "Debug" with "Release"
- build-common.bat doesn't allow to distinguish between x86 and x64
- build.bat does not call build-common.bat

----------
nosy: +pitrou

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 18, 2012, 3:26 PM

Post #6 of 22 (117 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Jeremy Kloth <jeremy.kloth [at] gmail> added the comment:

On Mon, Jun 18, 2012 at 3:27 PM, Antoine Pitrou <report [at] bugs> wrote:
> If I understand, the proposed changes are the following:
> https://bitbucket.org/jkloth/cpython-buildbot-amd64/changeset/2a20cee18add

That seems to be correct, yes.

> I'm not a Windows specialist, but they do seem a bit weird:
> - the pcbuild.sln changes remove "Debug|x64.Build" and replaces "Debug" with "Release"

That change is related to the make_versioninfo project which doesn't
use the Debug build (like make_buildinfo)

> - build-common.bat doesn't allow to distinguish between x86 and x64

Correct as make_buildinfo and make_versioninfo are only ever built as
32-bit (see issue9981)

> - build.bat does not call build-common.bat

Oops, an oversight on my part. It didn't show up in testing as the
solution already is built in 32-bit mode. The call should in the same
location as in build-amd64.bat

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 19, 2012, 10:01 AM

Post #7 of 22 (116 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Changes by Zachary Ware <zachary.ware [at] gmail>:

----------
nosy: +zach.ware

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 20, 2012, 7:56 AM

Post #8 of 22 (116 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Jeremy Kloth <jeremy.kloth+python-tracker [at] gmail> added the comment:

Now that my buildbot is up and building (and failing at that) could these changes be committed? It would get the buildbot to at least start testing changes to Python proper.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 20, 2012, 7:58 AM

Post #9 of 22 (116 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Changes by Stefan Krah <stefan-usenet [at] bytereef>:

----------
nosy: +brian.curtin, loewis

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 22, 2012, 1:03 PM

Post #10 of 22 (113 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

> Now that my buildbot is up and building (and failing at that) could
> these changes be committed?

Well, it would be nice if you could post an updated patch after the comments above. (I'm not saying I'm gonna commit, since I'm not a Windows expert, but it will certainly help other core developers review it)

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 22, 2012, 2:25 PM

Post #11 of 22 (113 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Changes by Jeremy Kloth <jeremy.kloth+python-tracker [at] gmail>:

Added file: http://bugs.python.org/file26095/5924b376d15f.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 23, 2012, 5:32 AM

Post #12 of 22 (111 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Changes by Antoine Pitrou <pitrou [at] free>:

----------
nosy: +georg.brandl

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 23, 2012, 8:01 AM

Post #13 of 22 (111 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Georg Brandl <georg [at] python> added the comment:

I'd like Martin to have a look at this.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 23, 2012, 8:09 AM

Post #14 of 22 (112 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Martin v. Löwis <martin [at] v> added the comment:

I think this really needs to be broken further down than "the AMD64 buildbot doesn't work". For each presumed failure, there should be one issue, and perhaps a proposed patch.

The patch, as it stands, is clearly incorrect (as has been reviewed and acknowledged).

So unless Jeremy can provide an updated patch quickly, I rather suggest to close this issue, and ask for new issues to be created for the individual problems.

As for the changes to project files and the solution file: none of these changes should be necessary at all, unless it's actually the case that the AMD64-Debug build doesn't work (i.e. neither in the buildbot, nor from the solution file).

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 23, 2012, 8:27 AM

Post #15 of 22 (97 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Jeremy Kloth <jeremy.kloth [at] gmail> added the comment:

> The patch, as it stands, is clearly incorrect (as has been reviewed and acknowledged).

The most recent patch is correct.

> As for the changes to project files and the solution file: none of these changes should be necessary at all, unless it's actually the case that the AMD64-Debug build doesn't work (i.e. neither in the buildbot, nor from the solution file).

The debug build doesn't even *build*! That's the issue.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 23, 2012, 8:32 AM

Post #16 of 22 (97 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Jeremy Kloth <jeremy.kloth [at] gmail> added the comment:

> As for the changes to project files and the solution file: none of these changes should be necessary at all, unless it's actually the case that the AMD64-Debug build doesn't work (i.e. neither in the buildbot, nor from the solution file).

As to the debug build not working, has anyone even looked at the
64-bit Windows buildbot? As the following link demonstrates, building
is clearly failing:

http://www.python.org/dev/buildbot/all/builders/AMD64%20Windows7%20SP1%203.x/builds/74/steps/compile/logs/stdio

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 23, 2012, 8:56 AM

Post #17 of 22 (98 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Martin v. Löwis <martin [at] v> added the comment:

> The most recent patch is correct.

See my review then; I think it has issues.

> The debug build doesn't even *build*! That's the issue.

It builds fine for me - I just tried.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 23, 2012, 9:05 AM

Post #18 of 22 (99 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Stefan Krah <stefan-usenet [at] bytereef> added the comment:

Martin v. L??wis <report [at] bugs> wrote:
> > The debug build doesn't even *build*! That's the issue.
>
> It builds fine for me - I just tried.

What command line do you use? I tried:

C:\Users\stefan\pydev\cpython>.\Tools\buildbot\build-amd64.bat

Error: project file 'pcbuild.sln' was not found or not a valid project file.
Microsoft (R) Visual C++ Project Builder - Command Line Version 9.00.21022
Copyright (C) Microsoft Corporation. All rights reserved.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 23, 2012, 9:10 AM

Post #19 of 22 (97 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Martin v. Löwis <martin [at] v> added the comment:

>> > The debug build doesn't even *build*! That's the issue.
>>
>> It builds fine for me - I just tried.
>
> What command line do you use?

Not the command line - I built from the IDE. My claim is if that works,
no changes to the solution and project files should be necessary.

> C:\Users\stefan\pydev\cpython>.\Tools\buildbot\build-amd64.bat
>
> Error: project file 'pcbuild.sln' was not found or not a valid project file.

I can believe that there are issues with the batch files. That's why I propose
to look at one issue at a time (but it's not my priority at the moment).

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 23, 2012, 9:15 AM

Post #20 of 22 (97 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Jeremy Kloth <jeremy.kloth [at] gmail> added the comment:

> I can believe that there are issues with the batch files. That's why I propose
> to look at one issue at a time (but it's not my priority at the moment).

That would mean that you do not care that the buildbots are failing.
That is exactly the reason that this bug report has been opened.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 23, 2012, 9:28 AM

Post #21 of 22 (97 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Georg Brandl <georg [at] python> added the comment:

Of course these failures have to be fixed. But what Martin is saying is that for him (and probably other devs working on Windows) the build works, so the change must be done in the scripts only running on the buildbots.

As for priority, we're two days away from 3.3b1 and feature freeze, so you can imagine that there are quite a lot of things on Martin's table.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 23, 2012, 9:31 AM

Post #22 of 22 (97 views)
Permalink

[issue15102] Fix 64-bit building for buildbot scripts [In reply to]

Stefan Krah <stefan-usenet [at] bytereef> added the comment:

I seem to be getting a functioning amd64 debug build by applying
the small useenv.diff and then running:

Tools\buildbot\build-amd64.bat

----------
Added file: http://bugs.python.org/file26108/useenv.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15102>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads