Mailing List Archive: Python: Bugs

[issue14780] urllib.request could use the default CA store

Index | Next | Previous | View Threaded

report at bugs

May 16, 2012, 3:14 AM

Post #1 of 7 (83 views)
Permalink

[issue14780] urllib.request could use the default CA store

Antoine Pitrou <pitrou [at] free> added the comment:

> Something like this perhaps?

For example, yes. Now we need to find a way of testing this...

----------
nosy: +orsenthil
title: SSL should use OpenSSL-defined default certificate store if ca_certs parameter is omitted -> urllib.request could use the default CA store

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14780>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 16, 2012, 12:20 PM

Post #2 of 7 (77 views)
Permalink

[issue14780] urllib.request could use the default CA store [In reply to]

James Oakley <jfunk [at] funktronics> added the comment:

Ok, here's a patch with a test and documentation updates.

----------
Added file: http://bugs.python.org/file25617/cpython-urllib_urlopen_cadefault.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14780>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 16, 2012, 12:24 PM

Post #3 of 7 (77 views)
Permalink

[issue14780] urllib.request could use the default CA store [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

> Ok, here's a patch with a test and documentation updates.

Ok, thanks! The only change I would make is that cadefault needs to be
False by default; particularly because some platforms don't have a
OpenSSL-compatible default CA store (Windows comes to mind) and all
HTTPS requests would then start failing.

You don't have to upload a new patch; I can change it when committing.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14780>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 16, 2012, 12:26 PM

Post #4 of 7 (77 views)
Permalink

[issue14780] urllib.request could use the default CA store [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

Oh, by the way, could you sign and send a contributor agreement? See http://www.python.org/psf/contrib/
(it is not a copyright assignment, just a formal licensing agreement)

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14780>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 16, 2012, 12:44 PM

Post #5 of 7 (77 views)
Permalink

[issue14780] urllib.request could use the default CA store [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset f2ed5de1c568 by Antoine Pitrou in branch 'default':
Issue #14780: urllib.request.urlopen() now has a `cadefault` argument to use the default certificate store.
http://hg.python.org/cpython/rev/f2ed5de1c568

----------
nosy: +python-dev

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14780>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 16, 2012, 12:47 PM

Post #6 of 7 (79 views)
Permalink

[issue14780] urllib.request could use the default CA store [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

Patch committed. I propose to close the issue, unless further enhancements are suggested.

----------
resolution: -> fixed
stage: -> committed/rejected

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14780>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 16, 2012, 1:16 PM

Post #7 of 7 (77 views)
Permalink

[issue14780] urllib.request could use the default CA store [In reply to]

James Oakley <jfunk [at] funktronics> added the comment:

Ok, perfect. I submitted a copy of the agreement.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14780>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads