Mailing List Archive: Python: Bugs

[issue14814] Implement PEP 3144 (the ipaddress module)

1 2 3 4 5 6

View All

Index | Next | Previous | View Threaded

report at bugs

May 15, 2012, 5:00 AM

Post #1 of 127 (735 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module)

New submission from Nick Coghlan <ncoghlan [at] gmail>:

This issue tracks the incorporation of the ipaddress module into Python 3.3.

Tasks to be completed:
- add Lib/ipaddress.py from [1]
- add Lib/test_ipaddress.py from [1]
- create module reference docs from docstrings in [1]
- add Doc/library/ipaddress.py and link from index
- create howto guide from wiki page [2]
- add Doc/howto/ipaddress.rst and link from index

[1] https://code.google.com/p/ipaddress-py/source/browse/

[2] https://code.google.com/p/ipaddr-py/wiki/Using3144

----------
components: Library (Lib)
messages: 160719
nosy: ncoghlan
priority: release blocker
severity: normal
stage: needs patch
status: open
title: Implement PEP 3144 (the ipaddress module)
type: enhancement
versions: Python 3.3

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 15, 2012, 7:29 AM

Post #2 of 127 (720 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Changes by Tshepang Lekhonkhobe <tshepang [at] gmail>:

----------
nosy: +tshepang

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 15, 2012, 9:01 AM

Post #3 of 127 (719 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Changes by Giampaolo Rodola' <g.rodola [at] gmail>:

----------
nosy: +giampaolo.rodola

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 15, 2012, 1:57 PM

Post #4 of 127 (717 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Changes by Alan Kennedy <python-dev [at] xhaus>:

----------
nosy: +amak

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 18, 2012, 11:27 AM

Post #5 of 127 (714 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Changes by Terry J. Reedy <tjreedy [at] udel>:

----------
nosy: +terry.reedy

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 20, 2012, 2:40 AM

Post #6 of 127 (713 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Changes by Nick Coghlan <ncoghlan [at] gmail>:

----------
nosy: +pmoody

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 20, 2012, 4:02 AM

Post #7 of 127 (716 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset 82a649047272 by Nick Coghlan in branch 'default':
Issue #14814: addition of the ipaddress module (stage 1 - code and tests)
http://hg.python.org/cpython/rev/82a649047272

----------
nosy: +python-dev

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 20, 2012, 4:06 AM

Post #8 of 127 (716 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Nick Coghlan <ncoghlan [at] gmail> added the comment:

Stage 1 complete - the code and tests are in (along with the other miscellaneous updates to ACKS, NEWS and What's New).

Next steps are to convert the wiki page into a HOWTO and the docstrings into a module API reference. Georg offered to help with the first pass at the latter.

The module and its test suite were the main thing I really wanted in place for the alpha 4 deadline - with the frequent updates to the online docs, we have a bit more leeway with the timing.

----------
nosy: +georg.brandl

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 20, 2012, 7:42 AM

Post #9 of 127 (718 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Ramchandra Apte <maniandram01 [at] gmail> added the comment:

Looking at the code at http://code.google.com/p/ipaddress-py/source/browse/ipaddress.py I see a few classes which could benefit from functools.total_ordering.

----------
nosy: +ramchandra.apte

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 20, 2012, 1:02 PM

Post #10 of 127 (719 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Éric Araujo <merwok [at] netwok> added the comment:

Great to get this in the standard library!

I noticed the ipaddress module contains an unnecessary shebang. I also was under the impression that “Licensed to the PSF under a contributor agreement” was sufficient and the whole license text could be removed.

----------
nosy: +eric.araujo

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 20, 2012, 3:40 PM

Post #11 of 127 (716 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Sandro Tosi <sandro.tosi [at] gmail> added the comment:

I'm attaching a very preliminary draft of the howto, any comment is welcome. Of course, it misses several references to the API doc; I'll see if I can beat Georg and post a preliminary version of that too :)

----------
keywords: +patch
nosy: +sandro.tosi
Added file: http://bugs.python.org/file25654/issue14814-ipaddress-howto.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 20, 2012, 8:32 PM

Post #12 of 127 (715 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Nick Coghlan <ncoghlan [at] gmail> added the comment:

Review comments from Terry Reedy:
http://mail.python.org/pipermail/python-dev/2012-May/119548.html

The PEP review focused mainly on the API, Terry's comments focus on code readability and the docstrings.

----------
assignee: -> ncoghlan

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 22, 2012, 12:55 PM

Post #13 of 127 (714 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Sandro Tosi <sandro.tosi [at] gmail> added the comment:

Thank Nick for pointing to Terry's review! I'm attaching here a patch addressing the points Terry highlighed. probably we should review this patch before moving forward with the API doc?

----------
Added file: http://bugs.python.org/file25675/ipaddress_improvements.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 22, 2012, 1:54 PM

Post #14 of 127 (713 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Terry J. Reedy <tjreedy [at] udel> added the comment:

[Agreed that spacing comments were bogus.]

As for the rest, patch looks good except for 'is is' in
+ ValueError: If the integer is is negative or...

I am glad I could help improve things a bit.
I will try to look at the how-to by tomorrow to see if I understand it.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 22, 2012, 2:02 PM

Post #15 of 127 (717 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Tshepang Lekhonkhobe <tshepang [at] gmail> added the comment:

looks easy enough for me; I've marked a bunch of minor issues with the code review tool

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 22, 2012, 5:03 PM

Post #16 of 127 (717 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Changes by Ezio Melotti <ezio.melotti [at] gmail>:

----------
nosy: +ezio.melotti

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 23, 2012, 1:27 PM

Post #17 of 127 (696 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset 0be296605165 by Sandro Tosi in branch 'default':
Issue #14814: improve docstrings and arguments value handling, as per Terry J. Reedy's comments
http://hg.python.org/cpython/rev/0be296605165

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 23, 2012, 1:43 PM

Post #18 of 127 (696 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Hynek Schlawack <hs [at] ox> added the comment:

A small bikeshed as it’s a new module:

- there’s only one free line before _collapse_addresses_recursive, _get_prefix_length and _count_righthand_zero_bits.
- class IPv6Address docstring has a \n too much
- ip_interface, v4_int_to_packed, v6_int_to_packed are missing an empty line at the end of the docstring
- the doctstring of _BaseNetwork.hosts is indented
- does it make sense to have a shebang in a library?

Just wanted to make it even more shiny. :)

----------
nosy: +hynek

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 23, 2012, 2:17 PM

Post #19 of 127 (695 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset f4f2139202c5 by Sandro Tosi in branch 'default':
Issue #14814: minor improvements as suggested by Hynek Schlawack
http://hg.python.org/cpython/rev/f4f2139202c5

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 23, 2012, 2:20 PM

Post #20 of 127 (701 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Sandro Tosi <sandro.tosi [at] gmail> added the comment:

Thanks Hynek: comments committed

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 24, 2012, 3:13 AM

Post #21 of 127 (696 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Hynek Schlawack <hs [at] ox> added the comment:

Here is a patch with some more pep8-wankery + some dead code removal. Feel free to add only what you like, no hard feelings. :)

----------
Added file: http://bugs.python.org/file25694/ipaddress-pep8-and-dead-code.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 25, 2012, 1:59 AM

Post #22 of 127 (700 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Hynek Schlawack <hs [at] ox> added the comment:

Cool, you actually did reviews. :)

I’ve updated the patch, anything else?

(to my excuse, I originally didn’t want to tamper with code, but now the patch is actually useful and not just pretty ;))

----------
Added file: http://bugs.python.org/file25702/ipaddress-pep8-and-dead-code-v2.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 26, 2012, 3:13 AM

Post #23 of 127 (704 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset 63d2c9affb11 by Hynek Schlawack in branch 'default':
#14814: Some PEP8 adjustments and dead code weeding
http://hg.python.org/cpython/rev/63d2c9affb11

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 26, 2012, 3:16 AM

Post #24 of 127 (702 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Hynek Schlawack <hs [at] ox> added the comment:

One last wish: could we curb the copyright header a bit? I don't know the exact policy on that but as other modules don't have that I presume we could do without/with a shorter one. If we have one, I'd rather add something like "based on the original ipaddress module by Peter Moody".

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 26, 2012, 4:34 AM

Post #25 of 127 (696 views)
Permalink

[issue14814] Implement PEP 3144 (the ipaddress module) [In reply to]

Nick Coghlan <ncoghlan [at] gmail> added the comment:

Yeah, only the first two lines of the copyright header are really needed.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

1 2 3 4 5 6

View All

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads