Mailing List Archive: Python: Bugs

[issue14366] Supporting lzma compression in zip files

Index | Next | Previous | View Threaded

report at bugs

Apr 30, 2012, 11:47 PM

Post #1 of 14 (89 views)
Permalink

[issue14366] Supporting lzma compression in zip files

Changes by Martin v. Löwis <martin [at] v>:

----------
title: Supporting bzip2 and lzma compression in zip files -> Supporting lzma compression in zip files

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14366>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 1, 2012, 1:33 AM

Post #2 of 14 (79 views)
Permalink

[issue14366] Supporting lzma compression in zip files [In reply to]

Serhiy Storchaka <storchaka [at] gmail> added the comment:

Here is the patch which adds support for lzma in zipfile. Later I'll
move `lzma_props_encode` and `lzma_props_decode` to lzma module.

----------
Added file: http://bugs.python.org/file25430/lzma_in_zip.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14366>
_______________________________________

Attachments:

lzma_in_zip.patch (17.7 KB)

report at bugs

May 1, 2012, 1:37 AM

Post #3 of 14 (78 views)
Permalink

[issue14366] Supporting lzma compression in zip files [In reply to]

Serhiy Storchaka <storchaka [at] gmail> added the comment:

Note that the supporting of bzip2 increases the time of testing
test_zipfile in 1.5x, and lzma -- 2x (total 3x). May be not all tests
are needed?

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14366>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 2, 2012, 9:04 AM

Post #4 of 14 (75 views)
Permalink

[issue14366] Supporting lzma compression in zip files [In reply to]

Martin v. Löwis <martin [at] v> added the comment:

I'm not sure where the test run time actually comes from. It's certainly desirable to reduce the test run time, as long as all test purposes are preserved. It's not necessary to do redundant tests, e.g. if some test isn't about compression, there is no point in running it with all compressors (again, I'm not sure whether this actually happens).

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14366>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 2, 2012, 9:56 AM

Post #5 of 14 (75 views)
Permalink

[issue14366] Supporting lzma compression in zip files [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

> Note that the supporting of bzip2 increases the time of testing
> test_zipfile in 1.5x, and lzma -- 2x (total 3x). May be not all tests
> are needed?

I think it's ok. Some of our tests run quite longer than that; and better to be exhaustive than fast (even though exhaustive *and* fast is better, of course).

----------
nosy: +pitrou

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14366>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 5, 2012, 6:11 PM

Post #6 of 14 (75 views)
Permalink

[issue14366] Supporting lzma compression in zip files [In reply to]

Nadeem Vawda <nadeem.vawda [at] gmail> added the comment:

I've put together a patch for the lzma module adding functions for
encoding and decoding filter properties (see issue 14736). It's a bit
bulky, though, so I'd like to get a review before committing it.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14366>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 6, 2012, 2:13 PM

Post #7 of 14 (73 views)
Permalink

[issue14366] Supporting lzma compression in zip files [In reply to]

Nadeem Vawda <nadeem.vawda [at] gmail> added the comment:

I've committed my patch as changeset 9118ef2b651a, adding functions
encode_filter_properties and decode_filter_properties to the lzma module.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14366>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 7, 2012, 12:34 PM

Post #8 of 14 (69 views)
Permalink

[issue14366] Supporting lzma compression in zip files [In reply to]

Serhiy Storchaka <storchaka [at] gmail> added the comment:

The patch updated to use functions encode_filter_properties and decode_filter_properties from the lzma module. Thank you, Nadeem Vawda.

----------
Added file: http://bugs.python.org/file25488/lzma_in_zip_2.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14366>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 7, 2012, 12:38 PM

Post #9 of 14 (68 views)
Permalink

[issue14366] Supporting lzma compression in zip files [In reply to]

Changes by Serhiy Storchaka <storchaka [at] gmail>:

Removed file: http://bugs.python.org/file25430/lzma_in_zip.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14366>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 10, 2012, 5:52 AM

Post #10 of 14 (68 views)
Permalink

[issue14366] Supporting lzma compression in zip files [In reply to]

Martin v. Löwis <martin [at] v> added the comment:

Serhiy, just to be sure we communicated well: I'm not asking that all the missing features for a 6.3 level zip library must be implemented. Instead, we need to detect whether an unsupported feature is used, and raise an exception reporting what the feature is that is unsupported. This is necessary as we otherwise may return incorrect data.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14366>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 10, 2012, 1:47 PM

Post #11 of 14 (67 views)
Permalink

[issue14366] Supporting lzma compression in zip files [In reply to]

Serhiy Storchaka <storchaka [at] gmail> added the comment:

I understand you, Martin. The time it took me to read the specification
and understand where should be the checks in the module. The patch
updated. The list of compression methods extended (in the future it can
be used for detailed output in the printdir()), flag of strict
encryption is checked directly, encrypted or compressed central
directory just will not be found (BadZipFile will be raised).

----------
Added file: http://bugs.python.org/file25528/lzma_in_zip_3.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14366>
_______________________________________

Attachments:

lzma_in_zip_3.patch (18.3 KB)

report at bugs

May 13, 2012, 1:06 AM

Post #12 of 14 (54 views)
Permalink

[issue14366] Supporting lzma compression in zip files [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset fccdcd83708a by Martin v. Löwis in branch 'default':
Issue #14366: Support lzma compression in zip files.
http://hg.python.org/cpython/rev/fccdcd83708a

----------
nosy: +python-dev

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14366>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 13, 2012, 1:07 AM

Post #13 of 14 (55 views)
Permalink

[issue14366] Supporting lzma compression in zip files [In reply to]

Martin v. Löwis <martin [at] v> added the comment:

Thanks for the patch!

----------
resolution: -> fixed
status: open -> closed

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14366>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 13, 2012, 3:12 AM

Post #14 of 14 (54 views)
Permalink

[issue14366] Supporting lzma compression in zip files [In reply to]

Serhiy Storchaka <storchaka [at] gmail> added the comment:

Thank you, Martin. Both of these patches basically your merit.

Maybe take a look also at the small patches to issue14315 and
issue10376?

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14366>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads