Mailing List Archive: Python: Bugs

[issue14642] Fix importlib.h build rule to not depend on hg

Index | Next | Previous | View Threaded

report at bugs

Apr 22, 2012, 2:54 AM

Post #1 of 19 (110 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg

Changes by Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA [at] GMail>:

----------
title: Fix imoprtlib.h build rule to not depend on hg -> Fix importlib.h build rule to not depend on hg

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 22, 2012, 4:20 AM

Post #2 of 19 (112 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Changes by Eric V. Smith <eric [at] trueblade>:

----------
nosy: +eric.smith

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 22, 2012, 7:29 AM

Post #3 of 19 (106 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Changes by Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA [at] GMail>:

----------
nosy: +Arfrever

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 22, 2012, 8:01 AM

Post #4 of 19 (106 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Brett Cannon <brett [at] python> added the comment:

The thing should also do a sanity check on the syntax so as to minimize the chances of freezing code that has no chance of working.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 22, 2012, 9:43 AM

Post #5 of 19 (107 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Martin v. Löwis <martin [at] v> added the comment:

What do you mean by "sanity check on the syntax"? The current Makefile rule to build importlib.h already checks the syntax of _bootstrap.py, and fails if there is a syntax error.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 22, 2012, 10:02 AM

Post #6 of 19 (108 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Brett Cannon <brett [at] python> added the comment:

On Sun, Apr 22, 2012 at 12:43, Martin v. Löwis <report [at] bugs>wrote:

>
> Martin v. Löwis <martin [at] v> added the comment:
>
> What do you mean by "sanity check on the syntax"? The current Makefile
> rule to build importlib.h already checks the syntax of _bootstrap.py, and
> fails if there is a syntax error

That's true, so ignore my comment. =)

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 22, 2012, 10:10 AM

Post #7 of 19 (109 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Martin v. Löwis <martin [at] v> added the comment:

Also, what's the issue with a shell script? The current Makefile will rebuild importlib.h if its time stamp is older than the one of _bootstrap.py. That will fail if ./python was not build.

So what is the problem to solve?

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 22, 2012, 10:49 AM

Post #8 of 19 (106 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Brett Cannon <brett [at] python> added the comment:

I don't quite follow. I have no issue with a shell script verifying things by doing an `hg status` to verify certain truths (or something). I said a shell *or* Python script to begin with.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 22, 2012, 3:25 PM

Post #9 of 19 (106 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Martin v. Löwis <martin [at] v> added the comment:

My point is: ISTM that everything is already as it should be, I can see no problem in the status quo. If there is a problem, can you please rephrase it? If you want a shell script just to have one, here is one

#!/bin/sh
make Python/importlib.h

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 22, 2012, 3:46 PM

Post #10 of 19 (106 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Brett Cannon <brett [at] python> added the comment:

No, I don't want a shell script just to have one. =)

The status quo seems to work, but people like Georg think it's partially luck that it does and if hg changes its semantics that will cause us trouble.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 25, 2012, 1:54 AM

Post #11 of 19 (99 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset acfdf46b8de1 by Marc-Andre Lemburg in branch 'default':
Issue #14605 and #14642:
http://hg.python.org/cpython/rev/acfdf46b8de1

----------
nosy: +python-dev

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 25, 2012, 8:03 AM

Post #12 of 19 (99 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Brett Cannon <brett [at] python> added the comment:

This is where a script could help with printing out a warning if the built Python interpreter is not available.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 25, 2012, 8:56 AM

Post #13 of 19 (97 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Éric Araujo <merwok [at] netwok> added the comment:

> The status quo seems to work, but people like Georg think it's partially luck that
> it does and if hg changes its semantics that will cause us trouble.

Could you expand on that?

----------
nosy: +eric.araujo

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 25, 2012, 9:30 AM

Post #14 of 19 (98 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Brett Cannon <brett [at] python> added the comment:

When you do a fresh checkout, Python/importlib.h comes after Lib/importlib/_bootstrap.py and Python/freeze_importlib.py in a lexicographical sort which leads to it have a newer timestamp and thus not triggering a new build of the file.

This is why Martin suggested at some point using hg status or something from a script to properly detect if something has changed that would warrant rebuilding.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 25, 2012, 10:45 AM

Post #15 of 19 (99 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset 5fea362b92fc by Marc-Andre Lemburg in branch 'default':
Issue #14605 and #14642: Issue a warning in case Python\importlib.h needs to
http://hg.python.org/cpython/rev/5fea362b92fc

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 25, 2012, 11:39 AM

Post #16 of 19 (99 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Martin v. Löwis <martin [at] v> added the comment:

I'm working on a "hg touch" extension which is able to bring the time stamps back in correct order after a checkout. One would either do "make touch" after an update, or register that extension as a post-update action in .hg/hgrc. It will be controlled by a versioned .hgtouch file, that uses make(1) dependency syntax.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 27, 2012, 7:10 AM

Post #17 of 19 (99 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset b3d3f3238c13 by Martin v. Loewis in branch 'default':
Issue #14642: Add "hg touch" extension, and "make touch" target.
http://hg.python.org/cpython/rev/b3d3f3238c13

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 27, 2012, 1:50 PM

Post #18 of 19 (100 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Brett Cannon <brett [at] python> added the comment:

Can this issue be closed, Martin, thanks to your extension?

----------
assignee: -> loewis

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 28, 2012, 2:57 AM

Post #19 of 19 (97 views)
Permalink

[issue14642] Fix importlib.h build rule to not depend on hg [In reply to]

Martin v. Löwis <martin [at] v> added the comment:

As I don't fully understand what the original issue was, I can't know for sure whether it's fixed now. But yes, there is now a mechanism to bring the time stamps in the right order.

----------
resolution: -> fixed
status: open -> closed

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14642>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads