Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Python: Bugs

[issue10142] Support for SEEK_HOLE/SEEK_DATA

 

 

Python bugs RSS feed   Index | Next | Previous | View Threaded


report at bugs

Apr 18, 2012, 7:54 AM

Post #1 of 25 (292 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA

Changes by Jesús Cea Avión <jcea [at] jcea>:


Added file: http://bugs.python.org/file25259/d6aeff63fa5e.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 18, 2012, 7:52 AM

Post #2 of 25 (289 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Changes by Jesús Cea Avión <jcea [at] jcea>:


----------
hgrepos: +119

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 18, 2012, 7:52 AM

Post #3 of 25 (290 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Changes by Jesús Cea Avión <jcea [at] jcea>:


Removed file: http://bugs.python.org/file19566/z.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 18, 2012, 8:00 AM

Post #4 of 25 (289 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Changes by Jesús Cea Avión <jcea [at] jcea>:


Removed file: http://bugs.python.org/file25259/d6aeff63fa5e.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 18, 2012, 8:00 AM

Post #5 of 25 (290 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Changes by Jesús Cea Avión <jcea [at] jcea>:


Added file: http://bugs.python.org/file25260/3f967e00e267.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 18, 2012, 8:02 AM

Post #6 of 25 (288 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Jesús Cea Avión <jcea [at] jcea> added the comment:

Victor, internally Python uses 0, 1 and 2 as wired values independently of the platform values. This is probably an historic accident.

Please, review.

----------
stage: needs patch -> patch review

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 20, 2012, 3:41 AM

Post #7 of 25 (281 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Jesús Cea Avión <jcea [at] jcea> added the comment:

I am going to integrate next week

Please, review.

----------
assignee: -> jcea

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 20, 2012, 10:17 AM

Post #8 of 25 (282 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Terry J. Reedy <tjreedy [at] udel> added the comment:

Is there a reason to say (several times) 'can support' instead of just 'support'? Do the OSes in question just optionally support rather than always support?

The first version added: change 'depend of' to 'depend on'.

In several functions you delete error checks:
- if not (0 <= whence <= 2):
- raise ValueError("invalid whence value")
(or C equivalent). What happens with patch if invalid whence value is passed? Error from deeper in the call stack? Silently pass error, with no message?

Could import of io create set of valid_whences for system? Then check would be "if whence not in valid_whences:" (or C equivalent).

In 3.3, unittest has new mock submodule. Perhaps that would help testing.

----------
nosy: +terry.reedy

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 20, 2012, 10:30 AM

Post #9 of 25 (278 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Jesús Cea Avión <jcea [at] jcea> added the comment:

Terry, yes, skiping the test in the code will raise an error anyway when doing the real "seek()" OS syscall.

> Is there a reason to say (several times) 'can support' instead of
> just 'support'? Do the OSes in question just optionally support
> rather than always support?

Sometimes depends of the concrete filesystem used, or the concrete OS version.

> The first version added: change 'depend of' to 'depend on'.

Done in my repository. Thanks.

> Could import of io create set of valid_whences for system?
> Then check would be "if whence not in valid_whences:" (or C
> equivalent).

This is far from trivial and I don't see the point if OS "seek()" is going to give an error anyway. The only point would to provide a maybe more useful error message.

> In 3.3, unittest has new mock submodule. Perhaps that would help
> testing.

This is a very thin layer over the OS.

Thanks for the feedback.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 20, 2012, 1:04 PM

Post #10 of 25 (280 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Amaury Forgeot d'Arc <amauryfa [at] gmail> added the comment:

> I don't see the point if OS "seek()" is going to give an error anyway.
Please check that Windows won't crash the interpreter with bad 'whence' values, like it already does for closed file descriptors.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 24, 2012, 12:37 PM

Post #11 of 25 (273 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Changes by Jesús Cea Avión <jcea [at] jcea>:


Added file: http://bugs.python.org/file25347/34103049559f.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 24, 2012, 12:38 PM

Post #12 of 25 (274 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Changes by Jesús Cea Avión <jcea [at] jcea>:


Removed file: http://bugs.python.org/file25347/34103049559f.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 24, 2012, 12:48 PM

Post #13 of 25 (273 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Changes by Jesús Cea Avión <jcea [at] jcea>:


Added file: http://bugs.python.org/file25348/0a5a40a4674a.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 24, 2012, 12:51 PM

Post #14 of 25 (275 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Jesús Cea Avión <jcea [at] jcea> added the comment:

New version, addressing Amaury concerns and Neologix review.

Please, do a final review.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 24, 2012, 12:57 PM

Post #15 of 25 (275 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

- In test_posix.py: it's better to use the "with" statement when opening a file
- In Misc/NEWS: the entries should be kept in reverse chronological order

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 24, 2012, 1:15 PM

Post #16 of 25 (273 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Changes by Jesús Cea Avión <jcea [at] jcea>:


Added file: http://bugs.python.org/file25350/ad882ba08568.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 24, 2012, 1:15 PM

Post #17 of 25 (275 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Jesús Cea Avión <jcea [at] jcea> added the comment:

Another version, after Antoine feedback.

Please, review.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 26, 2012, 7:39 AM

Post #18 of 25 (265 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset 86dc014cdd74 by Jesus Cea in branch 'default':
Close #10142: Support for SEEK_HOLE/SEEK_DATA
http://hg.python.org/cpython/rev/86dc014cdd74

----------
nosy: +python-dev
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 26, 2012, 8:04 AM

Post #19 of 25 (266 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Benjamin Peterson <benjamin [at] python> added the comment:

You broke test_io

www.python.org/dev/buildbot/all/builders/x86 Gentoo Non-Debug 3.x/builds/2143/steps/test/logs/stdio

----------
nosy: +benjamin.peterson

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 26, 2012, 8:08 AM

Post #20 of 25 (265 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Jesús Cea Avión <jcea [at] jcea> added the comment:

Yes, backing out changeset.

Never suppose anything...

----------
resolution: fixed ->
stage: committed/rejected -> patch review
status: closed -> open

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 26, 2012, 8:25 AM

Post #21 of 25 (265 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Changes by Jesús Cea Avión <jcea [at] jcea>:


Added file: http://bugs.python.org/file25370/6447a9323b11.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 26, 2012, 8:25 AM

Post #22 of 25 (269 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Jesús Cea Avión <jcea [at] jcea> added the comment:

New patch proposed, with testsuite fixed.

Please, review. Last chance :-).

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 26, 2012, 10:56 AM

Post #23 of 25 (250 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Changes by Jesús Cea Avión <jcea [at] jcea>:


Added file: http://bugs.python.org/file25374/c7abfb4d4260.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 26, 2012, 10:57 AM

Post #24 of 25 (249 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Jesús Cea Avión <jcea [at] jcea> added the comment:

New patch, after neologix [at] free review.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 30, 2012, 7:13 AM

Post #25 of 25 (247 views)
Permalink
[issue10142] Support for SEEK_HOLE/SEEK_DATA [In reply to]

Hynek Schlawack <hs [at] ox> added the comment:

<bikeshed>In some cases you change "invalid" to "unsupported" when encountering an invalid/unsupported `whence' and in others you keep them on "invalid". I find it rather hard to really differentiate these two words in that context; care to shed a light and tell me the thought process behind that?</bikeshed>

----------
nosy: +hynek

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10142>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Python bugs RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.