Mailing List Archive: Python: Bugs

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change

Index | Next | Previous | View Threaded

report at bugs

Apr 18, 2012, 11:16 AM

Post #1 of 17 (102 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change

Joe Peterson <joe [at] skyrush> added the comment:

It's been over a year since any activity on this bug, and it is still in the "patch review" stage. Any news? Anything else I can provide to help to get this moved to the next stage? Thanks!

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 18, 2012, 11:26 AM

Post #2 of 17 (100 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

R. David Murray <rdmurray [at] bitdance> added the comment:

Someone needs to find time to review it.

You could try recruiting reviewers on python-list. Anyone can do a review. Obviously the more knowledge they have in this area the better, but any good review is likely to move the issue along.

----------
nosy: +r.david.murray

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 18, 2012, 1:53 PM

Post #3 of 17 (95 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

Joe Peterson <joe [at] skyrush> added the comment:

Ah. I figured that one of the Python devs would be who would review it. Is this the normal path for bugs? Not to question the process, but I find it surprising, since I would think that it would cause a lot of bugs to stall out. Also, I had no idea it was the submitter's responsibility to recruit reviewers. And I am not quite sure how to go about this. I do care about this bug (as it's pretty serious that it returns wrong results), so I am willing to do it. Any wiki page or anything that describes the recruiting process or has more info?

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 18, 2012, 1:59 PM

Post #4 of 17 (95 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

Alexander Belopolsky <alexander.belopolsky [at] gmail> added the comment:

I'll review your patch.

On Apr 18, 2012, at 4:53 PM, Joe Peterson <report [at] bugs> wrote:

>
> Joe Peterson <joe [at] skyrush> added the comment:
>
> Ah. I figured that one of the Python devs would be who would review it. Is this the normal path for bugs? Not to question the process, but I find it surprising, since I would think that it would cause a lot of bugs to stall out. Also, I had no idea it was the submitter's responsibility to recruit reviewers. And I am not quite sure how to go about this. I do care about this bug (as it's pretty serious that it returns wrong results), so I am willing to do it. Any wiki page or anything that describes the recruiting process or has more info?
>
> ----------
>
> _______________________________________
> Python tracker <report [at] bugs>
> <http://bugs.python.org/issue10941>
> _______________________________________

----------
nosy: +Alexander.Belopolsky

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 18, 2012, 2:05 PM

Post #5 of 17 (93 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

R. David Murray <rdmurray [at] bitdance> added the comment:

I see Alexander is going to take care of this. But to clarify what I suggested for your information:

In an ideal world it would be a committer doing the patch review, followed by a checkin. But in the real world there aren't enough of us with enough time to get to all the bugs with patches. You asked how to move it along and I suggested one way: get someone else to do a review. I wouldn't say that the submitter recruiting a reviewer was a "normal" process, but it is a way to get bugs unstuck. And we get reviews from non-committers frequently (it is a step along the path to becoming a committer...quality reviews are as important as quality patches).

I don't think there's anything in the devguide about this particular nuance.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 18, 2012, 2:05 PM

Post #6 of 17 (94 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

Joe Peterson <joe [at] skyrush> added the comment:

Thanks!! :)

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 18, 2012, 2:16 PM

Post #7 of 17 (96 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

Joe Peterson <joe [at] skyrush> added the comment:

David, I understand - thanks for the details. Hopefully I can return the favor and review one in the future.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 19, 2012, 8:14 AM

Post #8 of 17 (90 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

Alexander Belopolsky <alexander.belopolsky [at] gmail> added the comment:

Joe,

Your changes to the test suit don't apply cleanly anymore. I can probably fix the conflicts, but if you could post an updated patch it will help.

Thanks.

----------
nosy: -Alexander.Belopolsky

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 19, 2012, 11:08 PM

Post #9 of 17 (95 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

Joe Peterson <joe [at] skyrush> added the comment:

OK, fixed patch to apply cleanly to current code. BTW, this is only for python3. Is it still appropriate to patch python2? And if so, what is the correct code repo to check out for that?

----------
versions: +Python 3.4
Added file: http://bugs.python.org/file25285/issue10941_python3.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 20, 2012, 5:55 PM

Post #10 of 17 (89 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

Joe Peterson <joe [at] skyrush> added the comment:

I have now included a patch for 2.7. Here are the two latest patches:

Python 2: issue10941_python2.diff
Python 3: issue10941_python3.diff

----------
Added file: http://bugs.python.org/file25297/issue10941_python2.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 23, 2012, 5:42 PM

Post #11 of 17 (86 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

Alexander Belopolsky <alexander.belopolsky [at] gmail> added the comment:

I still get conflicts:

$ patch -p0 < imaplib_Internaldate2tuple_dst_fix_python32.patch
patching file Lib/imaplib.py
Hunk #2 FAILED at 1312.
Hunk #3 succeeded at 1347 (offset 8 lines).
Hunk #4 FAILED at 1379.
2 out of 4 hunks FAILED -- saving rejects to file Lib/imaplib.py.rej
patching file Lib/test/test_imaplib.py
Hunk #1 FAILED at 24.
1 out of 1 hunk FAILED -- saving rejects to file Lib/test/test_imaplib.py.rej

Are you sure your patch is against the head of the hg repository?

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 23, 2012, 7:21 PM

Post #12 of 17 (82 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

Joe Peterson <joe [at] skyrush> added the comment:

The one you tried is the old patch. Here are the two new patches. Use these:

Python 2: issue10941_python2.diff
Python 3: issue10941_python3.diff

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 24, 2012, 7:36 AM

Post #13 of 17 (80 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

Alexander Belopolsky <alexander.belopolsky [at] gmail> added the comment:

My bad. For some reason I assumed that the latest patch would be at the top of the files list.

David, the patch is good. Should I go ahead and commit?

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 24, 2012, 7:42 AM

Post #14 of 17 (83 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

Joe Peterson <joe [at] skyrush> added the comment:

Great to hear, Alexander. Thanks for reviewing! Is it also possible to get the pyhton2.7 version one in?

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 24, 2012, 7:47 AM

Post #15 of 17 (81 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

Alexander Belopolsky <alexander.belopolsky [at] gmail> added the comment:

On Tue, Apr 24, 2012 at 10:42 AM, Joe Peterson <report [at] bugs> wrote:
..
> Is it also possible to get the pyhton2.7 version one in?

I don't see any reason not to. This is a bug fix and should go into a
maintenance release. I will wait to hear from David, who is the
maintainer of this module, though.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 24, 2012, 8:04 AM

Post #16 of 17 (80 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

R. David Murray <rdmurray [at] bitdance> added the comment:

If you are satisfied with the time logic then yes, please apply it. I suspect that the number of people using the code and not aware of the problem (or not caring enough to do anything about it) exceeds the number aware of it who have coded a workaround, so I think putting it in 2.7 (and 3.2) is better than not doing so.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Apr 29, 2012, 1:42 PM

Post #17 of 17 (71 views)
Permalink

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset 90b9781ccb5f by Alexander Belopolsky in branch '3.2':
Issue #10941: Fix imaplib.Internaldate2tuple to produce correct result near
http://hg.python.org/cpython/rev/90b9781ccb5f

New changeset 6e029b6c142a by Alexander Belopolsky in branch 'default':
Issue #10941: Fix imaplib.Internaldate2tuple to produce correct result near
http://hg.python.org/cpython/rev/6e029b6c142a

----------
nosy: +python-dev

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10941>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads