Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Python: Bugs

[issue14310] Socket duplication for windows

 

 

First page Previous page 1 2 Next page Last page  View All Python bugs RSS feed   Index | Next | Previous | View Threaded


report at bugs

Apr 6, 2012, 2:48 PM

Post #26 of 43 (299 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

> Here is a new patch, with more tests.
> Note that the process worker function can't be a member function
> because of how multiprocessing works on Windows.

Some comments:
- I said classmethod, not member function; this is how
test_multiprocessing works, so it should be possible...
- why did you change the gethostbyname() tests?
- before using AF_INET6, you might have to test that IPv6 is available
on the test machine (I think there are variables / functions for that in
test_socket)
- in compareSockets:

+ if org.proto != 0:
+ self.assertEqual(sock.proto, other.proto)

`sock` doesn't seem to exist at all...

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 6, 2012, 3:18 PM

Post #27 of 43 (303 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Kristján Valur Jónsson <kristjan [at] ccpgames> added the comment:

by "memberfunction" I mean a member of the class. I tried staticmethod and it didn't work:
I tried a staticmethod and it didn't work:
======================================================================
ERROR: testShare (test.test_socket.TestSocketSharing)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\pydev\cpython\lib\test\test_socket.py", line 4723, in testShare
p.start()
File "D:\pydev\cpython\lib\multiprocessing\process.py", line 136, in start
self._popen = Popen(self)
File "D:\pydev\cpython\lib\multiprocessing\forking.py", line 269, in __init__
dump(process_obj, to_child, HIGHEST_PROTOCOL)
File "D:\pydev\cpython\lib\multiprocessing\forking.py", line 190, in dump
ForkingPickler(file, protocol).dump(obj)
_pickle.PicklingError: Can't pickle <class 'function'>: attribute lookup builtins.function failed

(Picking this kind of stuff should work of course but that's another story)
But changing it to staticmethod strangely fixes it. Interesting.

the gethostbynametests were an encoding mistake. Would not have been checked in but it was nice of you to notice.

These are windows only tests for python 3.3. There is no need to test for IPV6.

Here is yet another patch.

----------
Added file: http://bugs.python.org/file25145/duplicate.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 6, 2012, 3:20 PM

Post #28 of 43 (300 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

[...]
> But changing it to staticmethod strangely fixes it. Interesting.

Sorry?

> Here is yet another patch.

Your patch is broken, it has lots of duplicate stuff...

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 6, 2012, 3:29 PM

Post #29 of 43 (301 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Changes by Kristján Valur Jónsson <kristjan [at] ccpgames>:


Removed file: http://bugs.python.org/file25145/duplicate.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 6, 2012, 3:29 PM

Post #30 of 43 (303 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Changes by Kristján Valur Jónsson <kristjan [at] ccpgames>:


Removed file: http://bugs.python.org/file25143/duplicate.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 6, 2012, 3:32 PM

Post #31 of 43 (309 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Kristján Valur Jónsson <kristjan [at] ccpgames> added the comment:

>> But changing it to staticmethod strangely fixes it. Interesting.
>Sorry?
Don't be, probably not your fault. Today we have learned that we can spawn multipropcessing targets with classmethods, but not staticmethods.

>Your patch is broken, it has lots of duplicate stuff...
Yes, I'm sorry, it was a merging error. I'm still getting to grips with Hg. I removed the last two and added a new one. Hope you like it.

----------
Added file: http://bugs.python.org/file25146/duplicate.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 6, 2012, 3:40 PM

Post #32 of 43 (301 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

> Yes, I'm sorry, it was a merging error. I'm still getting to grips
> with Hg. I removed the last two and added a new one. Hope you like
> it.

It's still broken.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 6, 2012, 3:51 PM

Post #33 of 43 (299 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Kristján Valur Jónsson <kristjan [at] ccpgames> added the comment:

Could you possibly be any more specific? It works for me.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 6, 2012, 3:55 PM

Post #34 of 43 (301 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

> Could you possibly be any more specific? It works for me.

Just read it by yourself. There are still duplicate portions there:
http://bugs.python.org/file25146/duplicate.patch

In general, it's nicer to others to review your changes before uploading them.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 6, 2012, 6:18 PM

Post #35 of 43 (300 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Changes by Kristján Valur Jónsson <kristjan [at] ccpgames>:


Removed file: http://bugs.python.org/file25146/duplicate.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 6, 2012, 6:24 PM

Post #36 of 43 (298 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Kristján Valur Jónsson <kristjan [at] ccpgames> added the comment:

Well, I think I have all of the merge errors out now. You´ll forgive me if I didn't notice them all at first, but this is why we review code and you would have helped me by giving me specifics, since after a time, the eyes tend to glaze over.
Any other comments?

----------
Added file: http://bugs.python.org/file25149/duplicate.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 7, 2012, 3:22 AM

Post #37 of 43 (299 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

> Any other comments?

No, the patch looks ok now. Please watch the buildbots after you commit.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 7, 2012, 4:24 AM

Post #38 of 43 (320 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset 51b4bddd0e92 by Kristján Valur Jónsson in branch 'default':
Issue #14310: inter-process socket duplication for windows
http://hg.python.org/cpython/rev/51b4bddd0e92

----------
nosy: +python-dev

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 7, 2012, 4:25 AM

Post #39 of 43 (311 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Changes by Kristján Valur Jónsson <kristjan [at] ccpgames>:


----------
resolution: -> fixed
status: open -> closed

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 7, 2012, 1:10 PM

Post #40 of 43 (298 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

Re-opening. There is now a buildbot failure:

======================================================================
ERROR: testTypes (test.test_socket.TestSocketSharing)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows\build\lib\test\test_socket.py", line 4738, in testTypes
source = socket.socket(f, t)
File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows\build\lib\socket.py", line 94, in __init__
_socket.socket.__init__(self, family, type, proto, fileno)
OSError: [Error 10047] An address incompatible with the requested protocol was used

http://www.python.org/dev/buildbot/all/builders/x86%20XP-4%203.x/

----------
assignee: -> krisvale
stage: -> committed/rejected
status: closed -> open

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 7, 2012, 1:39 PM

Post #41 of 43 (300 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Roundup Robot <devnull [at] psf> added the comment:

New changeset 9b858096044e by Kristján Valur Jónsson in branch 'default':
Issue #14310: Catch testing errors when trying to create unsupported socket
http://hg.python.org/cpython/rev/9b858096044e

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 18, 2012, 1:26 PM

Post #42 of 43 (299 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

sbt <shibturn [at] gmail> added the comment:

Can this issue be reclosed now?

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Apr 18, 2012, 1:29 PM

Post #43 of 43 (299 views)
Permalink
[issue14310] Socket duplication for windows [In reply to]

Changes by Antoine Pitrou <pitrou [at] free>:


----------
status: open -> closed

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue14310>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

First page Previous page 1 2 Next page Last page  View All Python bugs RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.