Mailing List Archive: Python: Bugs

[issue7373] Use PyModule_AddIntMacro() in Modules/gcmodule.c

Index | Next | Previous | View Threaded

report at bugs

Nov 21, 2009, 3:56 PM

Post #1 of 5 (345 views)
Permalink

[issue7373] Use PyModule_AddIntMacro() in Modules/gcmodule.c

New submission from Jon Parise <jon [at] indelible>:

The attached patch uses PyModule_AddIntMacro() to register the gc
module's constants instead of using a local ADD_INT() macro.

----------
components: Interpreter Core
files: gc_macros-trunk.patch
keywords: patch
messages: 95589
nosy: jon
severity: normal
status: open
title: Use PyModule_AddIntMacro() in Modules/gcmodule.c
type: feature request
versions: Python 2.7, Python 3.2
Added file: http://bugs.python.org/file15378/gc_macros-trunk.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue7373>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 21, 2009, 3:57 PM

Post #2 of 5 (335 views)
Permalink

[issue7373] Use PyModule_AddIntMacro() in Modules/gcmodule.c [In reply to]

Changes by Jon Parise <jon [at] indelible>:

Added file: http://bugs.python.org/file15379/gc_macros-py3k.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue7373>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 21, 2009, 4:02 PM

Post #3 of 5 (329 views)
Permalink

[issue7373] Use PyModule_AddIntMacro() in Modules/gcmodule.c [In reply to]

Benjamin Peterson <benjamin [at] python> added the comment:

You don't account for PyModule_AddIntMacro failing.

----------
nosy: +benjamin.peterson

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue7373>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 21, 2009, 5:18 PM

Post #4 of 5 (324 views)
Permalink

[issue7373] Use PyModule_AddIntMacro() in Modules/gcmodule.c [In reply to]

Jon Parise <jon [at] indelible> added the comment:

That's true. I thought it worked the same as the ADD_INT() macro I
replaced, but I see that I was wrong.

Given that, perhaps the original code is best. I don't see a lot of
value in replacing PyModule_AddIntConstant() with PyModule_AddIntMacro()
within ADD_INT().

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue7373>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 22, 2009, 6:34 PM

Post #5 of 5 (320 views)
Permalink

[issue7373] Use PyModule_AddIntMacro() in Modules/gcmodule.c [In reply to]

Changes by Benjamin Peterson <benjamin [at] python>:

----------
resolution: -> works for me
status: open -> closed

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue7373>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads