Mailing List Archive: Python: Bugs

[issue7228] %lld for PyErr_Format (Modules/_io/bufferedio.c)

Index | Next | Previous | View Threaded

report at bugs

Nov 15, 2009, 6:01 AM

Post #1 of 7 (381 views)
Permalink

[issue7228] %lld for PyErr_Format (Modules/_io/bufferedio.c)

Changes by Mark Dickinson <dickinsm [at] gmail>:

----------
priority: -> normal

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue7228>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 15, 2009, 9:06 AM

Post #2 of 7 (347 views)
Permalink

[issue7228] %lld for PyErr_Format (Modules/_io/bufferedio.c) [In reply to]

Mark Dickinson <dickinsm [at] gmail> added the comment:

Added extra #ifdef HAVE_LONG_LONG as suggested.

Committed to trunk in r76308. I'm working on the merge to py3k, which
isn't entirely straightforward.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue7228>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 15, 2009, 11:14 AM

Post #3 of 7 (346 views)
Permalink

[issue7228] %lld for PyErr_Format (Modules/_io/bufferedio.c) [In reply to]

Mark Dickinson <dickinsm [at] gmail> added the comment:

Just so I don't lose it, here's the current version of the forward merge
of r76308 to py3k.

In testing this, I found some other possible bugs in the py3k
implementation of PyUnicode_FromFormat; I need to investigate and
possibly fix those before this can be applied.

----------
Added file: http://bugs.python.org/file15344/add_lld_format_py3k.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue7228>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 16, 2009, 9:02 AM

Post #4 of 7 (332 views)
Permalink

[issue7228] %lld for PyErr_Format (Modules/_io/bufferedio.c) [In reply to]

Mark Dickinson <dickinsm [at] gmail> added the comment:

Merged to py3k in r76328.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue7228>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 16, 2009, 9:29 AM

Post #5 of 7 (333 views)
Permalink

[issue7228] %lld for PyErr_Format (Modules/_io/bufferedio.c) [In reply to]

Mark Dickinson <dickinsm [at] gmail> added the comment:

ocean-city, now that "lld" and "llu" support has been added, could you
retest this patch (offt_formats.patch) for me?

----------
Added file: http://bugs.python.org/file15346/offt_formats.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue7228>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 23, 2009, 11:28 PM

Post #6 of 7 (274 views)
Permalink

[issue7228] %lld for PyErr_Format (Modules/_io/bufferedio.c) [In reply to]

Hirokazu Yamamoto <ocean-city [at] m2> added the comment:

I think your patch is correct. (I couldn't check the behavior on error
condition itself, because I wasn't sure how, but I checked test_io run
on windows)

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue7228>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 24, 2009, 12:59 PM

Post #7 of 7 (269 views)
Permalink

[issue7228] %lld for PyErr_Format (Modules/_io/bufferedio.c) [In reply to]

Mark Dickinson <dickinsm [at] gmail> added the comment:

Thanks for testing!

Fixed (again) in r76502 (trunk), r76503 (py3k). I don't think it's worth
backporting the fix to the release branches, given that that would require
also implementing %lld support in those branches.

----------
resolution: -> fixed
status: open -> closed

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue7228>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads