Mailing List Archive: Python: Bugs

[issue4969] mimetypes on Windows should read MIME database from registry (w/patch)

Index | Next | Previous | View Threaded

report at bugs

Nov 3, 2009, 2:25 PM

Post #1 of 7 (233 views)
Permalink

[issue4969] mimetypes on Windows should read MIME database from registry (w/patch)

Changes by Timothy Farrell <tfarrell [at] swgen>:

----------
nosy: +tercero12

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue4969>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 3, 2009, 5:26 PM

Post #2 of 7 (225 views)
Permalink

[issue4969] mimetypes on Windows should read MIME database from registry (w/patch) [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

A couple of points:
- if the method is Windows-specific, I don't think it shouldn't bear a
name as generic as "read_registry()". There are "registries" on other
systems.
- the method should probably raise early on non-Windows systems (raise
NotImplementedError?)
- please fix the coding style; don't collapse a "try", "except" or
"finally" and the following statement on a single line
- in the tests, rather than defining an empty test case on non-Windows
systems, make the tests skip (for example, call self.skipTest()

----------
nosy: +pitrou
priority: -> normal
stage: -> patch review
type: -> feature request
versions: +Python 3.2 -Python 3.1

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue4969>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 3, 2009, 5:33 PM

Post #3 of 7 (229 views)
Permalink

[issue4969] mimetypes on Windows should read MIME database from registry (w/patch) [In reply to]

Changes by Antoine Pitrou <pitrou [at] free>:

----------
nosy: +ocean-city

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue4969>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 15, 2009, 12:56 AM

Post #4 of 7 (198 views)
Permalink

[issue4969] mimetypes on Windows should read MIME database from registry (w/patch) [In reply to]

Gabriel Genellina <gagsl-py2 [at] yahoo> added the comment:

A new patch taking into account M. Pitrou comments:

- name changed to read_windows_registry()
- read_windows_registry() does nothing on non-Windows platforms; same
as read_mime_types(filename) when the file does not exist.
- I hope the coding style is acceptable now
- the test is skipped on non-Windows platforms
- documentation updated
- documentation for MimeTypes.guess_all_extensions was missing; I
added it although it isn't directly related to this issue.

----------
Added file: http://bugs.python.org/file15338/mimetypes.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue4969>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 15, 2009, 12:56 AM

Post #5 of 7 (196 views)
Permalink

[issue4969] mimetypes on Windows should read MIME database from registry (w/patch) [In reply to]

Changes by Gabriel Genellina <gagsl-py2 [at] yahoo>:

Removed file: http://bugs.python.org/file12774/mimetypes.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue4969>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 15, 2009, 6:06 AM

Post #6 of 7 (194 views)
Permalink

[issue4969] mimetypes on Windows should read MIME database from registry (w/patch) [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

Thank you, the patch looks ok to me.

----------
resolution: -> accepted

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue4969>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 15, 2009, 6:26 AM

Post #7 of 7 (193 views)
Permalink

[issue4969] mimetypes on Windows should read MIME database from registry (w/patch) [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

Committed in r76306 and r76307, closing.

----------
resolution: accepted -> fixed
stage: patch review -> committed/rejected
status: open -> closed

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue4969>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads