Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Python: Bugs

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

 

 

Python bugs RSS feed   Index | Next | Previous | View Threaded


report at bugs

Nov 10, 2009, 9:32 AM

Post #1 of 7 (371 views)
Permalink
[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Senthil Kumaran <orsenthil [at] gmail> added the comment:

drukker: I verified your patch. Looks fine for changes made to the
subprocess call.

You mentioned: I've also unified the Unix and Windows portions in
run_cgi. Both now use subprocess."
I don't see it in the patch. Was it that you assumed changing the
variable to from cmdline to 'args' makes it unified for windows and
linux? But it does not.

Irrespective, this report can be addressed by the changes you suggested.

----------
assignee: -> orsenthil
nosy: +orsenthil

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue1235>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Nov 10, 2009, 10:26 AM

Post #2 of 7 (356 views)
Permalink
[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks [In reply to]

Derk Drukker <derk.drukker [at] gmail> added the comment:

orsenthil: I reverted the changes that make Windows and Unix use the
same code in Patch Set 3, and briefly mentioned the reason for that in
the Rietveld app. I should have mentioned it here too.

It was because it actually makes the implementation on Unix worse, since
the Windows implementation reads all data in memory. (The subprocess
module documentation has this note: "The data read is buffered in
memory, so do not use this method if the data size is large or unlimited.")

I tried replacing subprocess.PIPE with rfile/wfile, but it turns out
that that won't work, because on Windows socket.fileno() cannot be used
where file descriptors can be used, as the socket module documentation
states.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue1235>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Nov 10, 2009, 10:26 AM

Post #3 of 7 (356 views)
Permalink
[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks [In reply to]

Changes by Derk Drukker <derk.drukker [at] gmail>:


Removed file: http://bugs.python.org/file15181/fix-issue1235-py3k.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue1235>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Nov 10, 2009, 5:36 PM

Post #4 of 7 (359 views)
Permalink
[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks [In reply to]

Senthil Kumaran <orsenthil [at] gmail> added the comment:

Committed revision 76208 in trunk. Shall look at the output of windows
buildbots and merge the changes to other codelines.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue1235>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Nov 10, 2009, 8:22 PM

Post #5 of 7 (352 views)
Permalink
[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks [In reply to]

Senthil Kumaran <orsenthil [at] gmail> added the comment:

Committed revision 76209 - release26-maint
Committed revision 76210 - py3k
Committed revision 76211 - release31-maint

Thanks Derk for the patch.

----------
resolution: -> fixed
status: open -> closed

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue1235>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Nov 11, 2009, 9:11 AM

Post #6 of 7 (342 views)
Permalink
[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks [In reply to]

Brian Curtin <curtin [at] acm> added the comment:

This change causes failures in test_httpservers on trunk r76211 on
Windows. I attached a simple patch which fixes the problem (NameError on
'p').

----------
nosy: +brian.curtin
Added file: http://bugs.python.org/file15309/issue1235_fix.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue1235>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com


report at bugs

Nov 11, 2009, 9:26 AM

Post #7 of 7 (342 views)
Permalink
[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks [In reply to]

Senthil Kumaran <orsenthil [at] gmail> added the comment:

Thanks for the notification. Seems I over looked it. Fixed it with the
changes in 76212 (trunk) and 76213 (release26-maint). py3k did not have
this issue.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue1235>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Python bugs RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.