Mailing List Archive: Python: Bugs

[issue6748] test_debuglevel from test_telnetlib.py fails

Index | Next | Previous | View Threaded

report at bugs

Oct 31, 2009, 2:19 PM

Post #1 of 18 (631 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails

Changes by Ezio Melotti <ezio.melotti [at] gmail>:

----------
nosy: +ezio.melotti
priority: -> normal

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Oct 31, 2009, 2:38 PM

Post #2 of 18 (612 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

This failure actually still happens quite regularly (on the buildbots
and also on my Mandriva system).

Judging from a quick Google search, errno 104 (ECONNRESET) should be
treated as a case of EOF (it means the TCP connection was reset using
RST rather than FIN, which apparently sometimes happens).

Besides, the test flow in test_telnetlib really is a mess (setUp and
tearDown getting called multiple times, for example), could you clean it up?

----------
nosy: +pitrou
versions: +Python 3.2

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Oct 31, 2009, 2:54 PM

Post #3 of 18 (609 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Derk Drukker <derk.drukker [at] gmail> added the comment:

This patch fixes the issue.

----------
keywords: +patch
nosy: +drukker
Added file: http://bugs.python.org/file15242/issue6748.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Oct 31, 2009, 3:07 PM

Post #4 of 18 (610 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Eric Smith <eric [at] trueblade> added the comment:

I still get 'Connection reset by peer' on OS/X 10.5.8 with this patch
(http://bugs.python.org/file15242/issue6748.patch).

----------
nosy: +eric.smith

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Oct 31, 2009, 3:21 PM

Post #5 of 18 (619 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Jack Diederich <jackdied [at] gmail> added the comment:

Antoine Pitrou: Besides, the test flow in test_telnetlib really is a
mess (setUp and tearDown getting called multiple times, for example),
could you clean it up?

Yes, I'm working on refactoring the test server and separating out
testing that versus testing the telnetlib. It is the test server (which
started simple and then grew cruft) which seems to have OS specific
problems.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Oct 31, 2009, 3:28 PM

Post #6 of 18 (612 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Derk Drukker <derk.drukker [at] gmail> added the comment:

The change in the patch worked for me on py3k on Ubuntu 9.10. It makes
sense, though, that it could still fail: conn can get closed too soon.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 1, 2009, 8:23 AM

Post #7 of 18 (593 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Antoine Pitrou <pitrou [at] free> added the comment:

Please note that the Windows buildbot shows another error:

======================================================================
ERROR: test_debuglevel (test.test_telnetlib.OptionTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"E:\cygwin\home\db3l\buildarea\3.1.bolen-windows\build\lib\test\test_telnetlib.py",
line 409, in test_debuglevel
self._test_debuglevel([a, EOF_sigil], b)
File
"E:\cygwin\home\db3l\buildarea\3.1.bolen-windows\build\lib\test\test_telnetlib.py",
line 389, in _test_debuglevel
txt = telnet.read_all()
File
"E:\cygwin\home\db3l\buildarea\3.1.bolen-windows\build\lib\telnetlib.py", line
325, in read_all
self.fill_rawq()
File
"E:\cygwin\home\db3l\buildarea\3.1.bolen-windows\build\lib\telnetlib.py", line
516, in fill_rawq
buf = self.sock.recv(50)
socket.error: [Errno 10053] An established connection was aborted by the
software in your host machine

According to a quick search on the Web, 10053 under Windows would be for
ECONNABORTED. Bazaar apparently faced the same issue:

https://lists.ubuntu.com/archives/bazaar/2006q4/020035.html

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 5, 2009, 6:49 PM

Post #8 of 18 (544 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Changes by R. David Murray <rdmurray [at] bitdance>:

----------
keywords: +buildbot

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 6, 2009, 6:32 AM

Post #9 of 18 (547 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Jack Diederich <jackdied [at] gmail> added the comment:

Simplified tests attached. Instead of bulking up and testing the TCP
server implementation I ended up mocking/stubing the socket recv/sendall
and select.select functions. The only tests that use real sockets are
the ones to test timeouts. Therefore test_telnetlib.py should be
platform neutral (let test_socket.py figure that stuff out).

Unless this blows up for anyone I'll check it in later today.

----------
Added file: http://bugs.python.org/file15276/simplified_6748.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 6, 2009, 6:53 AM

Post #10 of 18 (546 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Mark Dickinson <dickinsm [at] gmail> added the comment:

With these test simplifications, it looks as though you could lose some
imports as well. (E.g., queue, os).

Patch works fine for me on 64-bit Linux. I'll test it on OS X (10.5 and
10.6) when I get home tonight.

----------
nosy: +mark.dickinson

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 6, 2009, 7:02 AM

Post #11 of 18 (548 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Jack Diederich <jackdied [at] gmail> added the comment:

ran pyflakes and removed unused imports.

----------
Added file: http://bugs.python.org/file15278/simplified_6748.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 6, 2009, 7:02 AM

Post #12 of 18 (545 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Changes by Jack Diederich <jackdied [at] gmail>:

Removed file: http://bugs.python.org/file15276/simplified_6748.diff

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 6, 2009, 7:21 AM

Post #13 of 18 (543 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Eric Smith <eric [at] trueblade> added the comment:

The new patch works for me on 32-bit OS X 10.5. I think the approach of
mocking the sockets is a good idea, although I haven't reviewed the
patch itself.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 6, 2009, 7:44 AM

Post #14 of 18 (543 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Mark Dickinson <dickinsm [at] gmail> added the comment:

The most recent patch (http://bugs.python.org/file15278) works for
me on OS X 10.4/PPC (32-bit), OS X 10.5/Intel (32-bit) and OS X 10.6/Intel
(64-bit).

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 6, 2009, 9:15 AM

Post #15 of 18 (546 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

R. David Murray <rdmurray [at] bitdance> added the comment:

The patch runs clean on my Gentoo buildbot, which otherwise fails
consistently. I say apply it, I doubt you'd be making things worse by
doing so :)

Using minimal mocks with as few external dependencies as possible is
considered good unit-testing practice, from what I understand.

----------
nosy: +r.david.murray
priority: normal -> high
stage: -> commit review
type: -> behavior

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 6, 2009, 9:21 AM

Post #16 of 18 (543 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Jack Diederich <jackdied [at] gmail> added the comment:

committed in rev 76133

----------
resolution: -> fixed
status: open -> closed

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 6, 2009, 11:27 AM

Post #17 of 18 (551 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

R. David Murray <rdmurray [at] bitdance> added the comment:

Jack, this failure is happening also in 3.1. I tried to merge the
revision, but there are too many differences between 3.x and 3.1 for me
to be confident that I'd get it right. Could you do the backport, please?

----------
status: closed -> open

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Nov 6, 2009, 1:17 PM

Post #18 of 18 (550 views)
Permalink

[issue6748] test_debuglevel from test_telnetlib.py fails [In reply to]

Jack Diederich <jackdied [at] gmail> added the comment:

backported to maint via svnmerge in r76136. 3.1 and 3.x
test_telnetlib.py's (and telnetlib.py's) are now identical.

----------
status: open -> closed

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue6748>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads