Mailing List Archive: Python: Bugs

[issue6382] test_socketserver fails on trunk in test_ForkingTCPServer

Index | Next | Previous | View Threaded

report at bugs

Jun 29, 2009, 6:58 PM

Post #1 of 8 (219 views)
Permalink

[issue6382] test_socketserver fails on trunk in test_ForkingTCPServer

New submission from R. David Murray <rdmurray[at]bitdance.com>:

Gentoo linux, trunk r73699. test_socketserver fails with the following
tracebacks:

======================================================================
FAIL: test_ForkingTCPServer (test.test_socketserver.SocketServerTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/rdmurray/python/trunk/Lib/test/test_socketserver.py", line
189, in test_ForkingTCPServer
self.stream_examine)
File "/home/rdmurray/python/trunk/Lib/test/test_socketserver.py", line
147, in run_server
testfunc(svrcls.address_family, addr)
File "/home/rdmurray/python/trunk/Lib/test/test_socketserver.py", line
161, in stream_examine
self.assertEquals(buf, TEST_STR)
AssertionError: '' != 'hello world\n'

======================================================================
FAIL: test_ForkingUnixStreamServer (test.test_socketserver.SocketServerTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/rdmurray/python/trunk/Lib/test/test_socketserver.py", line
207, in test_ForkingUnixStreamServer
self.stream_examine)
File "/home/rdmurray/python/trunk/Lib/test/test_socketserver.py", line
147, in run_server
testfunc(svrcls.address_family, addr)
File "/home/rdmurray/python/trunk/Lib/test/test_socketserver.py", line
161, in stream_examine
self.assertEquals(buf, TEST_STR)
AssertionError: '' != 'hello world\n'

----------
components: Library (Lib)
messages: 89897
nosy: r.david.murray
priority: normal
severity: normal
stage: needs patch
status: open
title: test_socketserver fails on trunk in test_ForkingTCPServer
versions: Python 2.7

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue6382>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 4, 2009, 8:44 AM

Post #2 of 8 (182 views)
Permalink

[issue6382] test_socketserver fails on trunk in test_ForkingTCPServer [In reply to]

Kristján Valur Jónsson <kristjan[at]ccpgames.com> added the comment:

This is a "fork" problem.
socket.close must be done on the parent, while socket.shutdown and
socket.close must be performed on the child.
I must restructure this a little bit to make it work.

----------
nosy: +krisvale

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue6382>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 5, 2009, 1:57 PM

Post #3 of 8 (168 views)
Permalink

[issue6382] test_socketserver fails on trunk in test_ForkingTCPServer [In reply to]

Kristján Valur Jónsson <kristjan[at]ccpgames.com> added the comment:

submitted revision 73863. Please test for me on gentoo.

----------

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue6382>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 6, 2009, 9:17 AM

Post #4 of 8 (154 views)
Permalink

[issue6382] test_socketserver fails on trunk in test_ForkingTCPServer [In reply to]

R. David Murray <rdmurray[at]bitdance.com> added the comment:

I now get a different error, followed by zsh detecting an alarm:

rdmurray[at]partner:~/python/trunk>./python -m test.regrtest -uall
test_socketserver
Could not find '/home/rdmurray/python/trunk/Lib/test' in sys.path to
remove it
test_socketserver
Exception in thread SocketServer.ForkingUDPServer serving:
Traceback (most recent call last):
File "/home/rdmurray/python/trunk/Lib/threading.py", line 524, in
__bootstrap_inner
self.run()
File "/home/rdmurray/python/trunk/Lib/threading.py", line 477, in run
self.__target(*self.__args, **self.__kwargs)
File "/home/rdmurray/python/trunk/Lib/SocketServer.py", line 226, in
serve_forever
self._handle_request_noblock()
File "/home/rdmurray/python/trunk/Lib/SocketServer.py", line 283, in
_handle_request_noblock
self.handle_error(request, client_address)
File "/home/rdmurray/python/trunk/Lib/SocketServer.py", line 281, in
_handle_request_noblock
self.process_request(request, client_address)
File "/home/rdmurray/python/trunk/Lib/SocketServer.py", line 535, in
process_request
request.close() #close socket handle in parent process
AttributeError: 'tuple' object has no attribute 'close'

zsh: alarm ./python -m test.regrtest -uall test_socketserver

----------

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue6382>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 6, 2009, 4:41 PM

Post #5 of 8 (155 views)
Permalink

[issue6382] test_socketserver fails on trunk in test_ForkingTCPServer [In reply to]

Kristján Valur Jónsson <kristjan[at]ccpgames.com> added the comment:

How unfortunate. This means that we need to virtualize the shutdown. I'll
submit a proposed patch.

----------

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue6382>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 6, 2009, 5:13 PM

Post #6 of 8 (155 views)
Permalink

[issue6382] test_socketserver fails on trunk in test_ForkingTCPServer [In reply to]

Kristján Valur Jónsson <kristjan[at]ccpgames.com> added the comment:

I'm uploading a patched SocketServer.py. Could you please try it out on
the gentoo box before I commit it?

----------
Added file: http://bugs.python.org/file14462/SocketServer.py

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue6382>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 6, 2009, 6:38 PM

Post #7 of 8 (152 views)
Permalink

[issue6382] test_socketserver fails on trunk in test_ForkingTCPServer [In reply to]

R. David Murray <rdmurray[at]bitdance.com> added the comment:

I had to fix one line, but after that it runs successfully. Updated
patch attached. The change is to add the 'request' argument to the
close_request call on line 549.

----------
keywords: +patch
Added file: http://bugs.python.org/file14465/issue6382.patch

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue6382>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 7, 2009, 2:09 AM

Post #8 of 8 (150 views)
Permalink

[issue6382] test_socketserver fails on trunk in test_ForkingTCPServer [In reply to]

Kristján Valur Jónsson <kristjan[at]ccpgames.com> added the comment:

committed in revision 73877 and revision 73878

----------

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue6382>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com