Mailing List Archive: Python: Bugs

[issue2849] Remove usage of rfc822 from the stdlib

Index | Next | Previous | View Threaded

report at bugs

May 13, 2008, 6:02 PM

Post #1 of 14 (290 views)
Permalink

[issue2849] Remove usage of rfc822 from the stdlib

New submission from Brett Cannon <brett[at]python.org>:

The rfc822 module has been deprecated for a while but is still used in the
stdlib (at least in 'cgi' and 'test_urllib2'). All uses need to go before
the module can be removed.

----------
components: Library (Lib)
messages: 66810
nosy: brett.cannon
priority: critical
severity: normal
status: open
title: Remove usage of rfc822 from the stdlib
type: behavior
versions: Python 2.6, Python 3.0

__________________________________
Tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue2849>
__________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 15, 2008, 9:43 PM

Post #2 of 14 (280 views)
Permalink

[issue2849] Remove usage of rfc822 from the stdlib [In reply to]

Changes by Brett Cannon <brett[at]python.org>:

----------
priority: critical -> release blocker

__________________________________
Tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue2849>
__________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 18, 2008, 10:34 PM

Post #3 of 14 (272 views)
Permalink

[issue2849] Remove usage of rfc822 from the stdlib [In reply to]

Humberto Diogenes <humberto[at]digi.com.br> added the comment:

A quick search for rfc822 imports in py3k reveals this:

$ find . -name '*.py' | xargs egrep -nr '(from|import) rfc822'
./Demo/scripts/mboxconvert.py:7:import rfc822
./Lib/cgi.py:39:import rfc822
./Lib/mimetools.py:5:import rfc822
./Lib/test/test_rfc822.py:1:import rfc822
./Lib/test/test_urllib2.py:587: import rfc822, socket
./Tools/faqwiz/faqwiz.py:210: import rfc822
./Tools/scripts/mailerdaemon.py:3:import rfc822
./Tools/versioncheck/pyversioncheck.py:2:import rfc822

The real "release blockers" should be cgi, mimetools and test_urllib2.

----------
nosy: +hdiogenes

__________________________________
Tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue2849>
__________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 18, 2008, 11:00 PM

Post #4 of 14 (269 views)
Permalink

[issue2849] Remove usage of rfc822 from the stdlib [In reply to]

Humberto Diogenes <humberto[at]digi.com.br> added the comment:

Correction: mimetools is also being removed from py3k (issue 2848).

__________________________________
Tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue2849>
__________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 18, 2008, 11:36 PM

Post #5 of 14 (271 views)
Permalink

[issue2849] Remove usage of rfc822 from the stdlib [In reply to]

Changes by Humberto Diogenes <humberto[at]digi.com.br>:

Added file: http://bugs.python.org/file10375/remove_rfc822-test_urllib2.py

__________________________________
Tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue2849>
__________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 19, 2008, 12:00 AM

Post #6 of 14 (272 views)
Permalink

[issue2849] Remove usage of rfc822 from the stdlib [In reply to]

Humberto Diogenes <humberto[at]digi.com.br> added the comment:

Tried to just replace rfc822.Message with email.message_from_file in
cgi.py but it didn't work. I still have to figure out how to fix
FieldStorage.read_multi.

Added file: http://bugs.python.org/file10376/remove_rfc822-cgi-incomplete.py

__________________________________
Tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue2849>
__________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

May 30, 2008, 11:51 PM

Post #7 of 14 (241 views)
Permalink

[issue2849] Remove usage of rfc822 from the stdlib [In reply to]

Humberto Diogenes <humberto[at]digi.com.br> added the comment:

Seems that removing rfc822 from `cgi` is not an easy task -- please see issue 1112856.

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue2849>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 1, 2008, 12:39 PM

Post #8 of 14 (229 views)
Permalink

[issue2849] Remove usage of rfc822 from the stdlib [In reply to]

Humberto Diogenes <humberto[at]digi.com.br> added the comment:

Added a patch that successfully removes rfc822 dependency from the cgi
module, using ideas from issue 1112856. I had to change one test, as the
email FeedParser ignores trailing spaces in subparts.

----------
keywords: +patch
Added file: http://bugs.python.org/file10494/remove_rfc822_from_cgi.patch

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue2849>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 1, 2008, 8:33 PM

Post #9 of 14 (226 views)
Permalink

[issue2849] Remove usage of rfc822 from the stdlib [In reply to]

Humberto Diogenes <humberto[at]digi.com.br> added the comment:

With the attached patches, rfc822 won't be used anywhere inside Lib/
anymore (with the exception of mimetools, which is going away too).

Is there any reason to convert the files below? Shouldn't they be removed
from 3.0?
Demo/scripts/mboxconvert.py -> superseded by mailbox.py
Tools/faqwiz/faqwiz.py -> really old (1998)
Tools/scripts/mailerdaemon.py -> still useful?
Tools/versioncheck/pyversioncheck.py -> really old (1997)

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue2849>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 2, 2008, 3:07 PM

Post #10 of 14 (226 views)
Permalink

[issue2849] Remove usage of rfc822 from the stdlib [In reply to]

Brett Cannon <brett[at]python.org> added the comment:

On Sun, Jun 1, 2008 at 8:33 PM, Humberto Diogenes
<report[at]bugs.python.org> wrote:
>
> Humberto Diogenes <humberto[at]digi.com.br> added the comment:
>
> With the attached patches, rfc822 won't be used anywhere inside Lib/
> anymore (with the exception of mimetools, which is going away too).
>
> Is there any reason to convert the files below? Shouldn't they be removed
> from 3.0?
> Demo/scripts/mboxconvert.py -> superseded by mailbox.py
> Tools/faqwiz/faqwiz.py -> really old (1998)
> Tools/scripts/mailerdaemon.py -> still useful?
> Tools/versioncheck/pyversioncheck.py -> really old (1997)
>

Probably. I bet both the Demo and Tools directory need a thorough clean-up.

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue2849>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 11, 2008, 7:43 PM

Post #11 of 14 (200 views)
Permalink

[issue2849] Remove usage of rfc822 from the stdlib [In reply to]

Barry A. Warsaw <barry[at]python.org> added the comment:

Reviewed and applied to Python 3.0 in r64161. The patch did not apply
cleanly for 2.6. I'm going to bump this down to critical for the first
betas. Humberto, can you back port it to Python 2.6?

----------
nosy: +barry
priority: release blocker -> critical

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue2849>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 12, 2008, 1:36 PM

Post #12 of 14 (198 views)
Permalink

[issue2849] Remove usage of rfc822 from the stdlib [In reply to]

Humberto Diogenes <humberto[at]digi.com.br> added the comment:

[msg68060]
>> Why does it need to be in 2.6? mimetools is still there.
>
> I guess you're right, it doesn't.

So, does it make sense to backport this too?

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue2849>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 12, 2008, 2:16 PM

Post #13 of 14 (198 views)
Permalink

[issue2849] Remove usage of rfc822 from the stdlib [In reply to]

Barry A. Warsaw <barry[at]python.org> added the comment:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Jun 12, 2008, at 4:36 PM, Humberto Diogenes wrote:

> Humberto Diogenes <humberto[at]digi.com.br> added the comment:
>
> [msg68060]
>>> Why does it need to be in 2.6? mimetools is still there.
>>
>> I guess you're right, it doesn't.
>
> So, does it make sense to backport this too?

No.

Thanks,
- -Barry

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)

iQCVAwUBSFGSL3EjvBPtnXfVAQLooAP+PQK6Q9p6lDbmLkBgbQio5CXdckssMMyI
yvj0DYvK5wBYCurCjOTZ5VFUQZTEloj6p/89qf3HScfUASlIie1vJJRUqCktPDLs
THBicAS9lUXWLhmrD6ADgaLN88JMlTGnzpe03vBpScgFfy3fp8QHBoMzjud38amn
ozB6lzB+mAQ=
=qHGu
-----END PGP SIGNATURE-----

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue2849>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jun 12, 2008, 3:16 PM

Post #14 of 14 (193 views)
Permalink

[issue2849] Remove usage of rfc822 from the stdlib [In reply to]

Benjamin Peterson <musiccomposition[at]gmail.com> added the comment:

I've removed the whole module in r64203.

----------
nosy: +benjamin.peterson
resolution: -> fixed
status: open -> closed

_______________________________________
Python tracker <report[at]bugs.python.org>
<http://bugs.python.org/issue2849>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com