report at bugs
Aug 12, 2013, 1:37 PM
Post #5 of 5
(8 views)
Permalink
|
|
[issue16799] start using argparse.Namespace in regrtest
[In reply to]
|
|
Eli Bendersky added the comment:
On Mon, Aug 12, 2013 at 1:33 PM, Eli Bendersky <report [at] bugs>wrote:
>
> Eli Bendersky added the comment:
>
> On Mon, Aug 12, 2013 at 12:41 PM, Serhiy Storchaka
> <report [at] bugs>wrote:
>
> >
> > Serhiy Storchaka added the comment:
> >
> > Here is a preliminary patch which get rids of
> > _convert_namespace_to_getopt() and directly uses a Namespace object.
> > Unfortunately it breaks tests because test_regrtest depends on
> > implementation details of the regrtest module and uses
> > _convert_namespace_to_getopt(). If the proposed patch is good enough I
> will
> > try to write suitable tests.
> >
>
> If test_regrtest is the only test broken by this, it doesn't like a major
> problem.
>
Something is wrong with the part of my brain that deals with grammar today;
sorry! What I mean to say, in case it's not obvious - is that if this
change breaks no tests except the one that specifically tests regrtest
itself, I don't think there's a reason to worry. test_regrtest can (and
should) be changed not to rely on internals of the module-under-test.
----------
_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue16799>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
|
