Mailing List Archive: Python: Bugs

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

Index | Next | Previous | View Threaded

report at bugs

Aug 20, 2012, 12:28 AM

Post #1 of 7 (157 views)
Permalink

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

danblack added the comment:

Antoine,

I copied off your http example for all the other protocols.

tested with:

import smtplib

a = smtplib.SMTP_SSL('gmail-smtp-in.l.google.com.')
a.starttls()

a = smtplib.SMTP_SSL('mail.internode.on.net')
a = smtplib.SMTP_SSL('smtp.gmail.com')

import ftplib
# http://secureftp-test.com/

f = ftplib.FTP_TLS('ftp.secureftp-test.com')
f.auth()

import imaplib
i = imaplib.IMAP4('calmail.berkley.edu')
i.starttls()

i = imaplib.IMAP4_SSL('mail.internode.on.net')

import poplib

p = poplib.POP3_SSL('calmail.berkley.edu')

import nntplib
n = nntplib.NNTP_SSL('news.internode.on.net')

I did a network capture and saw the hostname in the SNI header

----------
nosy: +daniel-black
Added file: http://bugs.python.org/file26918/issue_10852_pop-smtp-imap-nntp.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10852>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 21, 2012, 7:48 AM

Post #2 of 7 (145 views)
Permalink

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default [In reply to]

Changes by danblack <daniel.black [at] openquery>:

Removed file: http://bugs.python.org/file26918/issue_10852_pop-smtp-imap-nntp.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10852>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 21, 2012, 7:49 AM

Post #3 of 7 (145 views)
Permalink

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default [In reply to]

danblack added the comment:

previous patch had dumb error and even failed test suit. Now fixed.

----------
Added file: http://bugs.python.org/file26949/issue10852-sni.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10852>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 21, 2012, 7:55 AM

Post #4 of 7 (149 views)
Permalink

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default [In reply to]

Antoine Pitrou added the comment:

Thanks for the patch, Daniel. 3.3 is nearing the release candidate phase, so I'm re-targetting to 3.4. I'll take a detailed look soon.

(I suppose there's no easy way to write automated tests for this, unfortunately)

----------
stage: -> patch review
versions: +Python 3.4 -Python 3.3

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10852>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 21, 2012, 7:56 AM

Post #5 of 7 (145 views)
Permalink

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default [In reply to]

Antoine Pitrou added the comment:

By the way, could you sign a contributor agreement? You can find instructions at http://www.python.org/psf/contrib/

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10852>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 21, 2012, 8:03 AM

Post #6 of 7 (145 views)
Permalink

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default [In reply to]

Changes by R. David Murray <rdmurray [at] bitdance>:

----------
nosy: +r.david.murray

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10852>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 22, 2012, 12:48 AM

Post #7 of 7 (146 views)
Permalink

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default [In reply to]

danblack added the comment:

> Thanks for the patch
> Daniel. 3.3 is nearing the release candidate phase, so I'm re-targetting to 3.4. I'll take a detailed look soon.

Welcome. Just noticed conflicts with #4473 in the client POP implementation. Hopefully they are close anyway.

> (I suppose there's no easy way to write automated tests for this, unfortunately)
Well since #8109 writes the server SNI its getting easier.

In Lib/test/test_ssl.py combined with the changes of #8109 it would seem that changing ConnectionHandler.run to respond to "AUTH TLS", "AUTH SSL" (ftp) and "STLS" for pop (preempt #4473).

Changing server_params_test to support a proper arguments that correspond the the client protocol would be the way to do it.

> By the way, could you sign a contributor agreement
yes - emailed in.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue10852>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads