Mailing List Archive: Python: Bugs

[issue15502] Meta path finders and path entry finders are different, but share an ABC

1 2 3 4

View All

Index | Next | Previous | View Threaded

report at bugs

Aug 10, 2012, 8:25 AM

Post #76 of 83 (85 views)
Permalink

[issue15502] Meta path finders and path entry finders are different, but share an ABC [In reply to]

Nick Coghlan added the comment:

Oh, and +1 for Eric's "path-based finder". States clearly that it is a finder that *uses* import paths, rather than finding them.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15502>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 10, 2012, 8:33 AM

Post #77 of 83 (82 views)
Permalink

[issue15502] Meta path finders and path entry finders are different, but share an ABC [In reply to]

Brett Cannon added the comment:

Thanks for the review, Nick! I will get this patch committed sometime today with your comments integrated.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15502>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 10, 2012, 8:53 AM

Post #78 of 83 (88 views)
Permalink

[issue15502] Meta path finders and path entry finders are different, but share an ABC [In reply to]

Brett Cannon added the comment:

Actually there is one issue with PathEntryFinder inheriting from Finder; it doesn't need to implement find_module() if it doesn't want to in Python 3.3. So I will need to stick in a dummy find_module() on the class that calls find_loader() and then returns any found loader and tosses the namespace paths.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15502>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 10, 2012, 9:09 AM

Post #79 of 83 (86 views)
Permalink

[issue15502] Meta path finders and path entry finders are different, but share an ABC [In reply to]

Nick Coghlan added the comment:

Sounds good. Perhaps steal the impl from FileFinder.find_module (i.e. the one with the ImportWarning).

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15502>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 10, 2012, 9:21 AM

Post #80 of 83 (87 views)
Permalink

[issue15502] Meta path finders and path entry finders are different, but share an ABC [In reply to]

Roundup Robot added the comment:

New changeset 0a75ce232f56 by Brett Cannon in branch 'default':
Issue #15502: Finish bringing importlib.abc in line with the current
http://hg.python.org/cpython/rev/0a75ce232f56

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15502>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 10, 2012, 9:21 AM

Post #81 of 83 (85 views)
Permalink

[issue15502] Meta path finders and path entry finders are different, but share an ABC [In reply to]

Changes by Brett Cannon <brett [at] python>:

----------
assignee: -> brett.cannon
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -> closed

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15502>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 10, 2012, 10:22 AM

Post #82 of 83 (82 views)
Permalink

[issue15502] Meta path finders and path entry finders are different, but share an ABC [In reply to]

Brett Cannon added the comment:

I will go back and steal the FileFinder.find_module implementation after I finish the current patch I'm working on.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15502>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 10, 2012, 2:41 PM

Post #83 of 83 (87 views)
Permalink

[issue15502] Meta path finders and path entry finders are different, but share an ABC [In reply to]

Roundup Robot added the comment:

New changeset e7a67f1bf604 by Brett Cannon in branch 'default':
Issue #15502: Refactor some code.
http://hg.python.org/cpython/rev/e7a67f1bf604

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15502>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

1 2 3 4

View All

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads