Mailing List Archive: Python: Bugs

[issue15475] Correct sizeof support for itertools

Index | Next | Previous | View Threaded

report at bugs

Jul 27, 2012, 12:44 PM

Post #1 of 12 (138 views)
Permalink

[issue15475] Correct __sizeof__ support for itertools

New submission from Serhiy Storchaka <storchaka [at] gmail>:

Here is a patch that implements correct __sizeof__ for some itertools iterators: product(), combinations(), combinations_with_replacement() and permutations().

----------
components: Library (Lib)
files: itertools_sizeof-3.3.patch
keywords: patch
messages: 166603
nosy: rhettinger, storchaka
priority: normal
severity: normal
status: open
title: Correct __sizeof__ support for itertools
type: behavior
versions: Python 2.7, Python 3.2, Python 3.3
Added file: http://bugs.python.org/file26547/itertools_sizeof-3.3.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15475>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 27, 2012, 12:45 PM

Post #2 of 12 (134 views)
Permalink

[issue15475] Correct __sizeof__ support for itertools [In reply to]

Changes by Serhiy Storchaka <storchaka [at] gmail>:

Added file: http://bugs.python.org/file26548/itertools_sizeof-3.2.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15475>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 27, 2012, 12:46 PM

Post #3 of 12 (134 views)
Permalink

[issue15475] Correct __sizeof__ support for itertools [In reply to]

Changes by Serhiy Storchaka <storchaka [at] gmail>:

Added file: http://bugs.python.org/file26549/itertools_sizeof-2.7.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15475>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 28, 2012, 8:41 PM

Post #4 of 12 (130 views)
Permalink

[issue15475] Correct __sizeof__ support for itertools [In reply to]

Changes by Meador Inge <meadori [at] gmail>:

----------
nosy: +meador.inge

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15475>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 29, 2012, 9:11 AM

Post #5 of 12 (130 views)
Permalink

[issue15475] Correct __sizeof__ support for itertools [In reply to]

Serhiy Storchaka added the comment:

Patches updated on Meador's remarks. Tests updated to use new test.support helpers.

----------
Added file: http://bugs.python.org/file26576/itertools_sizeof-3.3-2.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15475>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 29, 2012, 9:12 AM

Post #6 of 12 (130 views)
Permalink

[issue15475] Correct __sizeof__ support for itertools [In reply to]

Changes by Serhiy Storchaka <storchaka [at] gmail>:

Added file: http://bugs.python.org/file26577/itertools_sizeof-3.2-2.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15475>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 29, 2012, 9:12 AM

Post #7 of 12 (129 views)
Permalink

[issue15475] Correct __sizeof__ support for itertools [In reply to]

Changes by Serhiy Storchaka <storchaka [at] gmail>:

Added file: http://bugs.python.org/file26578/itertools_sizeof-2.7-2.patch

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15475>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Jul 29, 2012, 9:13 AM

Post #8 of 12 (131 views)
Permalink

[issue15475] Correct __sizeof__ support for itertools [In reply to]

Serhiy Storchaka added the comment:

Sorry, on Martin's remarks.

----------

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15475>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 5, 2012, 3:58 AM

Post #9 of 12 (114 views)
Permalink

[issue15475] Correct __sizeof__ support for itertools [In reply to]

Changes by Serhiy Storchaka <storchaka [at] gmail>:

----------
keywords: +needs review
stage: -> patch review

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15475>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 8, 2012, 12:59 AM

Post #10 of 12 (103 views)
Permalink

[issue15475] Correct __sizeof__ support for itertools [In reply to]

Changes by Raymond Hettinger <raymond.hettinger [at] gmail>:

----------
assignee: -> rhettinger
priority: normal -> low

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15475>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 8, 2012, 3:41 AM

Post #11 of 12 (102 views)
Permalink

[issue15475] Correct __sizeof__ support for itertools [In reply to]

Raymond Hettinger added the comment:

The clean-up patch looks much nicer. Thanks.

I'm not sure why anyone would really want this functionality for itertools, but I don't see any harm in adding it as long as the other implementations aren't required to follow.

Also, it could be viewed as being a new feature, so I'm not sure backports are warranted. Be sure to ask the respective release managers before applying.

----------
assignee: rhettinger ->

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15475>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

report at bugs

Aug 8, 2012, 7:09 AM

Post #12 of 12 (105 views)
Permalink

[issue15475] Correct __sizeof__ support for itertools [In reply to]

Meador Inge added the comment:

On Wed, Aug 8, 2012 at 5:41 AM, Raymond Hettinger <report [at] bugs> wrote:

> I'm not sure why anyone would really want this functionality for itertools,
> but I don't see any harm in adding it as long as the other implementations
> aren't required to follow.

The general expection is that __sizeof__ is for CPython. We tag the tests
with '@cpython_only'.

> Also, it could be viewed as being a new feature, so I'm not sure backports
> are warranted.

So far, we have been applying the __sizeof__ patches to all branches.

> Be sure to ask the respective release managers before applying.

I will check with Georg for 3.3. Thanks.

----------
assignee: -> meador.inge

_______________________________________
Python tracker <report [at] bugs>
<http://bugs.python.org/issue15475>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads

[issue15475] Correct __sizeof__ support for itertools

[issue15475] Correct sizeof support for itertools