Mailing List Archive: Perl: porters

PATCH: Bump Locale-Codes from 3.21 to 3.22

Index | Next | Previous | View Threaded

sbeck at cpan

Jun 1, 2012, 4:12 AM

Post #1 of 4 (61 views)
Permalink

PATCH: Bump Locale-Codes from 3.21 to 3.22

I just released Locale-Codes-3.22 which contains the core modules
Locale::Country, Locale::Language, and Locale::Currency. The patch is
attached to this message.

====
Background:

The core modules Locale::Country, Locale::Language, and Locale::Currency
(all part of the Locale-Codes distribution) should be updated on a
regular basis. They contain "codes" from various internet standards
which change over time.

I plan on releasing new versions at 4 times a year to keep the codes
up-to-date. At this point, I'm not planning on any significant code
changes (other than bug fixes), so the only significant changes
between releases should be to update the codes.

Attachments:

0001-Bump-Locale-Codes-from-3.21-to-3.22.patch (64.3 KB)

chris at bingosnet

Jun 1, 2012, 5:16 AM

Post #2 of 4 (57 views)
Permalink

Re: PATCH: Bump Locale-Codes from 3.21 to 3.22 [In reply to]

On Fri, Jun 01, 2012 at 07:12:43AM -0400, Sullivan Beck wrote:
> I just released Locale-Codes-3.22 which contains the core modules
> Locale::Country, Locale::Language, and Locale::Currency. The patch
> is attached to this message.
>

I'm working through updating dual-life modules at the moment

I'll get this patch in whilst I am doing that work.

Many thanks,

--
Chris Williams
aka BinGOs
PGP ID 0x4658671F
http://www.gumbynet.org.uk
==========================

nick at ccl4

Jun 2, 2012, 8:54 AM

Post #3 of 4 (57 views)
Permalink

Re: PATCH: Bump Locale-Codes from 3.21 to 3.22 [In reply to]

On Fri, Jun 01, 2012 at 07:12:43AM -0400, Sullivan Beck wrote:
> I just released Locale-Codes-3.22 which contains the core modules
> Locale::Country, Locale::Language, and Locale::Currency. The patch is
> attached to this message.

I've applied this to blead as 75e3a58a54895854.

I noticed a couple of things in the patch. Firstly:

@@ -34,10 +34,11 @@ modify it under the same terms as Perl itself.

use strict;
use warnings;
+use utf8;
require 5.002;

our($VERSION);
-$VERSION='3.21';
+$VERSION='3.22';

$Locale::Codes::Data{'country'}{'id'} = '0282';

use utf8; isn't going to work as far back as 5.002 :-)
Presumably the require 5.002 should really be require 5.006; (or maybe later)
and most usefully would be immediately after use strict;
(as both warnings and utf8 date from 5.006)

Secondly:

@@ -93,9 +94,9 @@ $Locale::Codes::Retired{'country'}{'alpha-3'}{'code'} = {
$Locale::Codes::Retired{'country'}{'fips-10'}{'code'} = {
q(RN) => q(Saint Martin),
q(UC) => q(Curacao),
- q(RI) => q(Serbia),
- q(MJ) => q(Montenegro),
q(KV) => q(Kosovo),
+ q(MJ) => q(Montenegro),
+ q(RI) => q(Serbia),
q(TB) => q(Saint Barthelemy),
q(NN) => q(Sint Maarten),
};

There are a lot of diff hunks like this, where keys change order. It makes
it harder to spot what really changed. These files are all generated, aren't
they? Would it make sense to sort the keys for the generated output? I
realise that this will make 1 thunking great diff for the transition, but
after that one-off cost it should be much clearer.

Nicholas Clark

sbeck at cpan

Jun 4, 2012, 4:29 AM

Post #4 of 4 (53 views)
Permalink

Re: PATCH: Bump Locale-Codes from 3.21 to 3.22 [In reply to]

On 06/02/2012 11:54 AM, Nicholas Clark wrote:
> On Fri, Jun 01, 2012 at 07:12:43AM -0400, Sullivan Beck wrote:
>> I just released Locale-Codes-3.22 which contains the core modules
>> Locale::Country, Locale::Language, and Locale::Currency. The patch is
>> attached to this message.
> I've applied this to blead as 75e3a58a54895854.
>
> I noticed a couple of things in the patch. Firstly:
>
> @@ -34,10 +34,11 @@ modify it under the same terms as Perl itself.
>
> use strict;
> use warnings;
> +use utf8;
> require 5.002;
>
> our($VERSION);
> -$VERSION='3.21';
> +$VERSION='3.22';
>
> $Locale::Codes::Data{'country'}{'id'} = '0282';
>
>
> use utf8; isn't going to work as far back as 5.002 :-)
> Presumably the require 5.002 should really be require 5.006; (or maybe later)
> and most usefully would be immediately after use strict;
> (as both warnings and utf8 date from 5.006)

I'll change the 5.002. That actually dates back to the older version of
Locale::Codes and I've never changed it.

> Secondly:
>
> @@ -93,9 +94,9 @@ $Locale::Codes::Retired{'country'}{'alpha-3'}{'code'} = {
> $Locale::Codes::Retired{'country'}{'fips-10'}{'code'} = {
> q(RN) => q(Saint Martin),
> q(UC) => q(Curacao),
> - q(RI) => q(Serbia),
> - q(MJ) => q(Montenegro),
> q(KV) => q(Kosovo),
> + q(MJ) => q(Montenegro),
> + q(RI) => q(Serbia),
> q(TB) => q(Saint Barthelemy),
> q(NN) => q(Sint Maarten),
> };
>
>
> There are a lot of diff hunks like this, where keys change order. It makes
> it harder to spot what really changed. These files are all generated, aren't
> they? Would it make sense to sort the keys for the generated output? I
> realise that this will make 1 thunking great diff for the transition, but
> after that one-off cost it should be much clearer.
>
> Nicholas Clark

You are correct that they are all generated, and I thought they were all
sorted... but apparently I missed one somewhere. I'll investigate and
get it fixed for the next release.

Thanks

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads