Mailing List Archive: Perl: porters

[PATCH 0/3] Clean up installhtml dir scanning logic in installdir

Index | Next | Previous | View Threaded

pagaltzis at gmx

May 15, 2012, 9:59 AM

Post #1 of 8 (103 views)
Permalink

[PATCH 0/3] Clean up installhtml dir scanning logic in installdir

* Nicholas Clark <nick [at] ccl4> [2012-05-15 09:45]:
> On Tue, May 15, 2012 at 05:25:11AM +0200, Aristotle Pagaltzis wrote:
> > Shall I send the patch series?
> >
> > It does not fix the "doesn't look for any other kind of file" issue but
> > offers a much better starting point to anyone who wants to.
>
> Yes please, for exactly that reason - no-one else needs to have their
> eyes burnt by it.

Very well then.

Aristotle Pagaltzis (3):
switch installhtml from File::Spec to ::Functions
turn some quasi-declarations into real inline ones
rewrite installhtml's installdir dir scan logic

installhtml | 41 +++++++++++++++++++++--------------------
1 files changed, 21 insertions(+), 20 deletions(-)

--
1.7.4.1

sprout at cpan

May 26, 2012, 11:52 AM

Post #2 of 8 (96 views)
Permalink

Re: [PATCH 0/3] Clean up installhtml dir scanning logic in installdir [In reply to]

Aristotly Pagaltzis wrote:
> Aristotle Pagaltzis (3):
> switch installhtml from File::Spec to ::Functions
> turn some quasi-declarations into real inline ones
> rewrite installhtml's installdir dir scan logic
>
> installhtml | 41 +++++++++++++++++++++--------------------
> 1 files changed, 21 insertions(+), 20 deletions(-)

Thank you. Applied as:
b1124ff0a4329772bd7fea18b2433d6fa39caa3d
8de3880f558aa119a83ded6d8ccaaba20d587030
83c03aa3e02c6caf08cbd40cd0ac1f82ce181d81

In future, it would be easier (and your patches would have less
chance of being dropped) if you attached the output of "git log -p -3
--pretty=email --reverse" in an e-mail to perlbug [at] perl

pagaltzis at gmx

May 26, 2012, 11:37 PM

Post #3 of 8 (92 views)
Permalink

Re: [PATCH 0/3] Clean up installhtml dir scanning logic in installdir [In reply to]

* Father Chrysostomos <sprout [at] cpan> [2012-05-26 20:55]:
> In future, it would be easier (and your patches would have less
> chance of being dropped) if you attached the output of "git log
> -p -3 --pretty=email --reverse" in an e-mail to perlbug [at] perl

Will do. Patch mails do not automatically get added to the tracker
any more? (They used to, didn’t they?)

Regards,
--
Aristotle Pagaltzis // <http://plasmasturm.org/>

fraserbn at gmail

May 27, 2012, 4:05 PM

Post #4 of 8 (89 views)
Permalink

Re: [PATCH 0/3] Clean up installhtml dir scanning logic in installdir [In reply to]

On Sat, May 26, 2012 at 3:52 PM, Father Chrysostomos <sprout [at] cpan>wrote:

> Aristotly Pagaltzis wrote:
> > Aristotle Pagaltzis (3):
> > switch installhtml from File::Spec to ::Functions
> > turn some quasi-declarations into real inline ones
> > rewrite installhtml's installdir dir scan logic
> >
> > installhtml | 41 +++++++++++++++++++++--------------------
> > 1 files changed, 21 insertions(+), 20 deletions(-)
>
> Thank you. Applied as:
> b1124ff0a4329772bd7fea18b2433d6fa39caa3d
> 8de3880f558aa119a83ded6d8ccaaba20d587030
> 83c03aa3e02c6caf08cbd40cd0ac1f82ce181d81
>
> In future, it would be easier (and your patches would have less
> chance of being dropped) if you attached the output of "git log -p -3
> --pretty=email --reverse" in an e-mail to perlbug [at] perl
>
>
Meta question, but how is that different from 'git format-patch yadda'?

sprout at cpan

May 27, 2012, 5:59 PM

Post #5 of 8 (89 views)
Permalink

Re: [PATCH 0/3] Clean up installhtml dir scanning logic in installdir [In reply to]

On May 27, 2012, at 4:05 PM, Brian Fraser wrote:

>
>
> On Sat, May 26, 2012 at 3:52 PM, Father Chrysostomos <sprout [at] cpan> wrote:
> Aristotly Pagaltzis wrote:
> > Aristotle Pagaltzis (3):
> > switch installhtml from File::Spec to ::Functions
> > turn some quasi-declarations into real inline ones
> > rewrite installhtml's installdir dir scan logic
> >
> > installhtml | 41 +++++++++++++++++++++--------------------
> > 1 files changed, 21 insertions(+), 20 deletions(-)
>
> Thank you. Applied as:
> b1124ff0a4329772bd7fea18b2433d6fa39caa3d
> 8de3880f558aa119a83ded6d8ccaaba20d587030
> 83c03aa3e02c6caf08cbd40cd0ac1f82ce181d81
>
> In future, it would be easier (and your patches would have less
> chance of being dropped) if you attached the output of "git log -p -3
> --pretty=email --reverse" in an e-mail to perlbug [at] perl
>
>
> Meta question, but how is that different from 'git format-patch yadda'?

Not much. It�s all in one file, so it only has to be fed to git am once. Maybe format-patch can do that, but I haven�t figured it out yet.

pagaltzis at gmx

May 28, 2012, 12:56 AM

Post #6 of 8 (92 views)
Permalink

Re: [PATCH 0/3] Clean up installhtml dir scanning logic in installdir [In reply to]

* Father Chrysostomos <sprout [at] cpan> [2012-05-28 03:50]:
> Not much. It’s all in one file, so it only has to be fed to git am
> once. Maybe format-patch can do that, but I haven’t figured it out
> yet.

Oh, I thought you just wanted that as a summary.

So how come perlhack instructs to submit patches using format-patch if
we the porters don’t actually want format-patch mails?

Regards,
--
Aristotle Pagaltzis // <http://plasmasturm.org/>

pagaltzis at gmx

May 28, 2012, 2:43 AM

Post #7 of 8 (91 views)
Permalink

Re: [PATCH 0/3] Clean up installhtml dir scanning logic in installdir [In reply to]

* Aristotle Pagaltzis <pagaltzis [at] gmx> [2012-05-28 10:00]:
> we the porters don’t actually want format-patch mails?
^^^^^^^^^^^^^^
Awkward edit-o, sorry.

sprout at cpan

May 28, 2012, 9:26 AM

Post #8 of 8 (92 views)
Permalink

Re: [PATCH 0/3] Clean up installhtml dir scanning logic in installdir [In reply to]

Aristotle asked:
> Oh, I thought you just wanted that as a summary.
>
> So how come perlhack instructs to submit patches using format-patch if
> we the porters don?t actually want format-patch mails?

format-patch is fine. If you are sending a series of patches, it is
*slightly* more convenient if they are in one file.

I have just discovered that "git format-patch --stdout" does the same
thing as "git log -p --reverse --pretty=email".

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads