perlbug-followup at perl
Apr 29, 2012, 6:30 PM
Views: 162
Permalink
|
On Sun Apr 29 10:53:12 2012, sprout wrote:
>
> Instead of giving another armchair response, I thought I’d better
> actually run some tests. :-)
>
> You’ll notice that lock_ref_keys does Internals::SvREADONLY(%$hash),
> while the two problematic functions do Internals::SvREADONLY($hash).
> *That’s* the problem. It was checking to see whether the $hash scalar
> was read-only.
>
Ah! The power of multiple application of multiple eyeballs!
> See the attached diff, which is against the 112126/sprout branch in your
> repository.
>
Yes, that resolved the problem. I applied your patch to that branch,
tested it, merged it into that repository's master, tested again, then
manually applied the patches to my local branch of blead.
I believe that if you apply the patch attached,
0001-Document-hashref_locked-and-hashref_unlocked-.-Add-t.patch, in
addition to the patch I submitted on Apr 22, you should get a better
ext/Hash-Util/lib/Hash/Util.pm as well as an ext/Hash-Util/t/Util.t that
provides 100% statement coverge of that package.
Thank you very much.
Jim Keenan
---
via perlbug: queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=112126
|
0001-Document-hashref_locked-and-hashref_unlocked-.-Add-t.patch
