Mailing List Archive: Perl: porters

-Dmad minitest failure bisect

Index | Next | Previous | View Threaded

tony at develop-help

Nov 25, 2009, 8:50 AM

Post #1 of 7 (348 views)
Permalink

-Dmad minitest failure bisect

Smokes with -Dmad have been failing during make minitest since the
middle of last month.

git bisect with script:

git clean -xfd
./Configure -Dmad -Dusedevel -des && make miniperl && ./miniperl -Ilib t/base/lex.t || exit 1
exit 0

tony [at] mar:.../git/perl$ git bisect start HEAD 5376f8ad7c939ed48eea4c831c7fab052358c462
Bisecting: 81 revisions left to test after this
[1fc7262d227d94438986ab803a17938da27ab057] Fill in some details about the release
You have new mail in /var/mail/tony
tony [at] mar:.../git/perl$ git bisect run ../mad-bisect.sh
(lots of build removed)
f0e67a1d29102aa9905aecf2b0f98449697d5af3 is first bad commit
commit f0e67a1d29102aa9905aecf2b0f98449697d5af3
Author: Zefram <zefram [at] fysh>
Date: Sun Nov 15 14:25:50 2009 +0100

lexer API

Attached is a patch that adds a public API for the lowest layers of
lexing. This is meant to provide a solid foundation for the parsing that
Devel::Declare and similar modules do, and it complements the pluggable
keyword mechanism. The API consists of some existing variables combined
with some new functions, all marked as experimental (which making them
public certainly is).

:100644 100644 22db6a3c9011829aff5176a7bacd4373f9c1d354 b8073eb771a2c615c876970bc1883bd4316cc88c M MANIFEST
:100644 100644 7522055a288adf11291c654a30726bd618c11f25 f17f7ada0a8c023af12e8aa9b7800f9ccf643df5 M embed.fnc
:100644 100644 52e40c6fa2f68c4c009a83d7669522543a9baad1 17bf11a5139254f0a5f6a46473bb136d1c145259 M embed.h
:040000 040000 23226494a6184590278d718527f383b69fff2cf3 6ebec696e22c1a6f7b1b4043db5a090006e9f1b1 M ext
:100644 100644 6000af755912fcd939cbe94d4662c54dd42acd5b 6a44049c4e4262b09ae4c5a0d2fd2d9749f12189 M global.sym
:100644 100644 74d8ef2197b15a99ce10a233a2f829c286043022 462dcfdef806826927c7e9c5261e46e57033960c M parser.h
:100644 100644 3639bd6ac0f26afd8537e3e9722382c2ba5beea2 3d378917c94e26aa9a550c181fdd824d6aad2e60 M perlvars.h
:040000 040000 79cfd550ba3c1ee290da3a30115bcade3d31effb 4de6df320a87c92b6db4c4df6a5b3cbace2d96bb M pod
:100644 100644 f1ab3d022e76840708a2367ea74a652b299bd6f1 fd2eb36cd42cecae815240f00f301038d0aba9fc M proto.h
:100644 100644 b8abbd854f001057679312ed03b534e0853cf490 6793f7b8669efb9df31731d9eff7507d6672c9b6 M toke.c
bisect run success
You have new mail in /var/mail/tony
tony [at] mar:.../git/perl$

tony at develop-help

Nov 25, 2009, 9:01 AM

Post #2 of 7 (323 views)
Permalink

Re: -Dmad minitest failure bisect [In reply to]

On Thu, Nov 26, 2009 at 03:50:54AM +1100, Tony Cook wrote:
> Smokes with -Dmad have been failing during make minitest since the
> middle of last month.

Urr, the middle of this month.

The problem with trying to be productive with insomnia...

Tony

zefram at fysh

Nov 25, 2009, 2:25 PM

Post #3 of 7 (322 views)
Permalink

Re: -Dmad minitest failure bisect [In reply to]

Tony Cook wrote:
>Smokes with -Dmad have been failing during make minitest since the

That'll be me again. I'll look into it.

-zefram

zefram at fysh

Nov 26, 2009, 7:19 AM

Post #4 of 7 (314 views)
Permalink

Re: -Dmad minitest failure bisect [In reply to]

Tony Cook wrote:
>Smokes with -Dmad have been failing during make minitest since the
>middle of last month.

Mostly fixed by the attached patch. The fault is a logic error on my
part, probably from the early phase of developing the lexer API patch,
when I didn't properly understand the various buffer pointer variables.

In my tests with -Dmad, I'm still getting a test failure ("panic: input
overflow") from t/op/incfilter.t. The underlying problem is the filter
layer mishandling things when a filter function gives it a multiline
string, so it generates an invalid SV state (strlen(SvPVX(PL_linestr))
> SvCUR(PL_linestr)). This faulty state also occurs without -Dmad,
and so doesn't appear to be Mad-related, it just doesn't in practice
cause the test panic without -Dmad. I'm investigating this bug now.

-zefram

Attachments:

d2 (0.40 KB)

h.m.brand at xs4all

Nov 26, 2009, 7:46 AM

Post #5 of 7 (316 views)
Permalink

Re: -Dmad minitest failure bisect [In reply to]

On Thu, 26 Nov 2009 15:19:09 +0000, Zefram <zefram [at] fysh> wrote:

> Tony Cook wrote:
> >Smokes with -Dmad have been failing during make minitest since the
> >middle of last month.

Applying: -Dmad minitest failure bisect
Thanks, patch successfully applied as 9735c8aa020a58992ffadba440014d200222da56

> Mostly fixed by the attached patch. The fault is a logic error on my
> part, probably from the early phase of developing the lexer API patch,
> when I didn't properly understand the various buffer pointer variables.
>
> In my tests with -Dmad, I'm still getting a test failure ("panic: input
> overflow") from t/op/incfilter.t. The underlying problem is the filter
> layer mishandling things when a filter function gives it a multiline
> string, so it generates an invalid SV state (strlen(SvPVX(PL_linestr))
> > SvCUR(PL_linestr)). This faulty state also occurs without -Dmad,
> and so doesn't appear to be Mad-related, it just doesn't in practice
> cause the test panic without -Dmad. I'm investigating this bug now.
>
> -zefram

--
H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/
using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,
11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3.
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/
http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

zefram at fysh

Nov 26, 2009, 8:41 AM

Post #6 of 7 (320 views)
Permalink

Re: -Dmad minitest failure bisect [In reply to]

I wrote:
>In my tests with -Dmad, I'm still getting a test failure ("panic: input
>overflow") from t/op/incfilter.t. The underlying problem is the filter
>layer mishandling things when a filter function gives it a multiline
>string, so it generates an invalid SV state (strlen(SvPVX(PL_linestr))
>> SvCUR(PL_linestr)). This faulty state also occurs without -Dmad,
>and so doesn't appear to be Mad-related, it just doesn't in practice
>cause the test panic without -Dmad. I'm investigating this bug now.

It's fixed by the attached patch. Since the bug is an inconsistency
in the SV data structure, it can't be sensibly tested from Perl code,
so I'm at a loss for writing a test script. Hopefully that panic with
-Dmad is sufficient.

-zefram

Attachments:

d3 (1.03 KB)

h.m.brand at xs4all

Nov 26, 2009, 8:54 AM

Post #7 of 7 (315 views)
Permalink

Re: -Dmad minitest failure bisect [In reply to]

On Thu, 26 Nov 2009 16:41:22 +0000, Zefram <zefram [at] fysh> wrote:

> I wrote:
> >In my tests with -Dmad, I'm still getting a test failure ("panic: input
> >overflow") from t/op/incfilter.t. The underlying problem is the filter
> >layer mishandling things when a filter function gives it a multiline
> >string, so it generates an invalid SV state (strlen(SvPVX(PL_linestr))
> >> SvCUR(PL_linestr)). This faulty state also occurs without -Dmad,
> >and so doesn't appear to be Mad-related, it just doesn't in practice
> >cause the test panic without -Dmad. I'm investigating this bug now.

Applying: -Dmad minitest failure bisect
Thanks, patch successfully applied as 162177c1aed1991639f7f0da64e918c034e1148a

> It's fixed by the attached patch. Since the bug is an inconsistency
> in the SV data structure, it can't be sensibly tested from Perl code,
> so I'm at a loss for writing a test script. Hopefully that panic with
> -Dmad is sufficient.
>
> -zefram

--
H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/
using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,
11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3.
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/
http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads