davidnicol at gmail
Dec 6, 2009, 12:42 AM
Post #2 of 2
(181 views)
Permalink
|
|
Re: [perl #70836] nested heredoc gets bad error message
[In reply to]
|
|
that patch will probably break the heredoc with no lf at end of file
patches. Which are totally stalled. Please feel free to take them
over.
http://tipjar.com/perlhacking/heredocpatch_revised.txt
On Thu, Nov 26, 2009 at 5:22 AM, Zefram <perlbug-followup [at] perl> wrote:
> # New Ticket Created by Zefram
> # Please include the string: [perl #70836]
> # in the subject line of all future correspondence about this issue.
> # <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=70836 >
>
>
>
> This is a bug report for perl from zefram [at] fysh,
> generated with the help of perlbug 1.36 running under perl 5.10.0.
>
>
> -----------------------------------------------------------------
> [Please enter your report here]
>
> Found this behaviour while investigating the current -Dmad failure:
>
> $ perl -e $'print <<E1;\n@{[ <<E2 ]}\nE1'
> Can't find string terminator "
> E2" anywhere before EOF at -e line 1.
>
> Not a great error message. The prefix newline comes from the inner
> workings of scan_heredoc: it's correct for it to be in PL_tokenbuf,
> but it shouldn't go through to the error message. This patch fixes it:
>
> PATCH
> --- a/toke.c
> +++ b/toke.c
> @@ -560,8 +560,10 @@ S_missingterm(pTHX_ char *s)
> char tmpbuf[3];
> char q;
> if (s) {
> - char * const nl = strrchr(s,'\n');
> - if (nl)
> + char *nl;
> + if (*s == '\n')
> + s++;
> + if ((nl = strrchr(s,'\n')))
> *nl = '\0';
> }
> else if (isCNTRL(PL_multi_close)) {
> PATCH
>
> [Please do not change anything below this line]
> -----------------------------------------------------------------
> ---
> Flags:
> category=core
> severity=low
> ---
> Site configuration information for perl 5.10.0:
>
> Configured by Debian Project at Fri Aug 28 22:30:10 UTC 2009.
>
> Summary of my perl5 (revision 5 version 10 subversion 0) configuration:
> Platform:
> osname=linux, osvers=2.6.26-2-amd64, archname=i486-linux-gnu-thread-multi
> uname='linux puccini 2.6.26-2-amd64 #1 smp fri aug 14 07:12:04 utc 2009 i686 gnulinux '
> config_args='-Dusethreads -Duselargefiles -Dccflags=-DDEBIAN -Dcccdlflags=-fPIC -Darchname=i486-linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.10 -Darchlib=/usr/lib/perl/5.10 -Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/perl5 -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl/5.10.0 -Dsitearch=/usr/local/lib/perl/5.10.0 -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio -Uusenm -DDEBUGGING=-g -Doptimize=-O2 -Duseshrplib -Dlibperl=libperl.so.5.10.0 -Dd_dosuid -des'
> hint=recommended, useposix=true, d_sigaction=define
> useithreads=define, usemultiplicity=define
> useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
> use64bitint=undef, use64bitall=undef, uselongdouble=undef
> usemymalloc=n, bincompat5005=undef
> Compiler:
> cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
> optimize='-O2 -g',
> cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -I/usr/local/include'
> ccversion='', gccversion='4.3.2', gccosandvers=''
> intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
> d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
> ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
> alignbytes=4, prototype=define
> Linker and Libraries:
> ld='cc', ldflags =' -L/usr/local/lib'
> libpth=/usr/local/lib /lib /usr/lib /usr/lib64
> libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt
> perllibs=-ldl -lm -lpthread -lc -lcrypt
> libc=/lib/libc-2.7.so, so=so, useshrplib=true, libperl=libperl.so.5.10.0
> gnulibc_version='2.7'
> Dynamic Linking:
> dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
> cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib'
>
> Locally applied patches:
>
>
> ---
> @INC for perl 5.10.0:
> /etc/perl
> /usr/local/lib/perl/5.10.0
> /usr/local/share/perl/5.10.0
> /usr/lib/perl5
> /usr/share/perl5
> /usr/lib/perl/5.10
> /usr/share/perl/5.10
> /usr/local/lib/site_perl
> .
>
> ---
> Environment for perl 5.10.0:
> HOME=/home/zefram
> LANG (unset)
> LANGUAGE (unset)
> LD_LIBRARY_PATH (unset)
> LOGDIR (unset)
> PATH=/home/zefram/pub/i686-pc-linux-gnu/bin:/home/zefram/pub/common/bin:/usr/bin:/usr/X11R6/bin:/bin:/usr/local/bin:/usr/games
> PERL_BADLANG (unset)
> SHELL=/usr/bin/zsh
>
>
--
"The new device will also be available in blue." -- http://➡.ws/瀲ു
|
