Mailing List Archive: Perl: porters

[ patch for 5.12 ] mark get_arena() as Maychange

Index | Next | Previous | View Threaded

jim.cromie at gmail

Nov 23, 2009, 12:35 PM

Post #1 of 5 (305 views)
Permalink

[ patch for 5.12 ] mark get_arena() as Maychange

this patch fixes get-arenas param names to reflect actual use,
and marks call with 'M' for maychange.
it needs make regen.

I checked in proto.h - git let me, cuz its not in .gitignore,
this surprised me mildly, since its generated output,
but its also a tracked file.

wrt submitted patches, I presume you prefer such files to be included
in commits,
as reflective of at least some testing ? ;-)

wrt May Change
The change I envision is adding a NN void* reqid,
which would allow get_arena to track individual consumers of
the arenas it serves up.

ATM those consumers are just the ~16 svtype bodies.

jesse at fsck

Nov 23, 2009, 1:10 PM

Post #2 of 5 (288 views)
Permalink

Re: [ patch for 5.12 ] mark get_arena() as Maychange [In reply to]

On Mon, Nov 23, 2009 at 01:35:38PM -0700, Jim Cromie wrote:
> this patch fixes get-arenas param names to reflect actual use,

Can you send along the patch?

> and marks call with 'M' for maychange.
> it needs make regen.
>
> I checked in proto.h - git let me, cuz its not in .gitignore,
> this surprised me mildly, since its generated output,
> but its also a tracked file.
>
> wrt submitted patches, I presume you prefer such files to be included
> in commits,
> as reflective of at least some testing ? ;-)

I'd actually prefer the patch to be minimal but with a note saying that
the generated file needs to be regenerated.

> wrt May Change
> The change I envision is adding a NN void* reqid,
> which would allow get_arena to track individual consumers of
> the arenas it serves up.
>
> ATM those consumers are just the ~16 svtype bodies.
>

--

jim.cromie at gmail

Nov 23, 2009, 1:34 PM

Post #3 of 5 (287 views)
Permalink

Re: [ patch for 5.12 ] mark get_arena() as Maychange [In reply to]

On Mon, Nov 23, 2009 at 2:10 PM, jesse <jesse [at] fsck> wrote:
>
>
>
> On Mon, Nov 23, 2009 at 01:35:38PM -0700, Jim Cromie wrote:
>> this patch fixes get-arenas param names to reflect actual use,
>
> Can you send along the patch?

oof. I hate it when I do that.

>
>> and marks call with 'M' for maychange.
>> it needs make regen.
>>
>> I checked in proto.h - git let me, cuz its not in .gitignore,
>> this surprised me mildly, since its generated output,
>> but its also a tracked file.
>>
>> wrt submitted patches, I presume you prefer such files to be included
>> in commits,
>> as reflective of at least some testing ? ;-)
>
> I'd actually prefer the patch to be minimal but with a note saying that
> the generated file needs to be regenerated.

uhm, Im now having trouble removing it from my commit.
sending old patch in meantime.

>
>
>> wrt May Change
>> The change I envision is adding a NN void* reqid,
>> which would allow get_arena to track individual consumers of
>> the arenas it serves up.
>>
>> ATM those consumers are just the ~16 svtype bodies.
>>
>
> --
>

Attachments:

0001-deobfuscate-args-to-get_arena-mark-as-Maychange.patch (3.12 KB)

jim.cromie at gmail

Nov 23, 2009, 2:12 PM

Post #4 of 5 (287 views)
Permalink

Re: [ patch for 5.12 ] mark get_arena() as Maychange [In reply to]

heres a clean one, without proto.h
git help rebase and /SPLITTING COMMITS/ clarified it,

it does however mention adding reqid param,
which might be over-selling ;-)

Attachments:

0001-cleanup-get_arena-param-names-mark-as-May-Change.patch (1.89 KB)

rgs at consttype

Nov 24, 2009, 2:05 AM

Post #5 of 5 (275 views)
Permalink

Re: [ patch for 5.12 ] mark get_arena() as Maychange [In reply to]

2009/11/23 Jim Cromie <jim.cromie [at] gmail>:
> heres a clean one, without proto.h
> git help rebase and /SPLITTING COMMITS/ clarified it,
>
> it does however mention adding �reqid param,
> which might be over-selling ;-)

Thanks, applied.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads