Mailing List Archive: Perl: porters

[PATCH] fix logic for a workaround in POSIX.xs

Index | Next | Previous | View Threaded

skasal at redhat

Nov 18, 2009, 9:13 AM

Post #1 of 2 (228 views)
Permalink

[PATCH] fix logic for a workaround in POSIX.xs

Hello,
I noticed a mistake in POSIX.xs.
There is the assignment "RETVAL = 0" to silence the compiler in case
it incorrectly reports return of an undefined value.
This assignment should be present whenever *any* of the symbols is
not defined. But the code was written so that the assignment was
compiled only when *none* of the symbols was defined.

I decided to remove the outer brace; I think the mistake proves that
the conditions is more readable when expanded.

Have a nice day,
Stepan Kasal

Attachments:

perl-posix-xs.patch (0.76 KB)

rgs at consttype

Nov 23, 2009, 3:14 AM

Post #2 of 2 (181 views)
Permalink

Re: [PATCH] fix logic for a workaround in POSIX.xs [In reply to]

2009/11/18 Stepan Kasal <skasal [at] redhat>:
> Hello,
> I noticed a mistake in POSIX.xs.
> There is the assignment "RETVAL = 0" to silence the compiler in case
> it incorrectly reports return of an undefined value.
> This assignment should be present whenever *any* of the symbols is
> not defined. But the code was written so that the assignment was
> compiled only when *none* of the symbols was defined.

Thanks, applied as fabb67aac748c1bf94bbc4a173a67dbd9a00b4df to bleadperl.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads