Mailing List Archive: Perl: porters

Re: [perl.git] branch blead, updated. v5.11.1-217-gf0e67a1

Index | Next | Previous | View Threaded

nick at ccl4

Nov 15, 2009, 7:52 AM

Post #1 of 3 (264 views)
Permalink

Re: [perl.git] branch blead, updated. v5.11.1-217-gf0e67a1

On Sun, Nov 15, 2009 at 04:14:19PM +0100, Rafael Garcia-Suarez wrote:
> In perl.git, the branch blead has been updated
>
> <http://perl5.git.perl.org/perl.git/commitdiff/f0e67a1d29102aa9905aecf2b0f98449697d5af3?hp=59cfed7d3d8869650cb695575c07168f937381f0>
>
> - Log -----------------------------------------------------------------
> commit f0e67a1d29102aa9905aecf2b0f98449697d5af3
> Author: Zefram <zefram [at] fysh>
> Date: Sun Nov 15 14:25:50 2009 +0100
>
> lexer API
>
> Attached is a patch that adds a public API for the lowest layers of
> lexing. This is meant to provide a solid foundation for the parsing that
> Devel::Declare and similar modules do, and it complements the pluggable
> keyword mechanism. The API consists of some existing variables combined
> with some new functions, all marked as experimental (which making them
> public certainly is).

As they're experimental, shouldn't all these be flagged as 'M'?

> +: Public lexer API
> +Apd |bool |lex_bufutf8
> +Apd |char* |lex_grow_linestr|STRLEN len
> +Apd |void |lex_stuff_pvn |NN char* pv|STRLEN len|U32 flags
> +Apd |void |lex_stuff_sv |NN SV* sv|U32 flags
> +Apd |void |lex_unstuff |NN char* ptr
> +Apd |void |lex_read_to |NN char* ptr
> +Apd |void |lex_discard_to |NN char* ptr
> +Apd |bool |lex_next_chunk |U32 flags
> +Apd |I32 |lex_peek_unichar|U32 flags
> +Apd |I32 |lex_read_unichar|U32 flags
> +Apd |void |lex_read_space |U32 flags

Actually, shouldn't embed.fnc gain another flag to directly mean "Experimental"
and ensure that generated documentation makes this clear?

Upper case 'E' is gone, but lowercase 'e' is free.
(Alternatively, we could rename existing 'E' to 'e' to give us E for this.)

Nicholas Clark

zefram at fysh

Nov 16, 2009, 4:31 AM

Post #2 of 3 (239 views)
Permalink

Re: [perl.git] branch blead, updated. v5.11.1-217-gf0e67a1 [In reply to]

Nicholas Clark wrote:
>As they're experimental, shouldn't all these be flagged as 'M'?

Maybe. What does it affect? I interpreted "may change" as a weaker form
of "experimental", but I don't see why that flag would be in embed.fnc.

>Actually, shouldn't embed.fnc gain another flag to directly mean "Experimental"
>and ensure that generated documentation makes this clear?

That job belongs with autodoc.pl, which already has such a flag.
That flag set could do with better documentation, though.

-zefram

nick at ccl4

Nov 16, 2009, 5:59 AM

Post #3 of 3 (236 views)
Permalink

Re: [perl.git] branch blead, updated. v5.11.1-217-gf0e67a1 [In reply to]

On Mon, Nov 16, 2009 at 12:31:43PM +0000, Zefram wrote:
> Nicholas Clark wrote:
> >As they're experimental, shouldn't all these be flagged as 'M'?
>
> Maybe. What does it affect? I interpreted "may change" as a weaker form
> of "experimental", but I don't see why that flag would be in embed.fnc.
>
> >Actually, shouldn't embed.fnc gain another flag to directly mean "Experimental"
> >and ensure that generated documentation makes this clear?
>
> That job belongs with autodoc.pl, which already has such a flag.
> That flag set could do with better documentation, though.

Yuck. autodoc.pl has a whole set of flags that don't even seem to be
*documented* anywhere. You have to read its code.

So we have two disjoint sets of flags controlling the state of the API (or not)
functions. That feels like one more place than it should be.

Given that autodoc.pl *already* opens embed.fnc, it can already (also) read
flags from there. I'd be much happier with the linkage/visibility/policy
flags in *one* place.

Nicholas Clark

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads