Mailing List Archive: Perl: porters

[Patch] adding 'always' option to cpan(1) prerequisite module prompt

Index | Next | Previous | View Threaded

alfie at h4c

Nov 13, 2009, 9:32 PM

Post #1 of 7 (406 views)
Permalink

[Patch] adding 'always' option to cpan(1) prerequisite module prompt

Hi guys,

I installed CHI the other day and got really annoyed by the countless
prerequisite module prompts i.e:

'Shall I follow them and prepend them to the queue...'

After thinking "man I wish this was fixed in perl", I decided to get off
my ass and submit a patch :)

http://github.com/alfie/perl/tree/cpan_always
git [at] github:alfie/perl.git branch cpan_always

Alfie

pagaltzis at gmx

Nov 14, 2009, 1:56 AM

Post #2 of 7 (383 views)
Permalink

Re: [Patch] adding 'always' option to cpan(1) prerequisite module prompt [In reply to]

Hi Alfie,

* Alfie John <alfie [at] h4c> [2009-11-14 06:35]:
> I installed CHI the other day and got really annoyed by the
> countless prerequisite module prompts i.e:
>
> 'Shall I follow them and prepend them to the queue...'
>
> After thinking "man I wish this was fixed in perl", I decided
> to get off my ass and submit a patch :)
>
> http://github.com/alfie/perl/tree/cpan_always
> git [at] github:alfie/perl.git branch cpan_always

did you miss `o conf prerequisites_policy follow`, or did I miss
something and your patch does something else?

Regards,
--
Aristotle Pagaltzis // <http://plasmasturm.org/>

paul at pjcj

Nov 14, 2009, 2:22 AM

Post #3 of 7 (379 views)
Permalink

Re: [Patch] adding 'always' option to cpan(1) prerequisite module prompt [In reply to]

On Sat, Nov 14, 2009 at 10:56:11AM +0100, Aristotle Pagaltzis wrote:
> Hi Alfie,
>
> * Alfie John <alfie [at] h4c> [2009-11-14 06:35]:
> > I installed CHI the other day and got really annoyed by the
> > countless prerequisite module prompts i.e:
> >
> > 'Shall I follow them and prepend them to the queue...'
> >
> > After thinking "man I wish this was fixed in perl", I decided
> > to get off my ass and submit a patch :)
> >
> > http://github.com/alfie/perl/tree/cpan_always
> > git [at] github:alfie/perl.git branch cpan_always
>
> did you miss `o conf prerequisites_policy follow`, or did I miss
> something and your patch does something else?

Well, it seems to be useful for the times when you wish you had already
done "o conf prerequisites_policy follow" or you want to follow
temporarily.

FWIW I lke the idea, but I suspect the patch should probably have gone
to Andreas König <andk [at] cpan> (see Porting/Maintainers.pl).

Thanks,

--
Paul Johnson - paul [at] pjcj
http://www.pjcj.net

alfie at h4c

Nov 14, 2009, 2:53 AM

Post #4 of 7 (378 views)
Permalink

Re: [Patch] adding 'always' option to cpan(1) prerequisite module prompt [In reply to]

Hey,

On Sat, November 14, 2009 9:22 pm, Paul Johnson wrote:
> On Sat, Nov 14, 2009 at 10:56:11AM +0100, Aristotle Pagaltzis wrote:
>> Hi Alfie,
>>
>> * Alfie John <alfie [at] h4c> [2009-11-14 06:35]:
>> > I installed CHI the other day and got really annoyed by the
>> > countless prerequisite module prompts i.e:
>> >
>> > 'Shall I follow them and prepend them to the queue...'
>> >
>> > After thinking "man I wish this was fixed in perl", I decided
>> > to get off my ass and submit a patch :)
>> >
>> > http://github.com/alfie/perl/tree/cpan_always
>> > git [at] github:alfie/perl.git branch cpan_always
>>
>> did you miss `o conf prerequisites_policy follow`, or did I miss
>> something and your patch does something else?
>
> Well, it seems to be useful for the times when you wish you had already
> done "o conf prerequisites_policy follow" or you want to follow
> temporarily.

Exactly. This saves keystrokes.

> FWIW I lke the idea, but I suspect the patch should probably have gone
> to Andreas König <andk [at] cpan> (see Porting/Maintainers.pl).

Thanks for the heads up. I was just following what was set out at:

http://dev.perl.org/perl5/docs/perlrepository.html

Alfie

xdaveg at gmail

Nov 14, 2009, 5:03 AM

Post #5 of 7 (380 views)
Permalink

Re: [Patch] adding 'always' option to cpan(1) prerequisite module prompt [In reply to]

On Sat, Nov 14, 2009 at 5:53 AM, Alfie John <alfie [at] h4c> wrote:
>> Well, it seems to be useful for the times when you wish you had already
>> done "o conf prerequisites_policy follow" or you want to follow
>> temporarily.
>
> Exactly. This saves keystrokes.
>
>> FWIW I lke the idea, but I suspect the patch should probably have gone
>> to Andreas KĂ¶nig <andk [at] cpan> (see Porting/Maintainers.pl).

I like it as well. (And I'm a co-maintainer of CPAN). We're trying
to have CPAN.pm have less stupid prompting of users in general and
this is consistent with recent changes in that direction.

However, "always" sounds like it should commit the changes to the
config as well, not just have it be for the session. So it needs to
do that as well or else have a different name. (I'd prefer the
former) I mean, really, how often do people *not* want prerequisites?

Alfie -- could you please just send a diff of your patch to
bug-CPAN [at] rt? That will get it in the queue and Andreas or I
or another maintainer will debate the right approach on RT and we'll
get it added upstream.

> Thanks for the heads up. I was just following what was set out at:
>
> Â http://dev.perl.org/perl5/docs/perlrepository.html

Hmm. That does need a more prominent warning about not patching
things that are maintained upstream.

-- David

alfie at h4c

Nov 14, 2009, 5:16 AM

Post #6 of 7 (380 views)
Permalink

Re: [Patch] adding 'always' option to cpan(1) prerequisite module prompt [In reply to]

On Sun, November 15, 2009 12:03 am, David Golden wrote:
> I like it as well. (And I'm a co-maintainer of CPAN). We're trying
> to have CPAN.pm have less stupid prompting of users in general and
> this is consistent with recent changes in that direction.
>
> However, "always" sounds like it should commit the changes to the
> config as well, not just have it be for the session. So it needs to
> do that as well or else have a different name. (I'd prefer the
> former) I mean, really, how often do people *not* want prerequisites?

I was going for consistency. I'm used to seeing in tools that prompt;

[y]es, [n]o, [a]lways and [N]ever.

As for commiting the changes to disk, I would agree.

> Alfie -- could you please just send a diff of your patch to
> bug-CPAN [at] rt? That will get it in the queue and Andreas or I
> or another maintainer will debate the right approach on RT and we'll
> get it added upstream.

No problem. Doing it now.

Alfie.

perl at profvince

Nov 14, 2009, 6:00 AM

Post #7 of 7 (379 views)
Permalink

Re: [Patch] adding 'always' option to cpan(1) prerequisite module prompt [In reply to]

> I like it as well. (And I'm a co-maintainer of CPAN). We're trying
> to have CPAN.pm have less stupid prompting of users in general and
> this is consistent with recent changes in that direction.
>
> However, "always" sounds like it should commit the changes to the
> config as well, not just have it be for the session.
Then if and only if autocommit is turned on, please.

Vincent.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads