steve.m.hay at googlemail
Nov 13, 2009, 4:21 PM
Post #11 of 11
(460 views)
Permalink
|
2009/11/13 Paul Marquess <Paul.Marquess [at] ntlworld>:
> From: Steve Hay [mailto:steve.m.hay [at] googlemail]
>
>> 2009/11/12 Paul Marquess <Paul.Marquess [at] ntlworld>:
>> > From: Steve Hay [mailto:SteveHay [at] planit]
>> >>
>> >> Paul Marquess wrote on 2009-10-10:
>> >> >
>> >> >
>> >> >> -----Original Message-----
>> >> >> From: jesse [mailto:jesse [at] fsck]
>> >> >> Sent: 10 October 2009 02:31
>> >> >> To: Steve Hay
>> >> >> Cc: Paul Marquess; perl5-porters [at] perl
>> >> >> Subject: Re: [PATCH] IO-Compress 2.022
>> >> >>
>> >> >>
>> >> >>
>> >> >>
>> >> >> On Sat, Oct 10, 2009 at 01:40:03AM +0100, Steve Hay wrote:
>> >> >>> 2009/10/9 Paul Marquess <Paul.Marquess [at] btinternet>:
>> >> >>>> Enclosed is a patch to sort out the Makefile.PL issue. The CPAN
>> >> >>>> version will be uploaded shortly
>> >> >>>>
>> >> >>> Gah! You've got the wrong version in there! You've got [5.9.0,
>> >> >>> 5.11.1] instead of [5.9.0, 5.11.0]. Even after you double-
>> >> checked...
>> >> >
>> >> > Damn! Sorry about that.
>> >> >
>> >> >>> http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2009-
>> >> >>> 10/msg00445.html
>> >> >>>
>> >> >>> It's hit CPAN already, so what's the best way out now? Make a
>> 2.023
>> >> to
>> >> >>> fix this now? Or is it easier for me to delay reverting the core
>> >> >>> changes until after 5.11.1 is released (shouldn't be long!), in
>> >> which
>> >> >>> case what you've done would then be correct?
>> >> >>>
>> >> >>
>> >> >> Let's just wait until after 5.11.1 comes out a week from this
>> >> Tuesday.
>> >> >> :)
>> >> >
>> >> > That would suit me, if it's ok with everyone.
>> >> >
>> >>
>> >>
>> >> We're nearing 5.11.2 (20th November), so I should revert those core
>> >> changes soon if that's still the plan.
>> >>
>> >> Paul, have you had any more problems reported with IO-Compress
>> 2.022?
>> >
>> > No - none at all.
>> >
>> > FYI, I released 2.023 onto CPAN earlier in the week - haven't done a
>> core
>> > patch for it yet - main change was added support for LZMA & xz, and
>> those
>> > don't affect what is in core. Wanted to see if there were any issue
>> before
>> > patching the core.
>> >
>> >> Are you planning on keeping the change that went into it, or backing
>> >> that out because of the install PREFIX problem?
>> >
>> > I can certainly revert it and that should fix the PREFIX problem, but
>> are
>> > you not still faced with the win32 problem that started off the
>> thread?
>> >
>>
>> I wasn't suggesting that you should revert it. Indeed, I'd rather you
>> didn't because then the original problems would of course come back
>> again. I was just wondering if you were unhappy keeping the change
>> because of the PREFIX problem that it caused.
>>
>> My view is that it is better than it was: it fixes the original
>> problems, and the new PREFIX problem can be easily avoided by using
>> INSTALL_BASE instead (which EU-MM itself recommends doing anyway).
>>
>> So if you're happy to keep it then I'll go ahead and revert the core
>> changes in Configure and win32/FindExt.pm as planned.
>
> That's fine.
>
Ok, the 2.022 patch is now in as
1725f55ba78fb58489ea39e2bc0cc1faffd32275 and the now-unnecessary core
changes are reverted in 88a6f4fc380d30c405f82eb0f2962237fd771fea.
We'll await a 2.023 patch when you're ready with that.
|
0001-IO-Compress-2.022.patch
