Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Perl: porters

[PATCH] Re: [perl #50180] NDBM_File fails to build

 

 

Perl porters RSS feed   Index | Next | Previous | View Threaded


doughera at lafayette

May 13, 2008, 9:28 AM

Post #1 of 2 (121 views)
Permalink
[PATCH] Re: [perl #50180] NDBM_File fails to build

On Tue, 6 May 2008, Andy Dougherty wrote:

> On Wed, 23 Jan 2008, via RT wrote:
>
> > building perl 5.10.0 failed to build/install NDBM_File. i'm runninng
> > Sidux (Debian Sid/Unstable). located /usr/include/gdbm-ndbm.h and had
> > to symlink it to /usr/include/ndbm.h to allow NDBM_File to make
> > properly.

> There appear to be two changes in Debian regarding the ndbm compatibility
> library that Configure needs to track. First, as you point out, the
> include file has been moved to <gdbm-ndbm.h>. Second, Configure needs to
> look in -lgdbm-compat to find the dbm_open() function. (This wasn't an
> issue for you because the NDBM_File extension does this automatically when
> not built as part of the perl core.)
>
> I'm working on a patch to fix both of these issues, but thought I'd better
> post for feedback first:
>
> We now have three places to look for the "ndbm.h" include file:
>
> <ndbm.h> /* traditional */
> <gdbm/ndbm.h> /* RedHat 7.1, according to the Configure comments */
> <gdbm-ndbm.h> /* Debian 4.0 */
>
> Also, we have at least three different libraries to consider:
> -lndbm
> -lgdbm
> -lgdbm-compat
>
> While I'm trying to generalize things, are there any other names or
> locations Configure should check? (Or any corrections to the comments
> about who keeps what where?)


I have attached two patches to address this problem. First is a simple
patch to enable NDBM_File to look in all those different locations, and an
addition to hints/linux.sh to also look for libgdbm-compat. Second is the
set of metaconfig patches to implement the appropriate detection.
(I'd have included the full Configure patch, but it's 143k long, mostly
due to harmless rearrangement of individual elements within Configure.)

This should be safe for all perl branches.

--
Andy Dougherty doughera[at]lafayette.edu
Attachments: ndbm-core.p1 (1.11 KB)
  ndbm-metaconfig.p1 (4.27 KB)


h.m.brand at xs4all

May 17, 2008, 7:29 AM

Post #2 of 2 (89 views)
Permalink
Re: [PATCH] Re: [perl #50180] NDBM_File fails to build [In reply to]

On Tue, 13 May 2008 12:28:45 -0400 (EDT), Andy Dougherty
<doughera[at]lafayette.edu> wrote:

> On Tue, 6 May 2008, Andy Dougherty wrote:
>
> > On Wed, 23 Jan 2008, via RT wrote:
> >
> > > building perl 5.10.0 failed to build/install NDBM_File. i'm runninng
> > > Sidux (Debian Sid/Unstable). located /usr/include/gdbm-ndbm.h and had
> > > to symlink it to /usr/include/ndbm.h to allow NDBM_File to make
> > > properly.
>
> > There appear to be two changes in Debian regarding the ndbm compatibility
> > library that Configure needs to track. First, as you point out, the
> > include file has been moved to <gdbm-ndbm.h>. Second, Configure needs to
> > look in -lgdbm-compat to find the dbm_open() function. (This wasn't an
> > issue for you because the NDBM_File extension does this automatically when
> > not built as part of the perl core.)
> >
> > I'm working on a patch to fix both of these issues, but thought I'd better
> > post for feedback first:
> >
> > We now have three places to look for the "ndbm.h" include file:
> >
> > <ndbm.h> /* traditional */
> > <gdbm/ndbm.h> /* RedHat 7.1, according to the Configure comments */
> > <gdbm-ndbm.h> /* Debian 4.0 */
> >
> > Also, we have at least three different libraries to consider:
> > -lndbm
> > -lgdbm
> > -lgdbm-compat
> >
> > While I'm trying to generalize things, are there any other names or
> > locations Configure should check? (Or any corrections to the comments
> > about who keeps what where?)
>
> I have attached two patches to address this problem. First is a simple
> patch to enable NDBM_File to look in all those different locations, and an
> addition to hints/linux.sh to also look for libgdbm-compat. Second is the
> set of metaconfig patches to implement the appropriate detection.
> (I'd have included the full Configure patch, but it's 143k long, mostly
> due to harmless rearrangement of individual elements within Configure.)
>
> This should be safe for all perl branches.

Thanks, Applied in cluster as change #33845

--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org
http://www.goldmark.org/jeff/stupid-disclaimers/

Perl porters RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact lists@gossamer-threads.com
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.