Mailing List Archive: Perl: porters

[PATCH: TODO Tests] Re: [perl #53806] No complain about bareword

Index | Next | Previous | View Threaded

p5p at perl

May 12, 2008, 1:57 PM

Post #1 of 5 (179 views)
Permalink

[PATCH: TODO Tests] Re: [perl #53806] No complain about bareword

Quoting Bram <p5p[at]perl.wizbit.be>:

> (Patch with TODO tests coming soon)
>

Patch attached.

Attachments:

patch_strict.t (1.80 KB)

rgarciasuarez at gmail

May 20, 2008, 12:45 AM

Post #2 of 5 (133 views)
Permalink

Re: [PATCH: TODO Tests] Re: [perl #53806] No complain about bareword [In reply to]

2008/5/12 Bram <p5p[at]perl.wizbit.be>:
>
> Quoting Bram <p5p[at]perl.wizbit.be>:
>
>> (Patch with TODO tests coming soon)
>>
>
> Patch attached.

And here's a fix.

All tests pass, but that's a really old piece of code here.

--- toke.c.orig 2008-05-19 08:51:44.000000000 +0200
+++ toke.c 2008-05-19 17:17:18.000000000 +0200
@@ -5667,10 +5667,10 @@

/* Call it a bare word */

+ bareword:
if (PL_hints & HINT_STRICT_SUBS)
pl_yylval.opval->op_private |= OPpCONST_STRICT;
else {
- bareword:
if (lastchar != '-') {
if (ckWARN(WARN_RESERVED)) {
d = PL_tokenbuf;

h.m.brand at xs4all

May 20, 2008, 1:04 AM

Post #3 of 5 (132 views)
Permalink

Re: [PATCH: TODO Tests] Re: [perl #53806] No complain about bareword [In reply to]

On Tue, 20 May 2008 09:45:19 +0200, "Rafael Garcia-Suarez"
<rgarciasuarez[at]gmail.com> wrote:

> 2008/5/12 Bram <p5p[at]perl.wizbit.be>:
> >
> > Quoting Bram <p5p[at]perl.wizbit.be>:
> >
> >> (Patch with TODO tests coming soon)
> >>
> >
> > Patch attached.
>
> And here's a fix.

Applied as change #33874

> All tests pass, but that's a really old piece of code here.
>
> --- toke.c.orig 2008-05-19 08:51:44.000000000 +0200
> +++ toke.c 2008-05-19 17:17:18.000000000 +0200
> @@ -5667,10 +5667,10 @@
>
> /* Call it a bare word */
>
> + bareword:
> if (PL_hints & HINT_STRICT_SUBS)
> pl_yylval.opval->op_private |= OPpCONST_STRICT;
> else {
> - bareword:
> if (lastchar != '-') {
> if (ckWARN(WARN_RESERVED)) {
> d = PL_tokenbuf;
>

--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org
http://www.goldmark.org/jeff/stupid-disclaimers/

rgarciasuarez at gmail

May 20, 2008, 1:14 AM

Post #4 of 5 (131 views)
Permalink

Re: [PATCH: TODO Tests] Re: [perl #53806] No complain about bareword [In reply to]

2008/5/20 H.Merijn Brand <h.m.brand[at]xs4all.nl>:
> Applied as change #33874

Thanks Merijn, but could you also apply Bram's test, that I didn't
bother to resend ?

h.m.brand at xs4all

May 20, 2008, 2:29 AM

Post #5 of 5 (131 views)
Permalink

Re: [PATCH: TODO Tests] Re: [perl #53806] No complain about bareword [In reply to]

On Tue, 20 May 2008 10:14:28 +0200, "Rafael Garcia-Suarez"
<rgarciasuarez[at]gmail.com> wrote:

> 2008/5/20 H.Merijn Brand <h.m.brand[at]xs4all.nl>:
> > Applied as change #33874
>
> Thanks Merijn, but could you also apply Bram's test, that I didn't
> bother to resend ?

Change 33876 submitted.

--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org
http://www.goldmark.org/jeff/stupid-disclaimers/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com