Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Perl: porters

[perl #53746] bug with index() matching beyond end of string when \0 bytes (00000000) are involved

 

 

Perl porters RSS feed   Index | Next | Previous | View Threaded


perlbug-followup at perl

May 5, 2008, 9:43 AM

Post #1 of 4 (423 views)
Permalink
[perl #53746] bug with index() matching beyond end of string when \0 bytes (00000000) are involved

# New Ticket Created by Giuseppe Insana
# Please include the string: [perl #53746]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=53746 >


This is a bug report for perl from insana [at] ebi,
generated with the help of perlbug 1.36 running under perl 5.10.0.

# by Giuseppe Insana <insana [at] ebi>
# May 5 2008

$msg="aaZaa";
$string1="aa";
$string2="aaa";
print "msg (bits): ",unpack('b*',$msg),"\n";
print "indexing string1 ($string1) and string2 ($string2) inside msg
($msg)\n";
print index($msg,$string1,0),"\n";
print index($msg,$string2,0),"\n";

$msg="\0\0Z\0\0";
$string1="\0\0";
$string2="\0\0\0";
print "msg (bits): ",unpack('b*',$msg),"\n";
print "indexing string1 ($string1) and string2 ($string2) inside msg
($msg)\n";
print index($msg,$string1,0),"\n";
print index($msg,$string2,0),"\n";

print "\n result is different, but actually for string2 index should
always return -1 in both cases, shouldn't it??\n\n";

---
Flags:
category=core
severity=medium
---
Site configuration information for perl 5.10.0:

Configured by SYSTEM at Thu Jan 10 11:00:30 2008.

Summary of my perl5 (revision 5 version 10 subversion 0) configuration:
Platform:
osname=MSWin32, osvers=5.00, archname=MSWin32-x86-multi-thread
uname=''
config_args='undef'
hint=recommended, useposix=true, d_sigaction=undef
useithreads=define, usemultiplicity=define
useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
use64bitint=undef, use64bitall=undef, uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler:
cc='cl', ccflags ='-nologo -GF -W3 -MD -Zi -DNDEBUG -O1 -DWIN32
-D_CONSOLE -DNO_STRICT -DHAVE_DES_FCRYPT -DUSE_SITECUSTOMIZE
-DPRIVLIB_LAST_IN_INC -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS
-DUSE_PERLIO -DPERL_MSVCRT_READFIX',
optimize='-MD -Zi -DNDEBUG -O1',
cppflags='-DWIN32'
ccversion='12.00.8804', gccversion='', gccosandvers=''
intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=10
ivtype='long', ivsize=4, nvtype='double', nvsize=8,
Off_t='__int64', lseeksize=8
alignbytes=8, prototype=define
Linker and Libraries:
ld='link', ldflags ='-nologo -nodefaultlib -debug -opt:ref,icf
-libpath:"D:\apps\Perl\lib\CORE" -machine:x86'
libpth=\lib
libs= oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib
netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib version.lib
odbc32.lib odbccp32.lib msvcrt.lib
perllibs= oldnames.lib kernel32.lib user32.lib gdi32.lib
winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib
oleaut32.lib netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib
version.lib odbc32.lib odbccp32.lib msvcrt.lib
libc=msvcrt.lib, so=dll, useshrplib=true, libperl=perl510.lib
gnulibc_version=''
Dynamic Linking:
dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -debug
-opt:ref,icf -libpath:"D:\apps\Perl\lib\CORE" -machine:x86'

Locally applied patches:
ACTIVEPERL_LOCAL_PATCHES_ENTRY
32809 Load 'loadable object' with non-default file extension
32728 64-bit fix for Time::Local

---
@INC for perl 5.10.0:
D:/apps/Perl/site/lib
D:/apps/Perl/lib
.

---
Environment for perl 5.10.0:
HOME=D:\HOME
LANG (unset)
LANGUAGE (unset)
LD_LIBRARY_PATH (unset)
LOGDIR (unset)

PATH=D:\apps\Perl\site\bin;D:\apps\Perl\bin;D:\apps\PHP\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\Program
Files\GNU\GnuPG;D:\apps\cvsnt;C:\USR\BIN;D:\apps\Python25;
PERL_BADLANG (unset)
SHELL=/bin/sh


perlbug-followup at perl

May 5, 2008, 11:50 AM

Post #2 of 4 (412 views)
Permalink
[perl #53746] bug with index() matching beyond end of string when \0 bytes (00000000) are involved [In reply to]

Easier example:

perl5.8.8 -wle 'my $s = "\0\0\0"; print index("\0\0Z\0\0", $s, 0);'
# Output: -1

perl5.10.0 -wle 'my $s = "\0\0\0"; print index("\0\0Z\0\0", $s, 0);'
# Output: 3

perl-blead -wle 'my $s = "\0\0\0"; print index("\0\0Z\0\0", $s, 0);'
# Output: 3


Note that:

perl-blead -wle 'print index("\0\0Z\0\0", "\0\0\0", 0);'
# Output: -1

perl-blead -wle 'my $s = "\0\0\0\0"; print index("\0\0Z\0\0", $s, 0);'
# Output: -1


abigail at abigail

May 6, 2008, 5:57 AM

Post #3 of 4 (403 views)
Permalink
Re: [perl #53746] bug with index() matching beyond end of string when \0 bytes (00000000) are involved [In reply to]

On Mon, May 05, 2008 at 11:50:44AM -0700, Bram via RT wrote:
> Easier example:
>
> perl5.8.8 -wle 'my $s = "\0\0\0"; print index("\0\0Z\0\0", $s, 0);'
> # Output: -1
>
> perl5.10.0 -wle 'my $s = "\0\0\0"; print index("\0\0Z\0\0", $s, 0);'
> # Output: 3
>
> perl-blead -wle 'my $s = "\0\0\0"; print index("\0\0Z\0\0", $s, 0);'
> # Output: 3


Attached is a set of tests.


Abigail
Attachments: diff (1.39 KB)


davem at iabyn

May 30, 2008, 2:44 PM

Post #4 of 4 (378 views)
Permalink
Re: [perl #53746] bug with index() matching beyond end of string when \0 bytes (00000000) are involved [In reply to]

On Tue, May 06, 2008 at 02:57:36PM +0200, Abigail wrote:
> On Mon, May 05, 2008 at 11:50:44AM -0700, Bram via RT wrote:
> > Easier example:
> >
> > perl5.8.8 -wle 'my $s = "\0\0\0"; print index("\0\0Z\0\0", $s, 0);'
> > # Output: -1
> >
> > perl5.10.0 -wle 'my $s = "\0\0\0"; print index("\0\0Z\0\0", $s, 0);'
> > # Output: 3
> >
> > perl-blead -wle 'my $s = "\0\0\0"; print index("\0\0Z\0\0", $s, 0);'
> > # Output: 3
>
>
> Attached is a set of tests.

Thanks, applied as change #33951.
I've fixed the bug itself as change #33952.
(Whoo hoo! A bug that was easy to locate, fix, and test for. You don't
see that very often :-).

--
Overhead, without any fuss, the stars were going out.
-- Arthur C Clarke

Perl porters RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.