Mailing List Archive: Perl: porters

Fix \k<foo> preceded by literal

Index | Next | Previous | View Threaded

demerphq at gmail

Nov 28, 2006, 2:10 PM

Post #1 of 7 (337 views)
Permalink

Fix \k<foo> preceded by literal

Grinder pointed out that literals before a \k<foo> break the \k, which is wrong.

Attached patch fixes and tests.

Cheers,
yves

--
perl -Mre=debug -e "/just|another|perl|hacker/"

Attachments:

literal_k.patch (0.76 KB)

demerphq at gmail

Nov 28, 2006, 2:25 PM

Post #2 of 7 (324 views)
Permalink

Re: Fix \k<foo> preceded by literal [In reply to]

On 11/28/06, demerphq <demerphq[at]gmail.com> wrote:
> Grinder pointed out that literals before a \k<foo> break the \k, which is wrong.
>
> Attached patch fixes and tests.

Dang, there were two bugs there... Attached patch fixes both.

Cheers,
Yves

--
perl -Mre=debug -e "/just|another|perl|hacker/"

demerphq at gmail

Nov 28, 2006, 2:26 PM

Post #3 of 7 (325 views)
Permalink

Re: Fix \k<foo> preceded by literal [In reply to]

On 11/28/06, demerphq <demerphq[at]gmail.com> wrote:
> On 11/28/06, demerphq <demerphq[at]gmail.com> wrote:
> > Grinder pointed out that literals before a \k<foo> break the \k, which is wrong.
> >
> > Attached patch fixes and tests.
>
> Dang, there were two bugs there... Attached patch fixes both.

And now with the patch. :-)

Yves

--
perl -Mre=debug -e "/just|another|perl|hacker/"

Attachments:

literal_k2.patch (1.25 KB)

demerphq at gmail

Nov 28, 2006, 3:16 PM

Post #4 of 7 (322 views)
Permalink

Re: Fix \k<foo> preceded by literal [In reply to]

On 11/28/06, demerphq <demerphq[at]gmail.com> wrote:
> On 11/28/06, demerphq <demerphq[at]gmail.com> wrote:
> > On 11/28/06, demerphq <demerphq[at]gmail.com> wrote:
> > > Grinder pointed out that literals before a \k<foo> break the \k, which is wrong.
> > >
> > > Attached patch fixes and tests.
> >
> > Dang, there were two bugs there... Attached patch fixes both.
>
> And now with the patch. :-)

Feeling like a plonker he mails it out one last time...

Yves

--
perl -Mre=debug -e "/just|another|perl|hacker/"

Attachments:

literal_k3.patch (1.47 KB)

rgarciasuarez at gmail

Nov 29, 2006, 1:06 AM

Post #5 of 7 (317 views)
Permalink

Re: Fix \k<foo> preceded by literal [In reply to]

On 29/11/06, demerphq <demerphq[at]gmail.com> wrote:
> > > > Attached patch fixes and tests.
> > >
> > > Dang, there were two bugs there... Attached patch fixes both.
> >
> > And now with the patch. :-)
>
> Feeling like a plonker he mails it out one last time...

The last test fails :

Failed Test Stat Wstat Total Fail List of Failed
-------------------------------------------------------------------------------
op/regexp.t 1200 1 1200
op/regexp_noamp.t 1200 1 1200
op/regexp_notrie.t 1200 1 1200
op/regexp_qr.t 1200 1 1200
op/regexp_qr_embed.t 1200 1 1200
op/regexp_trielist.t 1200 1 1200

demerphq at gmail

Nov 29, 2006, 7:18 AM

Post #6 of 7 (322 views)
Permalink

Re: Fix \k<foo> preceded by literal [In reply to]

On 11/29/06, Rafael Garcia-Suarez <rgarciasuarez[at]gmail.com> wrote:
> On 29/11/06, demerphq <demerphq[at]gmail.com> wrote:
> > > > > Attached patch fixes and tests.
> > > >
> > > > Dang, there were two bugs there... Attached patch fixes both.
> > >
> > > And now with the patch. :-)
> >
> > Feeling like a plonker he mails it out one last time...
>
> The last test fails :
>
> Failed Test Stat Wstat Total Fail List of Failed
> -------------------------------------------------------------------------------
> op/regexp.t 1200 1 1200
> op/regexp_noamp.t 1200 1 1200
> op/regexp_notrie.t 1200 1 1200
> op/regexp_qr.t 1200 1 1200
> op/regexp_qr_embed.t 1200 1 1200
> op/regexp_trielist.t 1200 1 1200
>

Hmm, yeah, I guess the chunk from regcomp.h in the k3 patch didnt
apply? This patch should apply cleanly to 29417 and pass test. Sorry
about the hassle.

cheers,
Yves

--
perl -Mre=debug -e "/just|another|perl|hacker/"

Attachments:

literal_k4.patch (1.36 KB)

rgarciasuarez at gmail

Nov 29, 2006, 7:30 AM

Post #7 of 7 (319 views)
Permalink

Re: Fix \k<foo> preceded by literal [In reply to]

On 29/11/06, demerphq <demerphq[at]gmail.com> wrote:
>
> Hmm, yeah, I guess the chunk from regcomp.h in the k3 patch didnt
> apply? This patch should apply cleanly to 29417 and pass test. Sorry
> about the hassle.

Thanks, applied as 29420.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com