Mailing List Archive: Perl: porters

[Patch] croak -> Perl_croak in sv_upgrade

Index | Next | Previous | View Threaded

jcromie at divsol

Jun 17, 2005, 8:04 AM

Post #1 of 5 (957 views)
Permalink

[Patch] croak -> Perl_croak in sv_upgrade

Attachments:

patch-p0-sv.c (0.32 KB)

andy at petdance

Jun 17, 2005, 8:11 AM

Post #2 of 5 (927 views)
Permalink

Re: [Patch] croak -> Perl_croak in sv_upgrade [In reply to]

On Fri, Jun 17, 2005 at 09:04:22AM -0600, Jim Cromie (jcromie [at] divsol) wrote:
> - croak ("sv_upgrade from type %d down to type %d", SvTYPE(sv), mt);
> + Perl_croak (aTHX_ "sv_upgrade from type %d down to type %d", SvTYPE(sv), mt);

Is this something we want to be doing across the board?

--
Andy Lester => andy [at] petdance => www.petdance.com => AIM:petdance

rgarciasuarez at mandriva

Jun 17, 2005, 8:12 AM

Post #3 of 5 (930 views)
Permalink

Re: [Patch] croak -> Perl_croak in sv_upgrade [In reply to]

Jim Cromie wrote:
> --- sv.c~ 2005-06-17 08:11:03.000000000 -0600
> +++ sv.c 2005-06-17 08:55:46.000000000 -0600
> @@ -1342,7 +1342,7 @@
> return;
>
> if (SvTYPE(sv) > mt)
> - croak ("sv_upgrade from type %d down to type %d", SvTYPE(sv), mt);
> + Perl_croak (aTHX_ "sv_upgrade from type %d down to type %d", SvTYPE(sv), mt);

Thanks, fixed as 24887.

jcromie at divsol

Jun 17, 2005, 8:53 AM

Post #4 of 5 (941 views)
Permalink

Re: [Patch] croak -> Perl_croak in sv_upgrade [In reply to]

Andy Lester wrote:

>On Fri, Jun 17, 2005 at 09:04:22AM -0600, Jim Cromie (jcromie [at] divsol) wrote:
>
>
>>- croak ("sv_upgrade from type %d down to type %d", SvTYPE(sv), mt);
>>+ Perl_croak (aTHX_ "sv_upgrade from type %d down to type %d", SvTYPE(sv), mt);
>>
>>
>
>Is this something we want to be doing across the board?
>
>
>
>
this was a point fix. Im just a tourist grabbing the dropped baton as a
souvenir
(with apologies to Nick and Rafael for the American 4x100 relay team
comparison)

rgarciasuarez at gmail

Jun 17, 2005, 8:58 AM

Post #5 of 5 (937 views)
Permalink

Re: [Patch] croak -> Perl_croak in sv_upgrade [In reply to]

On 6/17/05, Andy Lester <andy [at] petdance> wrote:
> On Fri, Jun 17, 2005 at 09:04:22AM -0600, Jim Cromie (jcromie [at] divsol) wrote:
> > - croak ("sv_upgrade from type %d down to type %d", SvTYPE(sv), mt);
> > + Perl_croak (aTHX_ "sv_upgrade from type %d down to type %d", SvTYPE(sv), mt);
>
> Is this something we want to be doing across the board?

Sure, this really shouldn't occur anyway.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads