Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: OpenStack: Dev

UnifiedCLI suggestion

 

 

OpenStack dev RSS feed   Index | Next | Previous | View Threaded


krt at yahoo-inc

Jun 25, 2012, 3:19 PM

Post #1 of 5 (101 views)
Permalink
UnifiedCLI suggestion

Greetings all,

Our security folks have an issue with putting passwords on the command
line or in the environment. I wrote up a blueprint that gives the
details on their objections as well as a proposed short-term fix for
keystone
(https://blueprints.launchpad.net/keystone/+spec/prompt-for-password).
We'd like to see this same change get into UnifiedCLI as a longer term fix.

The change is minor. If no password was found on the command line or in
the env, just before the "expecting password" error is raised, we make
an attempt to prompt the user for it. If we get something, great! Our
security folks are happy and we keep processing. If we don't get the
password for any number of reasons (keystone wasn't being run from a
tty, the user hit Ctrl-C or Ctrl-D when prompted), then we raise the
error just as before.

I've already submitted the keystone changes for review
(https://review.openstack.org/#/c/8958/3/keystoneclient/shell.py) and
I'd be happy to make the same change to UnifiedCLI as well.

Thanks!

Ken






_______________________________________________
Mailing list: https://launchpad.net/~openstack
Post to : openstack [at] lists
Unsubscribe : https://launchpad.net/~openstack
More help : https://help.launchpad.net/ListHelp


doug.hellmann at dreamhost

Jun 25, 2012, 3:28 PM

Post #2 of 5 (100 views)
Permalink
Re: UnifiedCLI suggestion [In reply to]

On Mon, Jun 25, 2012 at 6:19 PM, Ken Thomas <krt [at] yahoo-inc> wrote:

> Greetings all,
>
> Our security folks have an issue with putting passwords on the command
> line or in the environment. I wrote up a blueprint that gives the details
> on their objections as well as a proposed short-term fix for keystone (
> https://blueprints.launchpad.**net/keystone/+spec/prompt-for-**password<https://blueprints.launchpad.net/keystone/+spec/prompt-for-password>).
> We'd like to see this same change get into UnifiedCLI as a longer term fix.
>
> The change is minor. If no password was found on the command line or in
> the env, just before the "expecting password" error is raised, we make an
> attempt to prompt the user for it. If we get something, great! Our
> security folks are happy and we keep processing. If we don't get the
> password for any number of reasons (keystone wasn't being run from a tty,
> the user hit Ctrl-C or Ctrl-D when prompted), then we raise the error just
> as before.
>
> I've already submitted the keystone changes for review (
> https://review.openstack.org/**#/c/8958/3/keystoneclient/**shell.py<https://review.openstack.org/#/c/8958/3/keystoneclient/shell.py>)
> and I'd be happy to make the same change to UnifiedCLI as well.
>

Thanks, Ken! That sounds like a good change to make. If you add me as a
reviewer on the patch, I'll make sure to look at the changes.

Doug


dtroyer at gmail

Jun 28, 2012, 8:54 AM

Post #3 of 5 (94 views)
Permalink
Re: UnifiedCLI suggestion [In reply to]

On Mon, Jun 25, 2012 at 5:28 PM, Doug Hellmann
<doug.hellmann [at] dreamhost> wrote:
> On Mon, Jun 25, 2012 at 6:19 PM, Ken Thomas <krt [at] yahoo-inc> wrote:
[...]
>> I've already submitted the keystone changes for review
>> (https://review.openstack.org/#/c/8958/3/keystoneclient/shell.py) and I'd be
>> happy to make the same change to UnifiedCLI as well.
>
> Thanks, Ken! That sounds like a good change to make. If you add me as a
> reviewer on the patch, I'll make sure to look at the changes.

I created a blueprint for this:
https://blueprints.launchpad.net/python-openstackclient/+spec/password-prompt
linking back to the keystone blueprint. That looks like a good
solution.

Thanks Ken
dt

--

Dean Troyer
dtroyer [at] gmail

_______________________________________________
Mailing list: https://launchpad.net/~openstack
Post to : openstack [at] lists
Unsubscribe : https://launchpad.net/~openstack
More help : https://help.launchpad.net/ListHelp


ayoung at redhat

Jul 16, 2012, 2:00 PM

Post #4 of 5 (68 views)
Permalink
Re: UnifiedCLI suggestion [In reply to]

On 06/28/2012 11:54 AM, Dean Troyer wrote:
> On Mon, Jun 25, 2012 at 5:28 PM, Doug Hellmann
> <doug.hellmann [at] dreamhost> wrote:
>> On Mon, Jun 25, 2012 at 6:19 PM, Ken Thomas <krt [at] yahoo-inc> wrote:
> [...]
>>> I've already submitted the keystone changes for review
>>> (https://review.openstack.org/#/c/8958/3/keystoneclient/shell.py) and I'd be
>>> happy to make the same change to UnifiedCLI as well.
>> Thanks, Ken! That sounds like a good change to make. If you add me as a
>> reviewer on the patch, I'll make sure to look at the changes.
> I created a blueprint for this:
> https://blueprints.launchpad.net/python-openstackclient/+spec/password-prompt
> linking back to the keystone blueprint. That looks like a good
> solution.
>
> Thanks Ken
> dt
>
Probably would be better to have a deliberate command line flag for it,
so automated scripts don't hang.

Something like --prompt


_______________________________________________
Mailing list: https://launchpad.net/~openstack
Post to : openstack [at] lists
Unsubscribe : https://launchpad.net/~openstack
More help : https://help.launchpad.net/ListHelp


krt at yahoo-inc

Jul 16, 2012, 2:45 PM

Post #5 of 5 (66 views)
Permalink
Re: UnifiedCLI suggestion [In reply to]

The code checks that it's has a tty before it prompts. Automatic scripts
should work just as before using the env variable or command line
option. If they aren't present and there's no tty, then they'll error
out exactly as they did before.

Ken

On 7/16/12 2:00 PM, Adam Young wrote:
> On 06/28/2012 11:54 AM, Dean Troyer wrote:
>> On Mon, Jun 25, 2012 at 5:28 PM, Doug Hellmann
>> <doug.hellmann [at] dreamhost> wrote:
>>> On Mon, Jun 25, 2012 at 6:19 PM, Ken Thomas <krt [at] yahoo-inc> wrote:
>> [...]
>>>> I've already submitted the keystone changes for review
>>>> (https://review.openstack.org/#/c/8958/3/keystoneclient/shell.py) and I'd be
>>>> happy to make the same change to UnifiedCLI as well.
>>> Thanks, Ken! That sounds like a good change to make. If you add me as a
>>> reviewer on the patch, I'll make sure to look at the changes.
>> I created a blueprint for this:
>> https://blueprints.launchpad.net/python-openstackclient/+spec/password-prompt
>> linking back to the keystone blueprint. That looks like a good
>> solution.
>>
>> Thanks Ken
>> dt
>>
> Probably would be better to have a deliberate command line flag for it,
> so automated scripts don't hang.
>
> Something like --prompt
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openstack
> Post to : openstack [at] lists
> Unsubscribe : https://launchpad.net/~openstack
> More help : https://help.launchpad.net/ListHelp



_______________________________________________
Mailing list: https://launchpad.net/~openstack
Post to : openstack [at] lists
Unsubscribe : https://launchpad.net/~openstack
More help : https://help.launchpad.net/ListHelp

OpenStack dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.