Mailing List Archive: OpenSSH: Dev

Call for testing: OpenSSH-6.0

Index | Next | Previous | View Threaded

djm at mindrot

Feb 12, 2012, 10:51 PM

Post #1 of 24 (1190 views)
Permalink

Call for testing: OpenSSH-6.0

Hi,

OpenSSH 6.0 is almost ready for release, so we would appreciate testing
on as many platforms and systems as possible. This release contains a
couple of new features and changes and bug fixes. Testing of the new
sandboxed privilege separation mode (see below) would be particularly
appreciated.

Snapshot releases for portable OpenSSH are available from
http://www.mindrot.org/openssh_snap/

The OpenBSD version is available in CVS HEAD:
http://www.openbsd.org/anoncvs.html

Portable OpenSSH is also available via anonymous CVS using the
instructions at http://www.openssh.com/portable.html#cvs or
via Mercurial at http://hg.mindrot.org/openssh

Running the regression tests supplied with Portable OpenSSH does not
require installation and is a simply:

$ ./configure && make tests

Live testing on suitable non-production systems is also
appreciated. Please send reports of success or failure to
openssh-unix-dev [at] mindrot

Below is a summary of changes. More detail may be found in the ChangeLog
in the portable OpenSSH tarballs.

Thanks to the many people who contributed to this release.

-------------------------------

Features:

* ssh-keygen(1): Add optional checkpoints for moduli screening
* ssh-add(1): new -k option to load plain keys (skipping certificates)
* sshd(8): Add wildcard support to PermitOpen, allowing things like
"PermitOpen localhost:*". bz #1857
* ssh(1): support for cancelling local and remote port forwards via the
multiplex socket. Use ssh -O cancel -L xx:xx:xx -R yy:yy:yy user [at] hos"
to request the cancellation of the specified forwardings
* support cancellation of local/dynamic forwardings from ~C commandline

Bugfixes:

* ssh(1): ensure that $DISPLAY contains only valid characters before
using it to extract xauth data so that it can't be used to play local
shell metacharacter games.
* ssh(1): unbreak remote portforwarding with dynamic allocated listen ports
* scp(1): uppress adding '--' to remote commandlines when the first
argument does not start with '-'. saves breakage on some
difficult-to-upgrade embedded/router platforms
* ssh(1)/sshd(8): fix typo in IPQoS parsing: there is no "AF14" class,
but there is an "AF21" class
* ssh(1)/sshd(8): do not permit SSH2_MSG_SERVICE_REQUEST/ACCEPT during
rekeying
* ssh(1): skip attempting to create ~/.ssh when -F is passed
* sshd(8): unbreak stdio forwarding when ControlPersist is in use; bz#1943
* sshd(1): send tty break to pty master instead of (probably already
closed) slave side; bz#1859
* sftp(1): silence error spam for "ls */foo" in directory with files;
bz#1683
* Fixed a number of memory and file descriptor leaks

Portable OpenSSH:

* ssh-keygen(1): don't fail in -A on platforms that don't support ECC
* Add optional support for LDNS, a BSD licensed DNS resolver library
which supports DNSSEC

Reporting Bugs:
===============

- Please read http://www.openssh.com/report.html
Security bugs should be reported directly to openssh [at] openssh

OpenSSH is brought to you by Markus Friedl, Niels Provos, Theo de Raadt,
Kevin Steves, Damien Miller, Darren Tucker, Jason McIntyre, Tim Rice and
Ben Lindstrom.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

fredports at mufley

Feb 13, 2012, 2:16 AM

Post #2 of 24 (1168 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

Hi there...

I have run now the tests on:

8.2-RELEASE-p5 FreeBSD 8.2-RELEASE-p5 #0

and all tests passed.

Frederico

On 2012-02-13 07:55, Damien Miller wrote:
> On Mon, 13 Feb 2012, Damien Miller wrote:
>
>> Hi,
>>
>> OpenSSH 6.0 is almost ready for release, so we would appreciate
>> testing
>> on as many platforms and systems as possible. This release contains
>> a
>> couple of new features and changes and bug fixes. Testing of the new
>> sandboxed privilege separation mode (see below) would be
>> particularly
>> appreciated.
>
> oops, the bit about the sandboxed privsep code is a carryover from
> the
> previous release and isn't mentioned in the feature list below after
> all.
> It could still do with some more testing though, as I don't recall
> seeing
> any reports from users who tried it.
>
> -d
> _______________________________________________
> openssh-unix-dev mailing list
> openssh-unix-dev [at] mindrot
> https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

fredports at mufley

Feb 13, 2012, 2:18 AM

Post #3 of 24 (1167 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

I should have mentioned that i have used the snapshot:

openssh-SNAP-20120213.tar.gz

BR

Frederico

On 2012-02-13 11:16, fredports wrote:
> Hi there...
>
> I have run now the tests on:
>
> 8.2-RELEASE-p5 FreeBSD 8.2-RELEASE-p5 #0
>
> and all tests passed.
>
> Frederico
>
> On 2012-02-13 07:55, Damien Miller wrote:
>> On Mon, 13 Feb 2012, Damien Miller wrote:
>>
>>> Hi,
>>>
>>> OpenSSH 6.0 is almost ready for release, so we would appreciate
>>> testing
>>> on as many platforms and systems as possible. This release contains
>>> a
>>> couple of new features and changes and bug fixes. Testing of the
>>> new
>>> sandboxed privilege separation mode (see below) would be
>>> particularly
>>> appreciated.
>>
>> oops, the bit about the sandboxed privsep code is a carryover from
>> the
>> previous release and isn't mentioned in the feature list below after
>> all.
>> It could still do with some more testing though, as I don't recall
>> seeing
>> any reports from users who tried it.
>>
>> -d
>> _______________________________________________
>> openssh-unix-dev mailing list
>> openssh-unix-dev [at] mindrot
>> https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

christophe at garault

Feb 13, 2012, 3:50 AM

Post #4 of 24 (1167 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

Le 13/02/2012 07:51, Damien Miller a �crit :
> -------------------------------
>
> Features:
>
> * ssh-keygen(1): Add optional checkpoints for moduli screening
>
Hello ssh users,

I've used that new feature a lot and posted the smallest patch ever to
preserve tested primes between sessions:
https://bugzilla.mindrot.org/show_bug.cgi?id=1957

Christophe Garault
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

vinschen at redhat

Feb 13, 2012, 6:05 AM

Post #5 of 24 (1167 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

On Feb 13 17:51, Damien Miller wrote:
> Hi,
>
> OpenSSH 6.0 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible. This release contains a
> couple of new features and changes and bug fixes. Testing of the new
> sandboxed privilege separation mode (see below) would be particularly
> appreciated.

All tests pass on Cygwin. However, is it possible to apply the below
patch before releasing 6.0? It just added back an important system
environment variable for native Windows apps.

Thanks,
Corinna

Index: openbsd-compat/bsd-cygwin_util.c
===================================================================
RCS file: /cvs/openssh/openbsd-compat/bsd-cygwin_util.c,v
retrieving revision 1.23
diff -u -p -r1.23 bsd-cygwin_util.c
--- openbsd-compat/bsd-cygwin_util.c 17 Aug 2011 01:31:09 -0000 1.23
+++ openbsd-compat/bsd-cygwin_util.c 13 Feb 2012 13:45:21 -0000
@@ -76,6 +76,7 @@ static struct wenv {
{ NL("OS=") },
{ NL("PATH=") },
{ NL("PATHEXT=") },
+ { NL("PROGRAMFILES=") },
{ NL("SYSTEMDRIVE=") },
{ NL("SYSTEMROOT=") },
{ NL("WINDIR=") }

--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

keisial at gmail

Feb 13, 2012, 8:59 AM

Post #6 of 24 (1169 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

./configure is failing for me with
> ...
> configure: creating ./config.status
> config.status: creating Makefile
> config.status: creating buildpkg.sh
> config.status: creating opensshd.init
> config.status: creating openssh.xml
> config.status: creating openbsd-compat/Makefile
> config.status: creating openbsd-compat/regress/Makefile
> config.status: creating survey.sh
> config.status: error: cannot find input file: `config.h.in'
Is it expected to fail with autoconf 2.68?

Also, not too important, but the following files have execute permissions,
and I don't think they should:
- ssh-sandbox.h
- openbsd-compat/sha2.h
- openbsd-compat/sha2.c
- contrib/solaris/README
- opensshd.init.in

Although I'm not sure about the last one, it may have it on purpose for
having
opensshd.init inherit the +x, even though that's not happening in my system.

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

djm at mindrot

Feb 13, 2012, 11:31 AM

Post #7 of 24 (1170 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

On Mon, 13 Feb 2012, ?ngel Gonz?lez wrote:

> ./configure is failing for me with
> > ...
> > configure: creating ./config.status
> > config.status: creating Makefile
> > config.status: creating buildpkg.sh
> > config.status: creating opensshd.init
> > config.status: creating openssh.xml
> > config.status: creating openbsd-compat/Makefile
> > config.status: creating openbsd-compat/regress/Makefile
> > config.status: creating survey.sh
> > config.status: error: cannot find input file: `config.h.in'
> Is it expected to fail with autoconf 2.68?

No, that's what I use to generate configure. The tarball ships with a
config.h.in so generated. Are you forgetting to run autoheader?

> Also, not too important, but the following files have execute permissions,
> and I don't think they should:
> - ssh-sandbox.h
> - openbsd-compat/sha2.h
> - openbsd-compat/sha2.c
> - contrib/solaris/README

Fixed - thanks

-d
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

djm at mindrot

Feb 13, 2012, 11:38 AM

Post #8 of 24 (1168 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

On Mon, 13 Feb 2012, Corinna Vinschen wrote:

> On Feb 13 17:51, Damien Miller wrote:
> > Hi,
> >
> > OpenSSH 6.0 is almost ready for release, so we would appreciate testing
> > on as many platforms and systems as possible. This release contains a
> > couple of new features and changes and bug fixes. Testing of the new
> > sandboxed privilege separation mode (see below) would be particularly
> > appreciated.
>
> All tests pass on Cygwin. However, is it possible to apply the below
> patch before releasing 6.0? It just added back an important system
> environment variable for native Windows apps.

Done

-d
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

keisial at gmail

Feb 13, 2012, 3:03 PM

Post #9 of 24 (1167 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

On 13/02/12 20:31, Damien Miller wrote:
> No, that's what I use to generate configure. The tarball ships with a
> config.h.in so generated. Are you forgetting to run autoheader?
Yes. I had only run autoconf. Either autoconf + autoheader or autoreconf
is needed. My fault.

It compiles and passes all tests now.

Some tests run utils which show error messages, though.
regress/copy2: Not a directory
rm: cannot remove `.': Is a directory
rm: cannot remove `..': Is a directory
rm: cannot remove `.': Is a directory
rm: cannot remove `..': Is a directory
which: no time in ($PATH)

>> Also, not too important, but the following files have execute permissions,
>> and I don't think they should:
>> - ssh-sandbox.h
>> - openbsd-compat/sha2.h
>> - openbsd-compat/sha2.c
>> - contrib/solaris/README
> Fixed - thanks
>
> -d
Ok. Thanks.

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

tim at multitalents

Feb 13, 2012, 3:53 PM

Post #10 of 24 (1169 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

On Tue, 14 Feb 2012, �ngel Gonz�lez wrote:

> Some tests run utils which show error messages, though.
> regress/copy2: Not a directory
> rm: cannot remove `.': Is a directory
> rm: cannot remove `..': Is a directory
> rm: cannot remove `.': Is a directory
> rm: cannot remove `..': Is a directory

These are to be expected.

> which: no time in ($PATH)

What platform are you on that does not have time(1)?

--
Tim Rice Multitalents
tim [at] multitalents

pcerny at suse

Feb 17, 2012, 4:39 PM

Post #11 of 24 (1173 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

Damien Miller wrote:
> On Mon, 13 Feb 2012, Damien Miller wrote:
>
>> Hi,
>>
>> OpenSSH 6.0 is almost ready for release, so we would appreciate testing
>> on as many platforms and systems as possible. This release contains a
>> couple of new features and changes and bug fixes. Testing of the new
>> sandboxed privilege separation mode (see below) would be particularly
>> appreciated.
>
> oops, the bit about the sandboxed privsep code is a carryover from the
> previous release and isn't mentioned in the feature list below after all.
> It could still do with some more testing though, as I don't recall seeing
> any reports from users who tried it.

openssh-SNAP-20120213.tar.gz:

testsuite passes on:
SUSE Linux Enterprise 11: x86-64
openSUSE/Factory (reasonably "cutting edge" repository): x86-64
Slackware-current: x86-32

I have also tried to run the testsuite in our automated build
environment (to test several architectures and distributions), but all
failed with at least of the following errors:

1)
test connection multiplexing: status 4
test connection multiplexing: status 5
test connection multiplexing: status 44
Master running (pid=14631)
Exit request sent.
failed connection multiplexing
make[1]: *** [t-exec] Error 1

2)
key option proto 1 from="127.0.0.1" not allowed but should be
key option proto 1 from="127.0.0.0/8"
key option proto 2 from="127.0.0.1"
key option proto 2 from="127.0.0.1" not allowed but should be
key option proto 2 from="127.0.0.0/8"
failed key options
make[1]: *** [t-exec] Error 1

3)
test try ciphers: proto 2 cipher acss [at] openssh mac hmac-sha2-512-96
ok try ciphers
run test yes-head.sh ...
ok yes pipe head
run test login-timeout.sh ...
FATAL: no sshd running on port 4242
make[1]: *** [t-exec] Error 1

I think these problems could be related to some missing system
functionality that is generally not required in the build environment
for building (e.g. it could be a missing or incorectly set up network
interface). The build environment is usually a chroot or a VM (which in
turn may be running in LPAR in the case of S/390, AFAIK). Can you give
me a hint what could be the problem behind these errors?

Thanks
Kind regards
Petr
--
Petr Cerny
Mozilla/OpenSSH maintainer for SUSE Linux
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

des at des

Feb 20, 2012, 7:17 AM

Post #12 of 24 (1153 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

[resent without troublesome attachments]

Damien Miller <djm [at] mindrot> writes:
> OpenSSH 6.0 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible. This release contains a
> couple of new features and changes and bug fixes. Testing of the new
> sandboxed privilege separation mode (see below) would be particularly
> appreciated.

openssh-SNAP-20120221 fails to build on FreeBSD 9 and 10: the configure
script incorrectly concludes that FreeBSD doesn't have openpty(3), and
bsd-openpty.c doesn't build on FreeBSD. See http://www.des.no/openssh/

The same snapshot builds fine and passes all tests on 8.2p3.

BTW, what about my ssh-agent reference-counting patch? :)

DES
--
Dag-Erling Smørgrav - des [at] des
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

kevin.brott at gmail

Feb 20, 2012, 5:07 PM

Post #13 of 24 (1176 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

On Sun, Feb 12, 2012 at 22:51, Damien Miller <djm [at] mindrot> wrote:

> Hi,
>
> OpenSSH 6.0 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible. This release contains a
> couple of new features and changes and bug fixes. Testing of the new
> sandboxed privilege separation mode (see below) would be particularly
> appreciated.
>
> ...

Using openssh-SNAP-20120221.tar.gz

./configure && make tests

OS Build_Target CC OpenSSL
BUILD TEST
============== =========================== ================
================= ===== ======================
RH 6.2 i686-pc-linux-gnu egcs 2.91.66 0.9.8j
YES All tests passed
RH 8.0 i686-pc-linux-gnu gcc 3.2.2-5 0.9.7a
YES All tests passed
RHEL 2.1 i686-pc-linux-gnu gcc 2.96-129.7.2 0.9.6b
YES All tests passed
RHEL 3.0 i686-pc-linux-gnu gcc 3.2.3-20 0.9.7a
YES All tests passed
RHEL 4.0 tu6 i686-pc-linux-gnu gcc 3.4.6 0.9.7a
YES All tests passed
RHEL 4.0 nu8 x86_64-unknown-linux-gnu gcc 3.4.6-8 0.9.7a
YES All tests passed
RHEL 4.0 nu7 powerpc64-unknown-linux-gnu gcc 3.4.6 0.9.7a
YES All tests passed
RHEL 5.1 x86_64-redhat-linux gcc 4.1.2-14 0.9.8b
YES All tests passed
RHEL 5.4 i686-pc-linux-gnu gcc 4.1.2-46
0.9.8e-fips-rhel5 YES All tests passed
RHEL 5.5 i686-pc-linux-gnu gcc 4.1.2-48
0.9.8e-fips-rhel5 YES All tests passed
RHEL 5.5 x86_64-redhat-linux gcc 4.1.2-48
0.9.8e-fips-rhel5 YES All tests passed
RHEL 5.6 i686-pc-linux-gnu gcc 4.1.2-50
0.9.8e-fips-rhel5 YES All tests passed
RHEL 5.6 x86_64-redhat-linux gcc 4.1.2-50
0.9.8e-fips-rhel5 YES All tests passed
RHEL 5.7 i686-redhat-linux gcc 4.1.2-51
0.9.8e-fips-rhel5 YES All tests passed
RHEL 5.7 x86_64-redhat-linux gcc 4.1.2-51
0.9.8e-fips-rhel5 YES All tests passed
Fedora Core r2 i686-pc-linux-gnu gcc 3.3.3-7 0.9.7a
YES All tests passed
Ubuntu 8.04.04 i686-pc-linux-gnu gcc 4.2.4-1ubuntu4 0.9.8g
YES All tests passed
Ubuntu 10.10 x86_64-linux-gnu gcc 4.4.4-14ubuntu5 0.9.8o
YES All tests passed
AIX 5200-10-04 powerpc-ibm-aix5.2.0.0 gcc 3.3.2 0.9.8f
YES All tests passed
AIX 5300-12-02 powerpc-ibm-aix5.3.0.0 gcc 4.0.0 0.9.8m
YES All tests passed
AIX 6100-04-06 powerpc-ibm-aix6.1.0.0 gcc 4.2.0 0.9.8k
YES All tests passed
AIX 7100-01-01 powerpc-ibm-aix7.1.0.0 xlc 11.1.0.6 0.9.8m
YES All tests passed
HP-UX 11.11 hppa2.0w-hp-hpux11.11 gcc 3.4.3 0.9.7m
YES All tests passed
HP-UX 11.23 ia64-hp-hpux11.23 gcc 4.1.1 0.9.8o
YES All tests passed
HP-UX 11.31 ia64-hp-hpux11.31 gcc 4.3.3 0.9.8n
YES All tests passed
HP-UX 11.31 ia64-hp-hpux11.31 C/aC++ A.06.20 0.9.8n
YES All tests passed

RH Red Hat
RHEL Red Hat Enterprise Linux

Non-prod usage testing in progress.

--
# include <stddisclaimer.h>
/* Kevin Brott <Kevin.Brott [at] gmail> */
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

djm at mindrot

Mar 8, 2012, 3:34 PM

Post #14 of 24 (1092 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

On Mon, 20 Feb 2012, Dag-Erling Sm?rgrav wrote:

> [resent without troublesome attachments]
>
> Damien Miller <djm [at] mindrot> writes:
> > OpenSSH 6.0 is almost ready for release, so we would appreciate testing
> > on as many platforms and systems as possible. This release contains a
> > couple of new features and changes and bug fixes. Testing of the new
> > sandboxed privilege separation mode (see below) would be particularly
> > appreciated.
>
> openssh-SNAP-20120221 fails to build on FreeBSD 9 and 10: the configure
> script incorrectly concludes that FreeBSD doesn't have openpty(3), and
> bsd-openpty.c doesn't build on FreeBSD. See http://www.des.no/openssh/

So, config.log says:

> configure:9158: gcc -o conftest -g -O2 -Wall -Wpointer-arith -Wuninitialized
> -Wsign-compare -Wformat-security -Wno-pointer-sign -fno-strict-aliasing >
> -D_FORTIFY_SOURCE=2 -fno-builtin-memset -fstack-protector-all >
> -fstack-protector-all conftest.c -lz >&5
> /tmp//ccnfm8sv.o: In function `main':
> /home/des/src/openssh/conftest.c:137: undefined reference to `openpty'

Does FreeBSD stick openpty in -lutil or somesuch?

-d
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

djm at mindrot

Mar 8, 2012, 3:46 PM

Post #15 of 24 (1091 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

On Fri, 9 Mar 2012, Damien Miller wrote:

> On Mon, 20 Feb 2012, Dag-Erling Sm?rgrav wrote:
>
> > openssh-SNAP-20120221 fails to build on FreeBSD 9 and 10: the configure
> > script incorrectly concludes that FreeBSD doesn't have openpty(3), and
> > bsd-openpty.c doesn't build on FreeBSD. See http://www.des.no/openssh/
>
> So, config.log says:
>
> > configure:9158: gcc -o conftest -g -O2 -Wall -Wpointer-arith -Wuninitialized
> > -Wsign-compare -Wformat-security -Wno-pointer-sign -fno-strict-aliasing >
> > -D_FORTIFY_SOURCE=2 -fno-builtin-memset -fstack-protector-all >
> > -fstack-protector-all conftest.c -lz >&5
> > /tmp//ccnfm8sv.o: In function `main':
> > /home/des/src/openssh/conftest.c:137: undefined reference to `openpty'
>
> Does FreeBSD stick openpty in -lutil or somesuch?

According to the manpages it does. Could you please try this?

Index: configure.ac
===================================================================
RCS file: /var/cvs/openssh/configure.ac,v
retrieving revision 1.487
diff -u -p -r1.487 configure.ac
--- configure.ac 23 Feb 2012 23:40:43 -0000 1.487
+++ configure.ac 8 Mar 2012 23:45:57 -0000
@@ -1127,7 +1127,11 @@ dnl Checks for libutil functions
AC_CHECK_HEADERS([libutil.h])
AC_SEARCH_LIBS([login], [util bsd], [AC_DEFINE([HAVE_LOGIN], [1],
[Define if your libraries define login()])])
-AC_CHECK_FUNCS([fmt_scaled logout updwtmp logwtmp])
+AC_SEARCH_LIBS([logout], [util])
+AC_SEARCH_LIBS([updwtmp], [util])
+AC_SEARCH_LIBS([logwtmp], [util])
+AC_SEARCH_LIBS([fmt_scaled], [util])
+AC_SEARCH_LIBS([openpty], [util])

AC_FUNC_STRFTIME

@@ -1507,7 +1511,6 @@ AC_CHECK_FUNCS([ \
nsleep \
ogetaddrinfo \
openlog_r \
- openpty \
poll \
prctl \
pstat \
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

des at des

Mar 9, 2012, 3:30 AM

Post #16 of 24 (1082 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

Damien Miller <djm [at] mindrot> writes:
> Does FreeBSD stick openpty in -lutil or somesuch?

Yes, I thought I'd mentioned that - sorry if I didn't.

DES
--
Dag-Erling Smørgrav - des [at] des
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

des at des

Mar 9, 2012, 3:41 AM

Post #17 of 24 (1081 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

Damien Miller <djm [at] mindrot> writes:
> According to the manpages it does. Could you please try this?

If I apply the patch and run autoreconf, config.h.in no longer contains
an entry for HAVE_OPENPTY, so although the configure script finds
openpty() in libutil, it still tries to build bsd-compat/openpty.c.

DES
--
Dag-Erling Smørgrav - des [at] des
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

mr.dash.four at googlemail

Mar 9, 2012, 6:43 AM

Post #18 of 24 (1079 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

> According to the manpages it does. Could you please try this?
>
Not related to the above issue in particular, but I submitted a bug with
Fedora yesterday (see
https://bugzilla.redhat.com/show_bug.cgi?id=801633) - it prevents
cross-compilation/build of OpenSSH on "incompatible" platforms (i.e.
build=anything_86, host=arm or host=ppc for example) due to execution of
a binary (fips_standalone_sha1 - fips calculating hmac hashes) or
platforms with different versions of Lib C (say, glibc on "build" and
uclibc on "host").

The "solution" I proposed there is very ugly and I do not like it one
bit, though I have no idea how this can be resolved.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

mr.dash.four at googlemail

Mar 9, 2012, 6:50 AM

Post #19 of 24 (1080 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

Mr Dash Four wrote:
>
>> According to the manpages it does. Could you please try this?
>>
> Not related to the above issue in particular, but I submitted a bug
> with Fedora yesterday (see
> https://bugzilla.redhat.com/show_bug.cgi?id=801633) - it prevents
> cross-compilation/build of OpenSSH on "incompatible" platforms (i.e.
> build=anything_86, host=arm or host=ppc for example) due to execution
> of a binary (fips_standalone_sha1 - fips calculating hmac hashes) or
> platforms with different versions of Lib C (say, glibc on "build" and
> uclibc on "host").
>
> The "solution" I proposed there is very ugly and I do not like it one
> bit, though I have no idea how this can be resolved.
Scratch what I have just posted above - it is related to openssl, not
openssh - I must fully wake up before posting! Apologies for the noise!
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

djm at mindrot

Mar 12, 2012, 8:42 PM

Post #20 of 24 (1059 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

On Fri, 9 Mar 2012, Dag-Erling Sm?rgrav wrote:

> Damien Miller <djm [at] mindrot> writes:
> > According to the manpages it does. Could you please try this?
>
> If I apply the patch and run autoreconf, config.h.in no longer contains
> an entry for HAVE_OPENPTY, so although the configure script finds
> openpty() in libutil, it still tries to build bsd-compat/openpty.c.

okay, try this one please:

Index: configure.ac
===================================================================
RCS file: /var/cvs/openssh/configure.ac,v
retrieving revision 1.487
diff -u -p -r1.487 configure.ac
--- configure.ac 23 Feb 2012 23:40:43 -0000 1.487
+++ configure.ac 13 Mar 2012 03:41:46 -0000
@@ -1127,7 +1127,12 @@ dnl Checks for libutil functions
AC_CHECK_HEADERS([libutil.h])
AC_SEARCH_LIBS([login], [util bsd], [AC_DEFINE([HAVE_LOGIN], [1],
[Define if your libraries define login()])])
-AC_CHECK_FUNCS([fmt_scaled logout updwtmp logwtmp])
+AC_SEARCH_LIBS([logout], [util])
+AC_SEARCH_LIBS([updwtmp], [util])
+AC_SEARCH_LIBS([logwtmp], [util])
+AC_SEARCH_LIBS([fmt_scaled], [util])
+AC_SEARCH_LIBS([openpty], [util])
+AC_CHECK_FUNCS([fmt_scaled logout updwtmp logwtmp openpty])

AC_FUNC_STRFTIME

@@ -1507,7 +1512,6 @@ AC_CHECK_FUNCS([ \
nsleep \
ogetaddrinfo \
openlog_r \
- openpty \
poll \
prctl \
pstat \
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

des at des

Mar 13, 2012, 7:46 AM

Post #21 of 24 (1056 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

Damien Miller <djm [at] mindrot> writes:
> Dag-Erling Smørgrav <des [at] des> writes:
> > If I apply the patch and run autoreconf, config.h.in no longer contains
> > an entry for HAVE_OPENPTY, so although the configure script finds
> > openpty() in libutil, it still tries to build bsd-compat/openpty.c.
> okay, try this one please:

That fixes openpty - but now it fails to build loginrec.c. FreeBSD has
UTMPX, and config.h is correct in that respect, but it still tries to
build parts of loginrec.c that are [UW]TMP-specific.

See http://www.des.no/openssh/openssh-SNAP-20120313 for complete logs
and config.h.

DES
--
Dag-Erling Smørgrav - des [at] des
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

djm at mindrot

Apr 19, 2012, 5:32 AM

Post #22 of 24 (947 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

On Tue, 13 Mar 2012, Dag-Erling Sm?rgrav wrote:

> Damien Miller <djm [at] mindrot> writes:
> > Dag-Erling Sm?rgrav <des [at] des> writes:
> > > If I apply the patch and run autoreconf, config.h.in no longer contains
> > > an entry for HAVE_OPENPTY, so although the configure script finds
> > > openpty() in libutil, it still tries to build bsd-compat/openpty.c.
> > okay, try this one please:
>
> That fixes openpty - but now it fails to build loginrec.c. FreeBSD has
> UTMPX, and config.h is correct in that respect, but it still tries to
> build parts of loginrec.c that are [UW]TMP-specific.
>
> See http://www.des.no/openssh/openssh-SNAP-20120313 for complete logs
> and config.h.

I've finally got around to installing FreeBSD to reproduce this. A fix[1]
is in and will be in the 20120420 snapshot.

-d

[1] http://hg.mindrot.org/openssh/raw-rev/37678d290982
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

des at des

Apr 20, 2012, 5:06 AM

Post #23 of 24 (939 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

Damien Miller <djm [at] mindrot> writes:
> Dag-Erling Sm?rgrav <des [at] des> writes:
> > That fixes openpty - but now it fails to build loginrec.c. FreeBSD has
> > UTMPX, and config.h is correct in that respect, but it still tries to
> > build parts of loginrec.c that are [UW]TMP-specific.
> I've finally got around to installing FreeBSD to reproduce this. A fix[1]
> is in and will be in the 20120420 snapshot.

I just downloaded 20120420 and tried to build it; it fails in the exact
same place. Logs at <URL:http://www.des.no/openssh/openssh-SNAP-20120420>.

DES
--
Dag-Erling Smørgrav - des [at] des
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

djm at mindrot

Apr 21, 2012, 5:19 PM

Post #24 of 24 (935 views)
Permalink

Re: Call for testing: OpenSSH-6.0 [In reply to]

On Fri, 20 Apr 2012, Dag-Erling Sm?rgrav wrote:

> Damien Miller <djm [at] mindrot> writes:
> > Dag-Erling Sm?rgrav <des [at] des> writes:
> > > That fixes openpty - but now it fails to build loginrec.c. FreeBSD has
> > > UTMPX, and config.h is correct in that respect, but it still tries to
> > > build parts of loginrec.c that are [UW]TMP-specific.
> > I've finally got around to installing FreeBSD to reproduce this. A fix[1]
> > is in and will be in the 20120420 snapshot.
>
> I just downloaded 20120420 and tried to build it; it fails in the exact
> same place. Logs at <URL:http://www.des.no/openssh/openssh-SNAP-20120420>.

Actually, it's failing in loginrec.c now and not openpty() anymore.
It looks like it is failing to pick up that it should be using utmpx.

I reproduced the previous problem on FreeBSD 9, and it compiled without
error. I'll try to get a FreeBSD 10 VM up next week, but it will be too
late for the 6.0 release, sorry.

-d
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads