Mailing List Archive: OpenSSH: Dev

[PATCH] Remove setting IP_TOS_IS_BROKEN for Cygwin

Index | Next | Previous | View Threaded

vinschen at redhat

Mar 18, 2009, 8:07 AM

Post #1 of 2 (494 views)
Permalink

[PATCH] Remove setting IP_TOS_IS_BROKEN for Cygwin

Hi,

The problem that setsockopt(IP_TOS) doesn't work on Cygwin is long
fixed. Ages ago Microsoft changed the definition for IP_TOS when moving
from winsock1 to winsock2 and IP_TOS in Cygwin didn't work all these
years because nobody (that's especialy me) realized that we were still
using the old winsock1 value. This has been fixed since 2005, though.

Patch below.

Corinna

Index: configure.ac
===================================================================
RCS file: /cvs/openssh/configure.ac,v
retrieving revision 1.418
diff -u -p -r1.418 configure.ac
--- configure.ac 7 Mar 2009 11:22:35 -0000 1.418
+++ configure.ac 18 Mar 2009 15:03:02 -0000
@@ -434,8 +434,6 @@ int main(void) { exit(0); }
AC_DEFINE(USE_PIPES, 1, [Use PIPES instead of a socketpair()])
AC_DEFINE(DISABLE_SHADOW, 1,
[Define if you want to disable shadow passwords])
- AC_DEFINE(IP_TOS_IS_BROKEN, 1,
- [Define if your system choked on IP TOS setting])
AC_DEFINE(NO_X11_UNIX_SOCKETS, 1,
[Define if X11 doesn't support AF_UNIX sockets on that system])
AC_DEFINE(NO_IPPORT_RESERVED_CONCEPT, 1,

--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

tim at multitalents

Mar 18, 2009, 11:31 AM

Post #2 of 2 (469 views)
Permalink

Re: [PATCH] Remove setting IP_TOS_IS_BROKEN for Cygwin [In reply to]

On Wed, 18 Mar 2009, Corinna Vinschen wrote:

> Hi,
>
> The problem that setsockopt(IP_TOS) doesn't work on Cygwin is long
> fixed. Ages ago Microsoft changed the definition for IP_TOS when moving
> from winsock1 to winsock2 and IP_TOS in Cygwin didn't work all these
> years because nobody (that's especialy me) realized that we were still
> using the old winsock1 value. This has been fixed since 2005, though.
>
> Patch below.

The first AC_DEFINE needs a description.
Here is what I've commited
......
--- openssh/configure.ac.old 2009-03-17 07:51:51.111200008 -0700
+++ openssh/configure.ac 2009-03-18 11:25:02.000000000 -0700
@@ -434,8 +434,6 @@
AC_DEFINE(USE_PIPES, 1, [Use PIPES instead of a socketpair()])
AC_DEFINE(DISABLE_SHADOW, 1,
[Define if you want to disable shadow passwords])
- AC_DEFINE(IP_TOS_IS_BROKEN, 1,
- [Define if your system choked on IP TOS setting])
AC_DEFINE(NO_X11_UNIX_SOCKETS, 1,
[Define if X11 doesn't support AF_UNIX sockets on that system])
AC_DEFINE(NO_IPPORT_RESERVED_CONCEPT, 1,
@@ -446,7 +444,8 @@
file descriptor passing])
;;
*-*-dgux*)
- AC_DEFINE(IP_TOS_IS_BROKEN)
+ AC_DEFINE(IP_TOS_IS_BROKEN, 1,
+ [Define if your system choked on IP TOS setting])
AC_DEFINE(SETEUID_BREAKS_SETUID)
AC_DEFINE(BROKEN_SETREUID)
AC_DEFINE(BROKEN_SETREGID)
......

--
Tim Rice Multitalents (707) 887-1469
tim [at] multitalents

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads