Mailing List Archive: OpenSSH: Dev

openssh 5.2p1 fails to build on IRIX 5.3

Index | Next | Previous | View Threaded

tgc at jupiterrise

Mar 16, 2009, 1:17 PM

Post #1 of 8 (947 views)
Permalink

openssh 5.2p1 fails to build on IRIX 5.3

Hello,

I ran into a few problems when trying to build openssh 5.2p1 on IRIX 5.3.

First one is new to 5.2p1:
cc -I. -I. -I/usr/tgcware/include/openssl -I/usr/tgcware/include
-DSSHDIR=\"/usr/tgcware/etc/ssh\"
-D_PATH_SSH_PROGRAM=\"/usr/tgcware/bin/ssh\"
-D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/tgcware/libexec/ssh-askpass\"
-D_PATH_SFTP_SERVER=\"/usr/tgcware/libexec/sftp-server\"
-D_PATH_SSH_KEY_SIGN=\"/usr/tgcware/libexec/ssh-keysign\"
-D_PATH_SSH_PIDDIR=\"/var/run\"
-D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty/sshd\"
-DSSH_RAND_HELPER=\"/usr/tgcware/libexec/ssh-rand-helper\"
-DHAVE_CONFIG_H -c channels.c
cfe: Warning 581: /usr/include/sys/param.h:223: Macro MAXPATHLEN redefined.
cfe: Error: channels.c, line 2472: 'in_port_t' undefined; reoccurrences
will not be reported.
in_port_t *lport_p;
^
cfe: Error: channels.c, line 2546: 'lport_p' undefined; reoccurrences
will not be reported.
lport_p = &((struct sockaddr_in *)ai->ai_addr)->
^
cfe: Error: channels.c, line 2562: 'lport_p' undefined; reoccurrences
will not be reported.
*lport_p = (*allocated_listen_port) ;
-^
make: *** [channels.o] Error 1

IRIX 5.3 does not define in_port_t in <netinet/in.h> instead it uses
ushort for sockaddr_in.sin_port.
In other parts of openssh users of sin_port either use ushort or
u_int16_t instead of in_port_t.

The second problem has been around since 4.7p1 and is only present when
building with the old SGI compiler:
cc -I. -I. -I/usr/tgcware/include/openssl -I/usr/tgcware/include
-DSSHDIR=\"/usr/tgcware/etc/ssh\"
-D_PATH_SSH_PROGRAM=\"/usr/tgcware/bin/ssh\"
-D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/tgcware/libexec/ssh-askpass\"
-D_PATH_SFTP_SERVER=\"/usr/tgcware/libexec/sftp-server\"
-D_PATH_SSH_KEY_SIGN=\"/usr/tgcware/libexec/ssh-keysign\"
-D_PATH_SSH_PIDDIR=\"/var/run\"
-D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty/sshd\"
-DSSH_RAND_HELPER=\"/usr/tgcware/libexec/ssh-rand-helper\"
-DHAVE_CONFIG_H -c atomicio.c
cfe: Warning 581: /usr/include/sys/param.h:223: Macro MAXPATHLEN redefined.
cfe: Error: atomicio.c, line 102: Unacceptable operand of == or !=
pfd.events = f == readv ? 0x0001 : 0x0004 ;
---------------^
make: *** [atomicio.o] Error 1

The code is gibberish to me but since GCC has no issues I assume it's
the compiler being difficult and not a problem with the intent of the
code.
Is there perhaps another way to write this that the SGI compiler would
be more likely to grok?

-tgc
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

tim at multitalents

Mar 16, 2009, 3:33 PM

Post #2 of 8 (909 views)
Permalink

Re: openssh 5.2p1 fails to build on IRIX 5.3 [In reply to]

On Mon, 16 Mar 2009, Tom Christensen wrote:

> Hello,
>
> I ran into a few problems when trying to build openssh 5.2p1 on IRIX 5.3.
>
> First one is new to 5.2p1:
[snip]
> cfe: Error: channels.c, line 2472: 'in_port_t' undefined; reoccurrences
> will not be reported.
> in_port_t *lport_p;
> ^
[snip]

Please try the attached in_port_t.patch and report back.
You'll need to run autoreconf with version 2.61 or better.
If you don't have an up to date autoconf, apply the
attached optional-part2.patch.

I haven't looked at the second probelm yet.

--
Tim Rice Multitalents (707) 887-1469
tim [at] multitalents

Attachments:

in_port_t.patch (0.65 KB)

optional-part2.patch (2.18 KB)

tgc at jupiterrise

Mar 17, 2009, 12:01 AM

Post #3 of 8 (921 views)
Permalink

Re: openssh 5.2p1 fails to build on IRIX 5.3 [In reply to]

Tim Rice wrote:
> On Mon, 16 Mar 2009, Tom Christensen wrote:
>
>> Hello,
>>
>> I ran into a few problems when trying to build openssh 5.2p1 on IRIX 5.3.
>>
>> First one is new to 5.2p1:
> [snip]
>> cfe: Error: channels.c, line 2472: 'in_port_t' undefined; reoccurrences
>> will not be reported.
>> in_port_t *lport_p;
>> ^
> [snip]
>
> Please try the attached in_port_t.patch and report back.
> You'll need to run autoreconf with version 2.61 or better.
> If you don't have an up to date autoconf, apply the
> attached optional-part2.patch.
>
Applied and ran autoreconf.

It detects that in_port_t is missing and channels.c compiles without
problems now.

-tgc
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

tim at multitalents

Mar 17, 2009, 8:14 AM

Post #4 of 8 (914 views)
Permalink

Re: openssh 5.2p1 fails to build on IRIX 5.3 [In reply to]

On Tue, 17 Mar 2009, Tom Christensen wrote:

> Tim Rice wrote:
> > On Mon, 16 Mar 2009, Tom Christensen wrote:
> >
[snip]
> > > cfe: Error: channels.c, line 2472: 'in_port_t' undefined; reoccurrences
> > > will not be reported.
> > > in_port_t *lport_p;
> > > ^
> > [snip]
> >
> > Please try the attached in_port_t.patch and report back.
> > You'll need to run autoreconf with version 2.61 or better.
> > If you don't have an up to date autoconf, apply the attached
> > optional-part2.patch.
> >
> Applied and ran autoreconf.
>
> It detects that in_port_t is missing and channels.c compiles without problems
> now.

I should have sync'd my tree befor posting. It looks like Darren
commited a nearly identical patch on the 7th. He used a slightly
different typedef in defines.h.
Does
#ifndef HAVE_IN_PORT_T
typedef u_int16_t in_port_t;
#endif
work for you in defines.h?

> -tgc
>
>

--
Tim Rice Multitalents (707) 887-1469
tim [at] multitalents

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

tgc at jupiterrise

Mar 17, 2009, 9:34 AM

Post #5 of 8 (907 views)
Permalink

Re: openssh 5.2p1 fails to build on IRIX 5.3 [In reply to]

Tim Rice wrote:
> On Tue, 17 Mar 2009, Tom Christensen wrote:
>
>> Tim Rice wrote:
>>> On Mon, 16 Mar 2009, Tom Christensen wrote:
>>>
> [snip]
>>>> cfe: Error: channels.c, line 2472: 'in_port_t' undefined; reoccurrences
>>>> will not be reported.
>>>> in_port_t *lport_p;
>>>> ^
>>> [snip]
>>>
>>> Please try the attached in_port_t.patch and report back.
>>> You'll need to run autoreconf with version 2.61 or better.
>>> If you don't have an up to date autoconf, apply the attached
>>> optional-part2.patch.
>>>
>> Applied and ran autoreconf.
>>
>> It detects that in_port_t is missing and channels.c compiles without problems
>> now.
>
> I should have sync'd my tree befor posting. It looks like Darren
> commited a nearly identical patch on the 7th. He used a slightly
> different typedef in defines.h.
> Does
> #ifndef HAVE_IN_PORT_T
> typedef u_int16_t in_port_t;
> #endif
> work for you in defines.h?
>
Yes.
Before you posted your patch I had already built it with in_port_t
replaced with u_uint16_t and it's working as expected.

-tgc
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

tim at multitalents

Mar 17, 2009, 11:49 AM

Post #6 of 8 (899 views)
Permalink

Re: openssh 5.2p1 fails to build on IRIX 5.3 [In reply to]

On Tue, 17 Mar 2009, Tom Christensen wrote:

> Tim Rice wrote:
> > Does
> > #ifndef HAVE_IN_PORT_T
> > typedef u_int16_t in_port_t;
> > #endif
> > work for you in defines.h?
> >
> Yes.
> Before you posted your patch I had already built it with in_port_t replaced
> with u_uint16_t and it's working as expected.

Good, that is what is in the current snapshots.
Thanks.

--
Tim Rice Multitalents (707) 887-1469
tim [at] multitalents

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

tim at multitalents

Mar 18, 2009, 10:07 AM

Post #7 of 8 (884 views)
Permalink

Re: openssh 5.2p1 fails to build on IRIX 5.3 [In reply to]

On Mon, 16 Mar 2009, Tom Christensen wrote:

> The second problem has been around since 4.7p1 and is only present when
> building with the old SGI compiler:
> cfe: Error: atomicio.c, line 102: Unacceptable operand of == or !=
> pfd.events = f == readv ? 0x0001 : 0x0004 ;
> ---------------^
> make: *** [atomicio.o] Error 1
>
> The code is gibberish to me but since GCC has no issues I assume it's
> the compiler being difficult and not a problem with the intent of the
> code.
> Is there perhaps another way to write this that the SGI compiler would
> be more likely to grok?

Does your compiler like this any better?
pfd.events = (f == readv) ? 0x0001 : 0x0004 ;

--
Tim Rice Multitalents (707) 887-1469
tim [at] multitalents

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

tgc at jupiterrise

Mar 18, 2009, 1:06 PM

Post #8 of 8 (885 views)
Permalink

Re: openssh 5.2p1 fails to build on IRIX 5.3 [In reply to]

Tim Rice wrote:
> On Mon, 16 Mar 2009, Tom Christensen wrote:
>
>> The second problem has been around since 4.7p1 and is only present when
>> building with the old SGI compiler:
>> cfe: Error: atomicio.c, line 102: Unacceptable operand of == or !=
>> pfd.events = f == readv ? 0x0001 : 0x0004 ;
>> ---------------^
>> make: *** [atomicio.o] Error 1
>>
>> The code is gibberish to me but since GCC has no issues I assume it's
>> the compiler being difficult and not a problem with the intent of the
>> code.
>> Is there perhaps another way to write this that the SGI compiler would
>> be more likely to grok?
>
> Does your compiler like this any better?
> pfd.events = (f == readv) ? 0x0001 : 0x0004 ;
>
No it makes no difference.

cfe: Error: atomicio.c, line 102: Unacceptable operand of == or !=
pfd.events = (f == readv) ? 0x0001 : 0x0004 ;
----------------^

I notice that this error seems very very similar to bz#1386.

-tgc
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev [at] mindrot
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads