Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: NTop: Users

rrdPlugin.c incorrect preset values

 

 

NTop users RSS feed   Index | Next | Previous | View Threaded


sclark at netwolves

Jan 19, 2010, 12:53 PM

Post #1 of 2 (308 views)
Permalink
rrdPlugin.c incorrect preset values

Hi,

in the rrdPlugin.c function listResource
the preset code is wrong for last 6 hours and last hour it currently
has:

safe_snprintf(__FILE__, __LINE__, buf, sizeof(buf), "<option value=\"%s&start=%u%s\">Last 6h</option>\n", url, now - 6 * 86400, filter);
sendString(buf);
safe_snprintf(__FILE__, __LINE__, buf, sizeof(buf), "<option value=\"%s&start=%u%s\">Last Hour</option>\n", url, now - 86400, filter);

it should be:

safe_snprintf(__FILE__, __LINE__, buf, sizeof(buf), "<option value=\"%s&start=%u%s\">Last 6h</option>\n", url,now - 6 * 3600, filter);
sendString(buf);
safe_snprintf(__FILE__, __LINE__, buf, sizeof(buf), "<option value=\"%s&start=%u%s\">Last Hour</option>\n", url, now - 3600, filter)


--
Stephen Clark
NetWolves
Sr. Software Engineer III
Phone: 813-579-3200
Fax: 813-882-0209
Email: steve.clark [at] netwolves
www.netwolves.com
_______________________________________________
Ntop mailing list
Ntop [at] listgateway
http://listgateway.unipi.it/mailman/listinfo/ntop


Ggatten at waddell

Jan 19, 2010, 1:07 PM

Post #2 of 2 (269 views)
Permalink
Re: rrdPlugin.c incorrect preset values [In reply to]

Are those the only two presets that are incorrect that you've noticed. I noted the same/similar issues long ago, but can't remember if it was just those two or not. Also, there's an ntop-dev list (I think) you may want to include with these types of issues.

----- Original Message -----
From: ntop-bounces [at] listgateway <ntop-bounces [at] listgateway>
To: ntop [at] unipi <ntop [at] unipi>
Sent: Tue Jan 19 14:53:22 2010
Subject: [Ntop] rrdPlugin.c incorrect preset values

Hi,

in the rrdPlugin.c function listResource
the preset code is wrong for last 6 hours and last hour it currently
has:

safe_snprintf(__FILE__, __LINE__, buf, sizeof(buf), "<option value=\"%s&start=%u%s\">Last 6h</option>\n", url, now - 6 * 86400, filter);
sendString(buf);
safe_snprintf(__FILE__, __LINE__, buf, sizeof(buf), "<option value=\"%s&start=%u%s\">Last Hour</option>\n", url, now - 86400, filter);

it should be:

safe_snprintf(__FILE__, __LINE__, buf, sizeof(buf), "<option value=\"%s&start=%u%s\">Last 6h</option>\n", url,now - 6 * 3600, filter);
sendString(buf);
safe_snprintf(__FILE__, __LINE__, buf, sizeof(buf), "<option value=\"%s&start=%u%s\">Last Hour</option>\n", url, now - 3600, filter)


--
Stephen Clark
NetWolves
Sr. Software Engineer III
Phone: 813-579-3200
Fax: 813-882-0209
Email: steve.clark [at] netwolves
www.netwolves.com
_______________________________________________
Ntop mailing list
Ntop [at] listgateway
http://listgateway.unipi.it/mailman/listinfo/ntop





<font size="1">
<div style='border:none;border-bottom:double windowtext 2.25pt;padding:0in 0in 1.0pt 0in'>
</div>
"This email is intended to be reviewed by only the intended recipient
and may contain information that is privileged and/or confidential.
If you are not the intended recipient, you are hereby notified that
any review, use, dissemination, disclosure or copying of this email
and its attachments, if any, is strictly prohibited. If you have
received this email in error, please immediately notify the sender by
return email and delete this email from your system."
</font>

NTop users RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.