Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: NTop: Misc

Bug in userland/lib/pfring_mod_dna.c

 

 

NTop misc RSS feed   Index | Next | Previous | View Threaded


dprovan at bivio

Jun 1, 2012, 3:24 PM

Post #1 of 2 (187 views)
Permalink
Bug in userland/lib/pfring_mod_dna.c

It took me a while to run into this typo -- it's been in the code since
5.3 -- but when I ran the right test with my software, I got a segfault.
-don provan
dprovan [at] bivio

$ diff -u pfring_mod_dna.c.orig pfring_mod_dna.c
--- pfring_mod_dna.c.orig 2012-05-07 15:30:18.000000000 -0700
+++ pfring_mod_dna.c 2012-06-01 15:14:33.000000000 -0700
@@ -71,7 +71,7 @@

for(i=0; i<ring->dna.dna_dev.mem_info.tx.packet_memory_num_chunks;
i++)
if(ring->dna.dna_dev.tx_packet_memory[i] != 0)
- munmap((void*)ring->dna.dna_dev.tx_packet_memory,
+ munmap((void*)ring->dna.dna_dev.tx_packet_memory[i],
ring->dna.dna_dev.mem_info.tx.packet_memory_chunk_len);

if(ring->dna.dna_dev.tx_descr_packet_memory != NULL)
_______________________________________________
Ntop-misc mailing list
Ntop-misc [at] listgateway
http://listgateway.unipi.it/mailman/listinfo/ntop-misc


cardigliano at ntop

Jun 2, 2012, 1:04 AM

Post #2 of 2 (162 views)
Permalink
Re: Bug in userland/lib/pfring_mod_dna.c [In reply to]

Fixed in svn

Thank you
Alfredo

On Jun 2, 2012, at 12:24 AM, Don Provan wrote:

> It took me a while to run into this typo -- it's been in the code since
> 5.3 -- but when I ran the right test with my software, I got a segfault.
> -don provan
> dprovan [at] bivio
>
> $ diff -u pfring_mod_dna.c.orig pfring_mod_dna.c
> --- pfring_mod_dna.c.orig 2012-05-07 15:30:18.000000000 -0700
> +++ pfring_mod_dna.c 2012-06-01 15:14:33.000000000 -0700
> @@ -71,7 +71,7 @@
>
> for(i=0; i<ring->dna.dna_dev.mem_info.tx.packet_memory_num_chunks;
> i++)
> if(ring->dna.dna_dev.tx_packet_memory[i] != 0)
> - munmap((void*)ring->dna.dna_dev.tx_packet_memory,
> + munmap((void*)ring->dna.dna_dev.tx_packet_memory[i],
> ring->dna.dna_dev.mem_info.tx.packet_memory_chunk_len);
>
> if(ring->dna.dna_dev.tx_descr_packet_memory != NULL)
> _______________________________________________
> Ntop-misc mailing list
> Ntop-misc [at] listgateway
> http://listgateway.unipi.it/mailman/listinfo/ntop-misc

_______________________________________________
Ntop-misc mailing list
Ntop-misc [at] listgateway
http://listgateway.unipi.it/mailman/listinfo/ntop-misc

NTop misc RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.