Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: MythTV: Users

0.22 upgrade makes people searches case-sensitive

 

 

MythTV users RSS feed   Index | Next | Previous | View Threaded


mbrehon at comcast

Nov 19, 2009, 6:19 PM

Post #1 of 18 (701 views)
Permalink
0.22 upgrade makes people searches case-sensitive

A recent change has rendered most of my people searches (not checked the
other types) useless as they are all completely lower case. I did
upgrade last weekend from 0.21-fixes to 0.22 on my gentoo systems,
though I can't say with 100% certainty that that's when it changed. Is
there a setting somewhere in either mythtv or mysql that can affect this?

thanks,
-Mark
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


dibblah.allan.stirling at googlemail

Nov 20, 2009, 12:30 AM

Post #2 of 18 (667 views)
Permalink
Re: 0.22 upgrade makes people searches case-sensitive [In reply to]

Mark Brehon wrote:
> A recent change has rendered most of my people searches (not checked the
> other types) useless as they are all completely lower case. I did
> upgrade last weekend from 0.21-fixes to 0.22 on my gentoo systems,
> though I can't say with 100% certainty that that's when it changed. Is
> there a setting somewhere in either mythtv or mysql that can affect this?

This is only affected by the collation used, not by anything
within Myth.

http://dev.mysql.com/doc/refman/5.0/en/case-sensitivity.html

Cheers,

Allan.
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


mtdean at thirdcontact

Nov 20, 2009, 7:14 AM

Post #3 of 18 (656 views)
Permalink
Re: 0.22 upgrade makes people searches case-sensitive [In reply to]

On 11/20/2009 03:30 AM, Allan Stirling wrote:
> Mark Brehon wrote:
>> A recent change has rendered most of my people searches (not checked the
>> other types) useless as they are all completely lower case. I did
>> upgrade last weekend from 0.21-fixes to 0.22 on my gentoo systems,
>> though I can't say with 100% certainty that that's when it changed. Is
>> there a setting somewhere in either mythtv or mysql that can affect
>> this?
> This is only affected by the collation used, not by anything within Myth.
>
> http://dev.mysql.com/doc/refman/5.0/en/case-sensitivity.html

The columns were made case-sensitive initially due to the fact that the
database encoding we used prior to 0.22 did not give case-insensitive
collation of non-ASCII characters, so the approach Janne used was the
only one that would work (see http://cvs.mythtv.org/trac/changeset/16755 ).

I may eventually convert that column (and several others) to a
case-insensitive collation, but it's a low-priority change. I offered
to do such a change before 0.22 was released, but it was decided that it
wasn't that important. (See http://svn.mythtv.org/trac/ticket/5957 )

Changing to support case-insensitive people names is a lot of work--it
requires identifying the duplicates /and/ fixing all foreign references
to the removed records. And, even if the devs decide it's worth
changing, it will /not/ get changed in 0.22-fixes (as it involves
modifying the DB schema).

Therefore, please do not change the database schema yourself because a)
it will break future upgrades, and b) you would have to properly
re-reference all the foreign data that references removed rows.

So, basically, fix your people searches to work with the new
(only-new-to-ASCII-only names) approach.

Unless you have really a bad listings data provider, it shouldn't be too
difficult to guess the capitalization that will be used (with a few
exceptions for names like Dylan McDermott or Erich von Stroheim or ...
which can be handled with additional searches if you're that
concerned). But, since you're used to the ASCII-only behavior and based
on your e-mail address, I'm guessing you're in North America and,
therefore, using Schedules Direct--so your data quality is good. That
means the only change is you have to capitalize names properly when
typing them in. :)

Mike
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


f-myth-users at media

Nov 20, 2009, 6:53 PM

Post #4 of 18 (630 views)
Permalink
0.22 upgrade makes people searches case-sensitive [In reply to]

Is there some easy way for users to figure out which elements of
Myth's UI are case-sensitive, and which aren't? For example, are
-all- other 0.22 DB columns case-sensitive? (Then there's the
issue of command-line options, of course.)
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


mtdean at thirdcontact

Nov 20, 2009, 7:33 PM

Post #5 of 18 (642 views)
Permalink
Re: 0.22 upgrade makes people searches case-sensitive [In reply to]

On 11/20/2009 09:53 PM, f-myth-users [at] media wrote:
> Is there some easy way for users to figure out which elements of
> Myth's UI are case-sensitive, and which aren't? For example, are
> -all- other 0.22 DB columns case-sensitive? (Then there's the
> issue of command-line options, of course.)

See the changeset I linked which lists all of them.

Mike
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


mtdean at thirdcontact

Nov 20, 2009, 7:37 PM

Post #6 of 18 (631 views)
Permalink
Re: 0.22 upgrade makes people searches case-sensitive [In reply to]

On 11/20/2009 09:53 PM, f-myth-users [at] media wrote:
> (Then there's the
> issue of command-line options, of course.)

Oh, and if you mean the settings names used with overrides (which are
not meant for general use, anyway), not anymore.
http://svn.mythtv.org/trac/changeset/22779

Mike
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


f-myth-users at media

Nov 20, 2009, 8:23 PM

Post #7 of 18 (623 views)
Permalink
0.22 upgrade makes people searches case-sensitive [In reply to]

> Date: Fri, 20 Nov 2009 22:33:01 -0500
> From: "Michael T. Dean" <mtdean [at] thirdcontact>

> On 11/20/2009 09:53 PM, f-myth-users [at] media wrote:
> > Is there some easy way for users to figure out which elements of
> > Myth's UI are case-sensitive, and which aren't? For example, are
> > -all- other 0.22 DB columns case-sensitive? (Then there's the
> > issue of command-line options, of course.)

> See the changeset I linked which lists all of them.

...so to be clearer: Are there any places where a user might sensibly
type in a random-case string (e.g., in a power search or the like)
where case-sensitivity might cause a match failure, and are those
places (if any) documented somewhere that users are likely to find
them? Nobody's going to just randomly find that changeset.

(Looking at that changeset doesn't immediately make me think that
case-sensitivity is going to be a problem, but I probably wouldn't
notice it from a cursory scan.)
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


f-myth-users at media

Nov 20, 2009, 8:29 PM

Post #8 of 18 (630 views)
Permalink
0.22 upgrade makes people searches case-sensitive [In reply to]

> Date: Fri, 20 Nov 2009 22:37:55 -0500
> From: "Michael T. Dean" <mtdean [at] thirdcontact>

> On 11/20/2009 09:53 PM, f-myth-users [at] media wrote:
> > (Then there's the
> > issue of command-line options, of course.)

> Oh, and if you mean the settings names used with overrides (which are
> not meant for general use, anyway), not anymore.
> http://svn.mythtv.org/trac/changeset/22779

Ah. I'm on -commits, but the comment for that commit makes absolutely
no mention of that. Inspection of the code finds some toLower's that
I assume are doing this (I haven't compared to the previous version
of the code since those change regions are large).

So I take it that all of these will now work? If so, that's much
friendlier than the old regime.

mythfrontend -O ThemePainter=OpenGL
mythfrontend -O ThemePainter=opengl
mythfrontend -O themepainter=OpenGL
mythfrontend -O themepainter=opengl

Is this going to be documented somewhere?
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


robert.mcnamara at gmail

Nov 20, 2009, 8:35 PM

Post #9 of 18 (623 views)
Permalink
Re: 0.22 upgrade makes people searches case-sensitive [In reply to]

On Fri, Nov 20, 2009 at 8:29 PM, <f-myth-users [at] media> wrote:
>
> Is this going to be documented somewhere?


http://www.mythtv.org/wiki/

Let us know the page once you're done.

Robert
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


f-myth-users at media

Nov 20, 2009, 8:43 PM

Post #10 of 18 (624 views)
Permalink
0.22 upgrade makes people searches case-sensitive [In reply to]

> Date: Fri, 20 Nov 2009 20:35:25 -0800
> From: Robert McNamara <robert.mcnamara [at] gmail>

> On Fri, Nov 20, 2009 at 8:29 PM, <f-myth-users [at] media> wrote:
> >
> > Is this going to be documented somewhere?

> http://www.mythtv.org/wiki/

> Let us know the page once you're done.

(a) I can't make the change until I know what's true.
(b) I don't know if this is deemed important for release notes,
which I don't write.
(c) I thought the wiki documented released versions, not trunk.
If that's true, I -shouldn't- make the change, because this
change isn't IN a released version yet. (Hence "going to"
as in, "is there a list of things that somebody's keeping
to try to remember to update the doc with once 0.23 is released?")
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


robert.mcnamara at gmail

Nov 20, 2009, 8:46 PM

Post #11 of 18 (628 views)
Permalink
Re: 0.22 upgrade makes people searches case-sensitive [In reply to]

On Fri, Nov 20, 2009 at 8:43 PM, <f-myth-users [at] media> wrote:
>    > Date: Fri, 20 Nov 2009 20:35:25 -0800
>    > From: Robert McNamara <robert.mcnamara [at] gmail>
>
>    > On Fri, Nov 20, 2009 at 8:29 PM,  <f-myth-users [at] media> wrote:
>    > >
>    > > Is this going to be documented somewhere?
>
>    > http://www.mythtv.org/wiki/
>
>    > Let us know the page once you're done.
>
>< laundry list of reasons not to do it oneself>
>

So I guess the answer to "Is this going to be documented somewhere?"
is "No," then.

The answer to "do these all work," is "yes," however.

Robert
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


mtdean at thirdcontact

Nov 20, 2009, 8:51 PM

Post #12 of 18 (631 views)
Permalink
Re: 0.22 upgrade makes people searches case-sensitive [In reply to]

On 11/20/2009 11:29 PM, f-myth-users [at] media wrote:
> > Date: Fri, 20 Nov 2009 22:37:55 -0500
> > From: "Michael T. Dean" <mtdean [at] thirdcontact>
>
> > On 11/20/2009 09:53 PM, f-myth-users [at] media wrote:
> > > (Then there's the
> > > issue of command-line options, of course.)
>
> > Oh, and if you mean the settings names used with overrides (which are
> > not meant for general use, anyway), not anymore.
> > http://svn.mythtv.org/trac/changeset/22779
>
> Ah. I'm on -commits, but the comment for that commit makes absolutely
> no mention of that. Inspection of the code finds some toLower's that
> I assume are doing this (I haven't compared to the previous version
> of the code since those change regions are large).
>
> So I take it that all of these will now work? If so, that's much
> friendlier than the old regime.
>
> mythfrontend -O ThemePainter=OpenGL
> mythfrontend -O ThemePainter=opengl
> mythfrontend -O themepainter=OpenGL
> mythfrontend -O themepainter=opengl
>
> Is this going to be documented somewhere?

Only names are case insensitive. Values are--as they always have
been--case sensitive. Some values /must/ be case sensitive (such as
those containing file/path information) and there's really nothing to
distinguish them from ones that don't need to be, so we can't just
toLower() everything. And, IMHO, it's not worth the effort to add--let
alone maintain--the extra code required to allow a way to identify some
settings as case-sensitive values and others as case-insensitive.

The settings overrides are /not/ designed to be user-friendly. They're
really designed as a means of temporarily changing a value when
something bad happens. Note, also, that mythfrontend --help doesn't
list any of the -O settings names you can use. Therefore, it requires a
knowledge of code to use them, and using them properly requires a very
good understanding of the code. (If you don't believe me, try
overriding the NoPromptOnExit for mythfrontend.)

I don't think you'd argue that a new user isn't going to intuit that if
they change the theme painter to OpenGL and then restart mythfrontend
and it doesn't start that they need to restart with:

mythfrontend -O ThemePainter=qt

And, it's not the case-sensitivity that's preventing that. Instead,
they're going to have to do a search or or ask on IRC or something.
When doing so, they should get the proper command to copy/paste to fix
things up. Therefore, I would argue, it's just not worth the extra code.

Mike
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


f-myth-users at media

Nov 20, 2009, 8:56 PM

Post #13 of 18 (619 views)
Permalink
0.22 upgrade makes people searches case-sensitive [In reply to]

> Date: Fri, 20 Nov 2009 20:46:29 -0800
> From: Robert McNamara <robert.mcnamara [at] gmail>

> >< laundry list of reasons not to do it oneself>

...which, as far as I know, are all valid. Or are you saying that I
should have taken it upon myself to put unverified-and-possibly-false
information about an unreleased version into the wiki that's supposed
to have true statements about released versions?

> So I guess the answer to "Is this going to be documented somewhere?"
> is "No," then.

Wrong. At least I got it documented -on the list-, which was part of
what I was getting at---a user-visible change in options was made with
no mention on any of the 3 lists. There was absolutely no way that a
random user searching the lists would have therefore discovered it---
which was why I asked if it was planned to be documented, ever, anywhere.

Of course, expecting people to find it in an apparently-unrelated
thread isn't exactly user-friendly, either, but maybe they will.

> The answer to "do these all work," is "yes," however.

Good to know.
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


mtdean at thirdcontact

Nov 20, 2009, 8:56 PM

Post #14 of 18 (631 views)
Permalink
Re: 0.22 upgrade makes people searches case-sensitive [In reply to]

On 11/20/2009 11:23 PM, f-myth-users [at] media wrote:
> > Date: Fri, 20 Nov 2009 22:33:01 -0500
> > From: "Michael T. Dean" <mtdean [at] thirdcontact>
>
> > On 11/20/2009 09:53 PM, f-myth-users [at] media wrote:
> > > Is there some easy way for users to figure out which elements of
> > > Myth's UI are case-sensitive, and which aren't? For example, are
> > > -all- other 0.22 DB columns case-sensitive? (Then there's the
> > > issue of command-line options, of course.)
>
> > See the changeset I linked which lists all of them.
>
> ...so to be clearer: Are there any places where a user might sensibly
> type in a random-case string (e.g., in a power search or the like)
> where case-sensitivity might cause a match failure, and are those
> places (if any) documented somewhere that users are likely to find
> them?

Not really.

> Nobody's going to just randomly find that changeset.
>
> (Looking at that changeset doesn't immediately make me think that
> case-sensitivity is going to be a problem, but I probably wouldn't
> notice it from a cursory scan.)

Yeah, it only really has a direct effect on the user for keyword and
people searches.

Mike
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


robert.mcnamara at gmail

Nov 20, 2009, 8:57 PM

Post #15 of 18 (627 views)
Permalink
Re: 0.22 upgrade makes people searches case-sensitive [In reply to]

On Fri, Nov 20, 2009 at 8:56 PM, <f-myth-users [at] media> wrote:
>    > Date: Fri, 20 Nov 2009 20:46:29 -0800
>    > From: Robert McNamara <robert.mcnamara [at] gmail>
>
>    > >< laundry list of reasons not to do it oneself>
>
> ...which, as far as I know, are all valid.  Or are you saying that I
> should have taken it upon myself to put unverified-and-possibly-false
> information about an unreleased version into the wiki that's supposed
> to have true statements about released versions?
>
>    > So I guess the answer to "Is this going to be documented somewhere?"
>    > is "No," then.
>
> Wrong.  At least I got it documented -on the list-, which was part of
> what I was getting at---a user-visible change in options was made with
> no mention on any of the 3 lists.  There was absolutely no way that a
> random user searching the lists would have therefore discovered it---
> which was why I asked if it was planned to be documented, ever, anywhere.

Nice work. Except the overrides aren't meant to be daily use
features. But hey, I'm happy you're happy.

Robert
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


mtdean at thirdcontact

Nov 20, 2009, 9:00 PM

Post #16 of 18 (625 views)
Permalink
Re: 0.22 upgrade makes people searches case-sensitive [In reply to]

On 11/20/2009 11:56 PM, f-myth-users [at] media wrote:
> Wrong. At least I got it documented -on the list-, which was part of
> what I was getting at---a user-visible change in options was made with
> no mention on any of the 3 lists.

Again, though, a change to something people shouldn't be using--except
in the rare circumstances they break something.

I'm a people, too--I shouldn't be using them, so I don't. That's why we
have that nice UI for changing settings values.

Mike
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


f-myth-users at media

Nov 20, 2009, 9:15 PM

Post #17 of 18 (630 views)
Permalink
0.22 upgrade makes people searches case-sensitive [In reply to]

> Date: Fri, 20 Nov 2009 23:51:39 -0500
> From: "Michael T. Dean" <mtdean [at] thirdcontact>

> Only names are case insensitive. Values are--as they always have
> been--case sensitive.

Okay, now I'm confused, because you and Robert seem to be saying
different things. His response seems to indicate that all four
possibilities in the 2x2 crossbar would work; yours indicates
(I think!) that only these will work correctly:
mythfrontend -O ThemePainter=opengl
mythfrontend -O themepainter=opengl

The reason I asked, btw, is because these options are typically used
during debugging and, if I understand correctly, getting it wrong
means they're silently ignored---we saw that when this first came
up, because some user got it wrong on both sides of the equals sign.
Having options silently ignored due to case issues (especially when
the rules were different on the LHS vs the RHS) is a good way to
really raise the debugger's cognitive load---never a good thing.
[.And it slows him down 'cause he has to ask for help, and raises
the traffic on the list...]

> Some values /must/ be case sensitive (such as
> those containing file/path information) and there's really nothing to

Right.

> distinguish them from ones that don't need to be, so we can't just

Well, unless we had some sort of flag indicating that, but that'd be
quite a complication to the code I assume. (I haven't looked into
how many places need to know.)

> toLower() everything. And, IMHO, it's not worth the effort to add--let
> alone maintain--the extra code required to allow a way to identify some
> settings as case-sensitive values and others as case-insensitive.

Certainly I think there'd be more leverage in documenting it instead.

> The settings overrides are /not/ designed to be user-friendly. They're
> really designed as a means of temporarily changing a value when
> something bad happens. Note, also, that mythfrontend --help doesn't
> list any of the -O settings names you can use. Therefore, it requires a
> knowledge of code to use them, and using them properly requires a very
> good understanding of the code. (If you don't believe me, try
> overriding the NoPromptOnExit for mythfrontend.)

I believe you---I was just trying to figure out if there was a way of
making the life of someone trying to debug (therefore using them) easier.

> I don't think you'd argue that a new user isn't going to intuit that if
> they change the theme painter to OpenGL and then restart mythfrontend
> and it doesn't start that they need to restart with:

> mythfrontend -O ThemePainter=qt

No, but the case distinctions are easy to miss and/or mess up, and
we've seen that. If there was an easy way to keep the user from
shooting himself in the foot, it seemed to be a nice thing to do.
(And it seems like the changeset you pointed to was exactly that
"easy and keeps the user from shooting himself" sort of thing.)

> And, it's not the case-sensitivity that's preventing that. Instead,
> they're going to have to do a search or or ask on IRC or something.
> When doing so, they should get the proper command to copy/paste to fix
> things up. Therefore, I would argue, it's just not worth the extra code.

"Extra code" here means making values case-insensitive, right?

Yeah, probably not worth extra code, especially if some values must be
case-sensitive and the code has no way to know which. But at least
wherever this sort of stuff -is- documented (e.g., in a "how to debug
problems with Myth" sort of document), you'd hope that things that are
(or aren't!) case-sensitive get called out, so the user knows where
to be careful and where he doesn't have to be. (I don't necessarily
count "searching the archives" as that sort of documentation, because
it's so hit-or-miss, especially because it's so hard to tell if
something was wrong-as-stated, right-once-but-wrong-now (superceded),
or if you've simply missed it entirely because you didn't use the
right search terms. So I was thinking of the wiki or the release
notes or something when I asked "documented".)

[.I also didn't think it'd turn into this much of a conversation,
really. It seemed like a simple question with a simple answer.
*sigh*]
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


f-myth-users at media

Nov 20, 2009, 9:22 PM

Post #18 of 18 (622 views)
Permalink
0.22 upgrade makes people searches case-sensitive [In reply to]

> Date: Fri, 20 Nov 2009 23:56:29 -0500
> From: "Michael T. Dean" <mtdean [at] thirdcontact>

> > ...so to be clearer: Are there any places where a user might sensibly
> > type in a random-case string (e.g., in a power search or the like)
> > where case-sensitivity might cause a match failure, and are those
> > places (if any) documented somewhere that users are likely to find
> > them?

> Not really.

Ah, excellent. Thanks!

(I've been burned in the past by subtle changes in capitalization;
e.g., series that change from mixed-case to uppercase, and then there
are instances like k. d. lang where it's never clear whether the
broadcaster is going to capitalize it they way -they- like it or
the way every one else capitalizes names, etc...)

> > Nobody's going to just randomly find that changeset.
> >
> > (Looking at that changeset doesn't immediately make me think that
> > case-sensitivity is going to be a problem, but I probably wouldn't
> > notice it from a cursory scan.)

> Yeah, it only really has a direct effect on the user for keyword and
> people searches.

Ok.
_______________________________________________
mythtv-users mailing list
mythtv-users [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users

MythTV users RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.